Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtUtils::MakeMaker: recognize OTHERLDFLAGS #8152

Closed
p5pRT opened this issue Oct 14, 2005 · 6 comments
Closed

ExtUtils::MakeMaker: recognize OTHERLDFLAGS #8152

p5pRT opened this issue Oct 14, 2005 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Oct 14, 2005

Migrated from rt.perl.org#37433 (status was 'rejected')

Searchable as RT37433$

@p5pRT
Copy link
Author

p5pRT commented Oct 14, 2005

From skv@protey.ru

Overriding CCFLAGS and OTHERLDFLAGS from command line can be very useful
while testing and profiling XS code - i.e. see​:
http​://search.cpan.org/~pjcj/Devel-Cover-0.55/gcov2perl

These patches add OTHERLDFLAGS to @​attrib_help and extend dynamic_lib()​:

Inline Patch
--- MakeMaker.pm.orig	2005-10-14 15:37:07.907399600 +0400
+++ MakeMaker.pm	2005-10-14 15:37:09.969886400 +0400
@@ -229,6 +229,7 @@
      INC INCLUDE_EXT LDFROM LIB LIBPERL_A LIBS
      LINKTYPE MAKEAPERL MAKEFILE MAKEFILE_OLD MAN1PODS MAN3PODS MAP_TARGET
      MYEXTLIB NAME NEEDS_LINKING NOECHO NO_META NORECURS NO_VC OBJECT 
OPTIMIZE \+ OTHERLDFLAGS   PERL\_MALLOC\_OK PERL PERLMAINCC PERLRUN PERLRUNINST PERL\_CORE   PERL\_SRC PERM\_RW PERM\_RWX   PL\_FILES PM PM\_FILTER PMLIBDIRS POLLUTE PPM\_INSTALL\_EXEC
Inline Patch
--- MM_Unix.pm.orig	2005-10-14 15:50:09.277398800 +0400
+++ MM_Unix.pm	2005-10-14 15:50:25.824167900 +0400
@@ -889,7 +889,7 @@

      return '' unless $self->has_link_code;

-    my($otherldflags) = $attribs{OTHERLDFLAGS} || "";
+    my($otherldflags) = $attribs{OTHERLDFLAGS} || $self->{OTHERLDFLAGS} 
|| "";   my\($inst\_dynamic\_dep\) = $attribs\{INST\_DYNAMIC\_DEP\} || "";   my\($armaybe\) = $attribs\{ARMAYBE\} || $self\->\{ARMAYBE\} || "​:";   my\($ldfrom\) = '$\(LDFROM\)';

--
Sergey Skvortsov
mailto​: skv@​protey.ru

@p5pRT
Copy link
Author

p5pRT commented Nov 11, 2005

From @smpeters

[godegisel - Fri Oct 14 04​:58​:05 2005]​:

Overriding CCFLAGS and OTHERLDFLAGS from command line can be very useful
while testing and profiling XS code - i.e. see​:
http​://search.cpan.org/~pjcj/Devel-Cover-0.55/gcov2perl

These patches add OTHERLDFLAGS to @​attrib_help and extend dynamic_lib()​:

--- MakeMaker.pm.orig 2005-10-14 15​:37​:07.907399600 +0400
+++ MakeMaker.pm 2005-10-14 15​:37​:09.969886400 +0400
@​@​ -229,6 +229,7 @​@​
INC INCLUDE_EXT LDFROM LIB LIBPERL_A LIBS
LINKTYPE MAKEAPERL MAKEFILE MAKEFILE_OLD MAN1PODS MAN3PODS
MAP_TARGET
MYEXTLIB NAME NEEDS_LINKING NOECHO NO_META NORECURS NO_VC OBJECT
OPTIMIZE
+ OTHERLDFLAGS
PERL_MALLOC_OK PERL PERLMAINCC PERLRUN PERLRUNINST PERL_CORE
PERL_SRC PERM_RW PERM_RWX
PL_FILES PM PM_FILTER PMLIBDIRS POLLUTE PPM_INSTALL_EXEC

--- MM_Unix.pm.orig 2005-10-14 15​:50​:09.277398800 +0400
+++ MM_Unix.pm 2005-10-14 15​:50​:25.824167900 +0400
@​@​ -889,7 +889,7 @​@​

  return '' unless $self\->has\_link\_code;

- my($otherldflags) = $attribs{OTHERLDFLAGS} || "";
+ my($otherldflags) = $attribs{OTHERLDFLAGS} || $self->{OTHERLDFLAGS}
|| "";
my($inst_dynamic_dep) = $attribs{INST_DYNAMIC_DEP} || "";
my($armaybe) = $attribs{ARMAYBE} || $self->{ARMAYBE} || "​:";
my($ldfrom) = '$(LDFROM)';

I am concerned about this patch. Code similar to what is in MM_Unix.pm
is in other ExtUtils​::MM* files. So, rather than accidentially breaking
ExtUtils​::MakeMaker, I'm going to pass this patch off to the rt.cpan.org
queue for ExtUtils​::MakeMaker.

@p5pRT
Copy link
Author

p5pRT commented Nov 11, 2005

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 27, 2012

From @jkeenan

On Thu Nov 10 19​:10​:15 2005, stmpeters wrote​:

[godegisel - Fri Oct 14 04​:58​:05 2005]​:

Overriding CCFLAGS and OTHERLDFLAGS from command line can be very useful
while testing and profiling XS code - i.e. see​:
http​://search.cpan.org/~pjcj/Devel-Cover-0.55/gcov2perl

These patches add OTHERLDFLAGS to @​attrib_help and extend dynamic_lib()​:

--- MakeMaker.pm.orig 2005-10-14 15​:37​:07.907399600 +0400
+++ MakeMaker.pm 2005-10-14 15​:37​:09.969886400 +0400
@​@​ -229,6 +229,7 @​@​
INC INCLUDE_EXT LDFROM LIB LIBPERL_A LIBS
LINKTYPE MAKEAPERL MAKEFILE MAKEFILE_OLD MAN1PODS MAN3PODS
MAP_TARGET
MYEXTLIB NAME NEEDS_LINKING NOECHO NO_META NORECURS NO_VC OBJECT
OPTIMIZE
+ OTHERLDFLAGS
PERL_MALLOC_OK PERL PERLMAINCC PERLRUN PERLRUNINST PERL_CORE
PERL_SRC PERM_RW PERM_RWX
PL_FILES PM PM_FILTER PMLIBDIRS POLLUTE PPM_INSTALL_EXEC

--- MM_Unix.pm.orig 2005-10-14 15​:50​:09.277398800 +0400
+++ MM_Unix.pm 2005-10-14 15​:50​:25.824167900 +0400
@​@​ -889,7 +889,7 @​@​

  return '' unless $self\->has\_link\_code;

- my($otherldflags) = $attribs{OTHERLDFLAGS} || "";
+ my($otherldflags) = $attribs{OTHERLDFLAGS} ||
$self->{OTHERLDFLAGS}
|| "";
my($inst_dynamic_dep) = $attribs{INST_DYNAMIC_DEP} || "";
my($armaybe) = $attribs{ARMAYBE} || $self->{ARMAYBE} || "​:";
my($ldfrom) = '$(LDFROM)';

I am concerned about this patch. Code similar to what is in MM_Unix.pm
is in other ExtUtils​::MM* files. So, rather than accidentially breaking
ExtUtils​::MakeMaker, I'm going to pass this patch off to the rt.cpan.org
queue for ExtUtils​::MakeMaker.

I looked in the Active, Resolved and Rejected queues for
ExtUtils-MakeMaker underneath here​:
https://rt.cpan.org/Public/Dist/Display.html?Name=ExtUtils-MakeMaker.  I
could not locate any ticket with a subject line containing OTHERLDFLAGS.

Was this in fact referred to rt.cpan.org? Does anyone have any better
information?

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Jun 30, 2013

From @jkeenan

On Sat May 26 17​:54​:55 2012, jkeenan wrote​:

On Thu Nov 10 19​:10​:15 2005, stmpeters wrote​:

[godegisel - Fri Oct 14 04​:58​:05 2005]​:

Overriding CCFLAGS and OTHERLDFLAGS from command line can be very
useful
while testing and profiling XS code - i.e. see​:
http​://search.cpan.org/~pjcj/Devel-Cover-0.55/gcov2perl

These patches add OTHERLDFLAGS to @​attrib_help and extend
dynamic_lib()​:

--- MakeMaker.pm.orig 2005-10-14 15​:37​:07.907399600 +0400
+++ MakeMaker.pm 2005-10-14 15​:37​:09.969886400 +0400
@​@​ -229,6 +229,7 @​@​
INC INCLUDE_EXT LDFROM LIB LIBPERL_A LIBS
LINKTYPE MAKEAPERL MAKEFILE MAKEFILE_OLD MAN1PODS MAN3PODS
MAP_TARGET
MYEXTLIB NAME NEEDS_LINKING NOECHO NO_META NORECURS NO_VC
OBJECT
OPTIMIZE
+ OTHERLDFLAGS
PERL_MALLOC_OK PERL PERLMAINCC PERLRUN PERLRUNINST PERL_CORE
PERL_SRC PERM_RW PERM_RWX
PL_FILES PM PM_FILTER PMLIBDIRS POLLUTE PPM_INSTALL_EXEC

--- MM_Unix.pm.orig 2005-10-14 15​:50​:09.277398800 +0400
+++ MM_Unix.pm 2005-10-14 15​:50​:25.824167900 +0400
@​@​ -889,7 +889,7 @​@​

  return '' unless $self\->has\_link\_code;

- my($otherldflags) = $attribs{OTHERLDFLAGS} || "";
+ my($otherldflags) = $attribs{OTHERLDFLAGS} ||
$self->{OTHERLDFLAGS}
|| "";
my($inst_dynamic_dep) = $attribs{INST_DYNAMIC_DEP} || "";
my($armaybe) = $attribs{ARMAYBE} || $self->{ARMAYBE} || "​:";
my($ldfrom) = '$(LDFROM)';

I am concerned about this patch. Code similar to what is in MM_Unix.pm
is in other ExtUtils​::MM* files. So, rather than accidentially breaking
ExtUtils​::MakeMaker, I'm going to pass this patch off to the rt.cpan.org
queue for ExtUtils​::MakeMaker.

I looked in the Active, Resolved and Rejected queues for
ExtUtils-MakeMaker underneath here​:
https://rt.cpan.org/Public/Dist/Display.html?Name=ExtUtils-MakeMaker.  I
could not locate any ticket with a subject line containing OTHERLDFLAGS.

Was this in fact referred to rt.cpan.org? Does anyone have any better
information?

I can find no evidence that the report was, in fact, referred to
rt.cpan.org, so I have just done so​:
https://rt.cpan.org/Ticket/Display.html?id=86570

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Jun 30, 2013

@jkeenan - Status changed from 'open' to 'rejected'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant