Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RT #114144 to maint 5.16 #12307

Closed
p5pRT opened this issue Jul 30, 2012 · 4 comments
Closed

add RT #114144 to maint 5.16 #12307

p5pRT opened this issue Jul 30, 2012 · 4 comments
Labels
distro-mswin32 type-core

Comments

@p5pRT
Copy link

p5pRT commented Jul 30, 2012

Migrated from rt.perl.org#114320 (status was 'rejected')

Searchable as RT114320$
@p5pRT
Copy link
Author

p5pRT commented Jul 30, 2012

From @bulk88

Created by @bulk88

Would it be possible to add the 2 patches (1 has been applied to blead, the other hasn't been), in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=114144 (and a regen.pl) to the next 5.16?

I categorize as a portability fix, and they do not affect ABI since Win32 GCC Perls have been compiled with noreturn declaration for years, code after a longjmp is unreachable by definition. Perl claims to be ABI compatible Visual C Perl and Mingw GCC XS modules, see http​://www.perlmonks.org/?node_id=614808 , the other direction I am not sure about.

It will reduce about a dozen KB (in my experience) of unreachable machine code in the perl dll, and also reduce the size of any XS code compiled Visual C.

I propose this because 5.18 is 10 months away, and 5.16 still has 21 months on it.

Perl Info 

Flags:
    category=core
    severity=low

Site configuration information for perl 5.17.2:

Configured by Owner at Sat Jul 21 05:38:53 2012.

Summary of my perl5 (revision 5 version 17 subversion 2) configuration:
   
  Platform:
    osname=MSWin32, osvers=5.1, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cl', ccflags ='-nologo -GF -W3 -MD -Zi -DNDEBUG -O1 -GL -DWIN32 -D_CONSOLE -DNO_STRICT  -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T',
    optimize='-MD -Zi -DNDEBUG -O1 -GL',
    cppflags='-DWIN32'
    ccversion='13.10.6030', gccversion='', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='link', ldflags ='-nologo -nodefaultlib -debug -opt:ref,icf -ltcg  -libpath:"c:\perl517\lib\CORE"  -machine:x86'
    libpth="C:\Program Files\Microsoft Visual Studio .NET 2003\VC7\lib"
    libs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
    perllibs=oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib ws2_32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib comctl32.lib msvcrt.lib
    libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl517.lib
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -debug -opt:ref,icf -ltcg  -libpath:"c:\perl517\lib\CORE"  -machine:x86'

Locally applied patches:
    


@INC for perl 5.17.2:
    C:/perl517/site/lib
    C:/perl517/lib
    .


Environment for perl 5.17.2:
    HOME (unset)
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=C:\perl517\bin;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\IDE;C:\Program Files\Microsoft Visual Studio .NET 2003\VC7\BIN;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\Tools;C:\Program Files\Microsoft Visual Studio .NET 2003\Common7\Tools\bin\prerelease;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\system32\wbem;
    PERL_BADLANG (unset)
    SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Jul 31, 2012

From @jandubois

On Sun, 29 Jul 2012, bulk 88 (via RT) wrote​:

Would it be possible to add the 2 patches (1 has been applied to
blead, the other hasn't been), in

Thanks for mentioning the 2nd patch; I never saw email notifications
that the bug had be re-opened.

https://rt-archive.perl.org/perl5/Ticket/Display.html?id=114144 (and a regen.pl)
to the next 5.16?

I categorize as a portability fix, and they do not affect ABI since
Win32 GCC Perls have been compiled with noreturn declaration for
years, code after a longjmp is unreachable by definition. Perl claims
to be ABI compatible Visual C Perl and Mingw GCC XS modules, see
http​://www.perlmonks.org/?node_id=614808 , the other direction I am
not sure about.

It will reduce about a dozen KB (in my experience) of unreachable
machine code in the perl dll, and also reduce the size of any XS code
compiled Visual C.

I propose this because 5.18 is 10 months away, and 5.16 still has 21
months on it.

I don't see how this could possibly count as a portability fix; having
a few KB of unreachable code is not a serious issue at all in my mind,
so it does not fit the spirit of pod/perlpolicy.pod.

Cheers,
-Jan

@p5pRT
Copy link
Author

p5pRT commented Jul 31, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Dec 5, 2012

@bulk88 - Status changed from 'open' to 'rejected'

@p5pRT p5pRT closed this as completed Dec 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-mswin32 type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT