Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] 126c780 cflags: clang complains a lot about -Wunused-value which are not fixable #12150

Closed
p5pRT opened this issue May 31, 2012 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented May 31, 2012

Migrated from rt.perl.org#113450 (status was 'resolved')

Searchable as RT113450$

@p5pRT
Copy link
Author

p5pRT commented May 31, 2012

From @rurban

This is a bug report for perl from rurban@​cpanel.net,
generated with the help of perlbug 1.39 running under perl 5.17.0.

From 126c78033897e8672291fa097930f63931922102 Mon Sep 17 00​:00​:00 2001
From​: Reini Urban <rurban@​x-ray.at>
Date​: Thu, 31 May 2012 14​:58​:35 -0500
Subject​: [PATCH] cflags​: clang complains a lot about -Wunused-value which are
not fixable


cflags.SH | 4 ++++
1 file changed, 4 insertions(+)

Inline Patch
diff --git a/cflags.SH b/cflags.SH
index f57cf2f..ac03b85 100755
--- a/cflags.SH
+++ b/cflags.SH
@@ -337,6 +337,10 @@ for file do
     cppflags=`echo $cppflags|sed 's/-Wdeclaration-after-statement/ /'`
 
     case "$cc" in
+    *clang)
+      # clang complains a lot about -Wunused-value which are not fixable
+      warn="$warn -Wno-unused-value"
+      ;;
     *g++*)
       # Without -Wno-unused-variable g++ 4.x compiles are rather unwatchable
       # because of all the warnings about Perl___notused, and g++ doesn't do
-- 
1.7.10

Flags​:
  category=core
  severity=low


Site configuration information for perl 5.17.0​:

Configured by rurban at Tue May 29 09​:27​:49 CDT 2012.

Summary of my perl5 (revision 5 version 17 subversion 0) configuration​:
  Commit id​: 0e43c7fdc6d8aabdb55c0d58b87ede9788ef7992
  Platform​:
  osname=linux, osvers=3.2.0-2-amd64, archname=x86_64-linux-thread-multi-debug@​642ef7c1
  uname='linux reini 3.2.0-2-amd64 #1 smp tue mar 20 18​:36​:37 utc 2012 x86_64 gnulinux '
  config_args='-de -Dusedevel -Dinstallman1dir=none -Dinstallman3dir=none -Dinstallsiteman1dir=none -Dinstallsiteman3dir=none -Dmksymlinks -DEBUGGING -Doptimize=-g3 -Duseithreads -Accflags='-msse4.2' -Accflags='-march=corei7' -Dcf_email='rurban@​cpanel.net' -Dperladmin='rurban@​cpanel.net' -Duseshrplib'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -msse4.2 -march=corei7 -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-g3',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -msse4.2 -march=corei7 -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.6.3', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=, so=so, useshrplib=true, libperl=libperl.so
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/local/lib/perl5/5.17.0/x86_64-linux-thread-multi-debug@​642ef7c1/CORE'
  cccdlflags='-fPIC', lddlflags='-shared -g3 -L/usr/local/lib -fstack-protector'

Locally applied patches​:
 


@​INC for perl 5.17.0​:
  /usr/local/lib/perl5/site_perl/5.17.0/x86_64-linux-thread-multi-debug@​642ef7c1
  /usr/local/lib/perl5/site_perl/5.17.0
  /usr/local/lib/perl5/5.17.0/x86_64-linux-thread-multi-debug@​642ef7c1
  /usr/local/lib/perl5/5.17.0
  /usr/local/lib/perl5/site_perl
  .


Environment for perl 5.17.0​:
  HOME=/home/rurban
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/local/bin​:/usr/bin​:/bin​:/usr/games
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2012

From @tonycoz

On Thu, May 31, 2012 at 01​:00​:48PM -0700, rurban@​cpanel.net (via RT) wrote​:

diff --git a/cflags.SH b/cflags.SH
index f57cf2f..ac03b85 100755
--- a/cflags.SH
+++ b/cflags.SH
@​@​ -337,6 +337,10 @​@​ for file do
cppflags=`echo $cppflags|sed 's/-Wdeclaration-after-statement/ /'`

 case "$cc" in

+ *clang)
+ # clang complains a lot about -Wunused-value which are not fixable
+ warn="$warn -Wno-unused-value"
+ ;;
*g++*)
# Without -Wno-unused-variable g++ 4.x compiles are rather unwatchable
# because of all the warnings about Perl___notused, and g++ doesn't do

Not fixable in that we can't fix perl? or that clang can't be fixed?

Tony

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2012

From @khwilliamson

On 06/03/2012 07​:56 PM, Tony Cook wrote​:

On Thu, May 31, 2012 at 01​:00​:48PM -0700, rurban@​cpanel.net (via RT) wrote​:

diff --git a/cflags.SH b/cflags.SH
index f57cf2f..ac03b85 100755
--- a/cflags.SH
+++ b/cflags.SH
@​@​ -337,6 +337,10 @​@​ for file do
cppflags=`echo $cppflags|sed 's/-Wdeclaration-after-statement/ /'`

  case "$cc" in

+ *clang)
+ # clang complains a lot about -Wunused-value which are not fixable
+ warn="$warn -Wno-unused-value"
+ ;;
*g++*)
# Without -Wno-unused-variable g++ 4.x compiles are rather unwatchable
# because of all the warnings about Perl___notused, and g++ doesn't do

Not fixable in that we can't fix perl? or that clang can't be fixed?

Tony

I have tried to figure out a way to silence some of these warnings by
changing the C files, and could not. That's why I like this patch, but
defer to people who are wiser about these kinds of things.

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2012

From @rurban

That we cannot fix perl, without making it worse.

@p5pRT
Copy link
Author

p5pRT commented Jun 9, 2012

From @cpansprout

On Thu May 31 13​:00​:48 2012, rurban@​cpanel.net wrote​:

This is a bug report for perl from rurban@​cpanel.net,
generated with the help of perlbug 1.39 running under perl 5.17.0.

From 126c78033897e8672291fa097930f63931922102 Mon Sep 17 00​:00​:00 2001
From​: Reini Urban <rurban@​x-ray.at>
Date​: Thu, 31 May 2012 14​:58​:35 -0500
Subject​: [PATCH] cflags​: clang complains a lot about -Wunused-value
which are
not fixable

Thank you. Applied as d5db65c.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Jun 9, 2012

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant