Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] 50a7035 Correct variable name in example. #12074

Closed
p5pRT opened this issue Apr 29, 2012 · 8 comments
Closed

[PATCH] 50a7035 Correct variable name in example. #12074

p5pRT opened this issue Apr 29, 2012 · 8 comments

Comments

@p5pRT
Copy link

p5pRT commented Apr 29, 2012

Migrated from rt.perl.org#112686 (status was 'resolved')

Searchable as RT112686$

@p5pRT
Copy link
Author

p5pRT commented Apr 29, 2012

From @pjcj

This is a bug report for perl from paul@​pjcj.net,
generated with the help of perlbug 1.39 running under perl 5.14.2.

From 50a70358d3b080af8727bc00cf258d6c6e097939 Mon Sep 17 00​:00​:00 2001
From​: Paul Johnson <paul@​pjcj.net>
Date​: Sun, 29 Apr 2012 20​:27​:37 +0200
Subject​: [PATCH] Correct variable name in example.
MIME-Version​: 1.0
Content-Type​: multipart/mixed; boundary="------------1.7.5.4"

This is a multi-part message in MIME format.
--------------1.7.5.4
Content-Type​: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding​: 8bit

As noticed by Lawrence Statton <lawrence@​cluon.com>


pod/perlretut.pod | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

--------------1.7.5.4
Content-Type​: text/x-patch; name="0001-Correct-variable-name-in-example.patch"
Content-Transfer-Encoding​: 8bit
Content-Disposition​: attachment; filename="0001-Correct-variable-name-in-example.patch"

Inline Patch
diff --git a/pod/perlretut.pod b/pod/perlretut.pod
index d7e0412..a3ff6ad 100644
--- a/pod/perlretut.pod
+++ b/pod/perlretut.pod
@@ -1583,9 +1583,9 @@ there are no groupings, a list of matches to the whole regexp.  So if
 we wanted just the words, we could use
 
     @words = ($x =~ /(\w+)/g);  # matches,
-                                # $word[0] = 'cat'
-                                # $word[1] = 'dog'
-                                # $word[2] = 'house'
+                                # $words[0] = 'cat'
+                                # $words[1] = 'dog'
+                                # $words[2] = 'house'
 
 Closely associated with the C<//g> modifier is the C<\G> anchor.  The
 C<\G> anchor matches at the point where the previous C<//g> match left

--------------1.7.5.4--


---
Flags:   category=docs   severity=low

Site configuration information for perl 5.14.2​:

Configured by pjcj at Wed Sep 28 19​:16​:16 CEST 2011.

Summary of my perl5 (revision 5 version 14 subversion 2) configuration​:
 
  Platform​:
  osname=linux, osvers=2.6.38-11-generic, archname=x86_64-linux
  uname='linux posub64 2.6.38-11-generic #50-ubuntu smp mon sep 12 21​:17​:25 utc 2011 x86_64 x86_64 x86_64 gnulinux '
  config_args='-de -Dprefix=/home/pjcj/perl5/perlbrew/perls/perl-5.14.2'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2',
  cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.5.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib /usr/lib /usr/lib/x86_64-linux-gnu /lib64 /usr/lib64
  libs=-lnsl -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

Locally applied patches​:
 


@​INC for perl 5.14.2​:
  /home/pjcj/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/x86_64-linux
  /home/pjcj/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2
  /home/pjcj/perl5/perlbrew/perls/perl-5.14.2/lib/5.14.2/x86_64-linux
  /home/pjcj/perl5/perlbrew/perls/perl-5.14.2/lib/5.14.2
  .


Environment for perl 5.14.2​:
  HOME=/home/pjcj
  LANG=en_GB.UTF-8
  LANGUAGE=en_GB​:en
  LC_COLLATE=en_GB.UTF-8
  LC_CTYPE=en_US.UTF-8
  LC_MESSAGES=en_GB.UTF-8
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/home/pjcj/perl5/perlbrew/bin​:/home/pjcj/perl5/perlbrew/perls/perl-5.14.2/bin​:/home/pjcj/bin​:/home/pjcj/utils​:/home/pjcj/utils/perl​:/usr/local/bin​:/usr/bin​:/bin​:/usr/local/sbin​:/usr/sbin​:/sbin​:/usr/bin/X11​:/usr/games
  PERLBREW_BASHRC_VERSION=0.42
  PERLBREW_HOME=/home/pjcj/.perlbrew
  PERLBREW_PATH=/home/pjcj/perl5/perlbrew/bin​:/home/pjcj/perl5/perlbrew/perls/perl-5.14.2/bin
  PERLBREW_PERL=perl-5.14.2
  PERLBREW_ROOT=/home/pjcj/perl5/perlbrew
  PERLBREW_VERSION=0.29
  PERL_BADLANG (unset)
  SHELL=/usr/bin/zsh

@p5pRT
Copy link
Author

p5pRT commented Apr 30, 2012

From @pjcj

I was looking around for our policy on which sort of patches can be
accepted at which points in the release cycle, but didn't manage to find
it. It's quite possible that I have overlooked it, but it's also
possible that it only exists in the mailinglist archives. Can anyone
point out where it is?

But if I remember correctly, simple documentation fixes can go in until
fairly late. This patch would certainly fall within that category. But
on the other hand, there's no problem with keeping it until 5.17.

--
Paul Johnson - paul@​pjcj.net
http​://www.pjcj.net

@p5pRT
Copy link
Author

p5pRT commented May 1, 2012

From @jkeenan

On Sun Apr 29 11​:35​:21 2012, paul@​pjcj.net wrote​:

This is a bug report for perl from paul@​pjcj.net,
generated with the help of perlbug 1.39 running under perl 5.14.2.

[snip]

diff --git a/pod/perlretut.pod b/pod/perlretut.pod
index d7e0412..a3ff6ad 100644
--- a/pod/perlretut.pod
+++ b/pod/perlretut.pod
@​@​ -1583,9 +1583,9 @​@​ there are no groupings, a list of matches to the
whole regexp. So if
we wanted just the words, we could use

 @&#8203;words = \($x =~ /\(\\w\+\)/g\);  \# matches\,

- # $word[0] = 'cat'
- # $word[1] = 'dog'
- # $word[2] = 'house'
+ # $words[0] = 'cat'
+ # $words[1] = 'dog'
+ # $words[2] = 'house'

Closely associated with the C<//g> modifier is the C<\G> anchor. The
C<\G> anchor matches at the point where the previous C<//g> match
left

--------------1.7.5.4--

Patch looks good to me.

@p5pRT
Copy link
Author

p5pRT commented May 1, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 3, 2012

From @rjbs

applied, after vigorous swearing at rt

@p5pRT
Copy link
Author

p5pRT commented May 3, 2012

From [Unknown Contact. See original ticket]

applied, after vigorous swearing at rt

@p5pRT
Copy link
Author

p5pRT commented May 3, 2012

@rjbs - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed May 3, 2012
@p5pRT
Copy link
Author

p5pRT commented May 3, 2012

From @cpansprout

On Wed May 02 19​:46​:07 2012, rjbs wrote​:

applied

as 5a0c7e9.

--

Father Chrysostomos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant