New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] Win32 MSVC perlglob expansion in Encode #12072
Comments
From @rurbanThis is a bug report for perl from rurban@cpanel.net, From a5ad7f26363aa02510e89471d9fc277dacafc259 Mon Sep 17 00:00:00 2001 Win32 needs to expand glob via perlglob. But this needs perl.exe, not miniperl.exe cpan/Encode/Byte/Makefile.PL | 2 +- Inline Patchdiff --git a/cpan/Encode/Byte/Makefile.PL b/cpan/Encode/Byte/Makefile.PL
index 60caf38..88807ac 100644
--- a/cpan/Encode/Byte/Makefile.PL
+++ b/cpan/Encode/Byte/Makefile.PL
@@ -180,7 +180,7 @@ sub postamble
$plib .= " -MCross=$::Cross::platform" if defined $::Cross::platform;
my $ucopts = '-"Q" -"O"';
$str .=
- qq{\n\t\$(PERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
+ qq{\n\t\$(FULLPERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
open (FILELIST, ">$table.fnm")
|| die "Could not open $table.fnm: $!";
foreach my $file (@{$tables{$table}})
diff --git a/cpan/Encode/CN/Makefile.PL b/cpan/Encode/CN/Makefile.PL
index 6d54404..36a1d7b 100644
--- a/cpan/Encode/CN/Makefile.PL
+++ b/cpan/Encode/CN/Makefile.PL
@@ -156,7 +156,7 @@ sub postamble
$plib .= " -MCross=$::Cross::platform" if defined $::Cross::platform;
my $ucopts = '-"Q"';
$str .=
- qq{\n\t\$(PERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
+ qq{\n\t\$(FULLPERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
open (FILELIST, ">$table.fnm")
|| die "Could not open $table.fnm: $!";
foreach my $file (@{$tables{$table}})
diff --git a/cpan/Encode/EBCDIC/Makefile.PL b/cpan/Encode/EBCDIC/Makefile.PL
index 0e2a13c..82e557a 100644
--- a/cpan/Encode/EBCDIC/Makefile.PL
+++ b/cpan/Encode/EBCDIC/Makefile.PL
@@ -137,7 +137,7 @@ sub postamble
$plib .= " -MCross=$::Cross::platform" if defined $::Cross::platform;
my $ucopts = '-"Q" -"O"';
$str .=
- qq{\n\t\$(PERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
+ qq{\n\t\$(FULLPERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
open (FILELIST, ">$table.fnm")
|| die "Could not open $table.fnm: $!";
foreach my $file (@{$tables{$table}})
diff --git a/cpan/Encode/JP/Makefile.PL b/cpan/Encode/JP/Makefile.PL
index a75685e..15a7f18 100644
--- a/cpan/Encode/JP/Makefile.PL
+++ b/cpan/Encode/JP/Makefile.PL
@@ -156,7 +156,7 @@ sub postamble
$plib .= " -MCross=$::Cross::platform" if defined $::Cross::platform;
my $ucopts = '-"Q"';
$str .=
- qq{\n\t\$(PERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
+ qq{\n\t\$(FULLPERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
open (FILELIST, ">$table.fnm")
|| die "Could not open $table.fnm: $!";
foreach my $file (@{$tables{$table}})
diff --git a/cpan/Encode/KR/Makefile.PL b/cpan/Encode/KR/Makefile.PL
index e95d039..063a0d2 100644
--- a/cpan/Encode/KR/Makefile.PL
+++ b/cpan/Encode/KR/Makefile.PL
@@ -154,7 +154,7 @@ sub postamble
$plib .= " -MCross=$::Cross::platform" if defined $::Cross::platform;
my $ucopts = '-"Q"';
$str .=
- qq{\n\t\$(PERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
+ qq{\n\t\$(FULLPERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
open (FILELIST, ">$table.fnm")
|| die "Could not open $table.fnm: $!";
foreach my $file (@{$tables{$table}})
diff --git a/cpan/Encode/Symbol/Makefile.PL b/cpan/Encode/Symbol/Makefile.PL
index 23ca1f4..0fa8e8d 100644
--- a/cpan/Encode/Symbol/Makefile.PL
+++ b/cpan/Encode/Symbol/Makefile.PL
@@ -142,7 +142,7 @@ sub postamble
$plib .= " -MCross=$::Cross::platform" if defined $::Cross::platform;
my $ucopts = '-"Q" -"O"';
$str .=
- qq{\n\t\$(PERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
+ qq{\n\t\$(FULLPERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
open (FILELIST, ">$table.fnm")
|| die "Could not open $table.fnm: $!";
foreach my $file (@{$tables{$table}})
diff --git a/cpan/Encode/TW/Makefile.PL b/cpan/Encode/TW/Makefile.PL
index 99c94bf..b427f0e 100644
--- a/cpan/Encode/TW/Makefile.PL
+++ b/cpan/Encode/TW/Makefile.PL
@@ -152,7 +152,7 @@ sub postamble
$plib .= " -MCross=$::Cross::platform" if defined $::Cross::platform;
my $ucopts = '-"Q"';
$str .=
- qq{\n\t\$(PERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
+ qq{\n\t\$(FULLPERL) $plib $enc2xs $ucopts -o \$\@ -f $table.fnm\n\n};
open (FILELIST, ">$table.fnm")
|| die "Could not open $table.fnm: $!";
foreach my $file (@{$tables{$table}})
--
Flags: Site configuration information for perl 5.15.9: Summary of my perl5 (revision 5 version 15 subversion 8) configuration: Characteristics of this binary (from libperl): @INC for perl 5.15.9: Environment for perl 5.15.9: |
From @rjbsI'm curious as to why this isn't affecting everyone building on Win32. I see a number of reports Do you suppose it's because they have another perl already built in their %PATH%? |
The RT System itself - Status changed from 'new' to 'open' |
From @cpansproutOn Wed Apr 25 11:30:29 2012, rurban@cpanel.net wrote:
If, by perlglob, you mean the perlglob.exe built from win32/perlglob.c, miniperl’s glob operator uses perlglob. The Win32 Makefiles are The full perl doesn’t use perlglob. By forcing the use of perl.exe, you By using FULLPERL in Encode’s Makefiles, I think (without testing it) -- Father Chrysostomos |
From @steve-m-hayOn Thu May 03 20:22:11 2012, sprout wrote:
The Windows build makes miniperl.exe first, then perlglob.exe, then My (almost nightly) VC10 smoker builds everything fine and most Can we see an example of the output from whatever build failure is being |
From @rurbanMy windows is fresh, so I guess it's a missing perlglob in the PATH. I'll test it tomorrow. Ricardo SIGNES via RT <perlbug-followup@perl.org> wrote:
|
From @rurbanOn Fri, May 4, 2012 at 2:21 AM, Steve Hay via RT
Yes. I mixed that up. perlglob can be called from the shell ok.
Right. Encode is before File::Glob
I"m sorry, but I will not come to it for the next two weeks. |
From @cpansproutOn Wed Apr 25 11:30:29 2012, rurban@cpanel.net wrote:
I think the underlying issue has been fixed by commit 2501835. See bug If that is not the case, please say so and I will re-open the ticket. -- Father Chrysostomos |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#112612 (status was 'resolved')
Searchable as RT112612$
The text was updated successfully, but these errors were encountered: