Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] c5e5590 skip sigdispatch.t on cygwin RT#88814 #11900

Closed
p5pRT opened this issue Jan 24, 2012 · 4 comments
Closed

[PATCH] c5e5590 skip sigdispatch.t on cygwin RT#88814 #11900

p5pRT opened this issue Jan 24, 2012 · 4 comments

Comments

@p5pRT
Copy link

p5pRT commented Jan 24, 2012

Migrated from rt.perl.org#108948 (status was 'resolved')

Searchable as RT108948$

@p5pRT
Copy link
Author

p5pRT commented Jan 24, 2012

From cygwin@cygwin.com

This is a bug report for perl from cygwin@​cygwin.com,
generated with the help of perlbug 1.39 running under perl 5.10.1.

From c5e55904c1bf97924e67dbd54a82a2864be4c427 Mon Sep 17 00​:00​:00 2001
From​: Reini Urban <rurban@​x-ray.at>
Date​: Tue, 24 Jan 2012 09​:30​:47 -0600
Subject​: [PATCH] skip sigdispatch.t on cygwin RT#88814
MIME-Version​: 1.0
Content-Type​: multipart/mixed; boundary="------------1.7.5.1"

This is a multi-part message in MIME format.
--------------1.7.5.1
Content-Type​: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding​: 8bit


t/op/sigdispatch.t | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)

--------------1.7.5.1
Content-Type​: text/x-patch; name="0001-skip-sigdispatch.t-on-cygwin-RT-88814.patch"
Content-Transfer-Encoding​: 8bit
Content-Disposition​: attachment; filename="0001-skip-sigdispatch.t-on-cygwin-RT-88814.patch"

Inline Patch
diff --git a/t/op/sigdispatch.t b/t/op/sigdispatch.t
index 3b8d6ec..332507f 100644
--- a/t/op/sigdispatch.t
+++ b/t/op/sigdispatch.t
@@ -41,8 +41,8 @@ is($@, "Alarm!\n", 'after the second loop');
 SKIP: {
     skip('We can\'t test blocking without sigprocmask', 17)
 	if is_miniperl() || !$Config{d_sigprocmask};
-    skip('This doesn\'t work on OpenBSD threaded builds RT#88814', 17)
-        if $^O eq 'openbsd' && $Config{useithreads};
+    skip('This doesn\'t work on $^O threaded builds RT#88814', 17)
+        if $^O =~ /openbsd|cygwin/ && $Config{useithreads};
 
     require POSIX;
     my $pending = POSIX::SigSet->new();
@@ -55,6 +55,8 @@ SKIP: {
     $SIG{USR1} = sub { $gotit++ };
     kill 'SIGUSR1', $$;
     is $gotit, 0, 'Haven\'t received third signal yet';
+
+    diag "2nd sigpending crashes on cygwin" if $^O eq 'cygwin';
     is POSIX::sigpending($pending), '0 but true', 'sigpending';
     is $pending->ismember(&POSIX::SIGUSR1), 1, 'SIGUSR1 is pending';
     
@@ -101,7 +103,7 @@ TODO:
 
 SKIP: {
     skip("alarm cannot interrupt blocking system calls on $^O", 2)
-	if ($^O eq 'MSWin32' || $^O eq 'VMS');
+	if $^O =~ /MSWin32|cygwin|VMS/;
     # RT #88774
     # make sure the signal handler's called in an eval block *before*
     # the eval is popped

--------------1.7.5.1--


---
Flags:   category=core   severity=medium

Site configuration information for perl 5.10.1​:

Configured by rurban at Sat Aug 28 20​:14​:06 CEST 2010.

Summary of my perl5 (revision 5 version 10 subversion 1) configuration​:
 
  Platform​:
  osname=cygwin, osvers=1.7.5(0.22553), archname=i686-cygwin-thread-multi-64int
  uname='cygwin_nt-5.1 reini 1.7.5(0.22553) 2010-04-12 19​:07 i686 cygwin '
  config_args='-de -Dlibperl=cygperl5_10.dll -Dcc=gcc-4 -Dld=g++-4 -Dmksymlinks -Dusethreads -Dmad=y -Doptimize=-O3 -Accflags=-g3'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=undef, uselongdouble=undef
  usemymalloc=y, bincompat5005=undef
  Compiler​:
  cc='gcc-4', ccflags ='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -g3 -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
  optimize='-O3',
  cppflags='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -g3 -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.3.4 20090804 (release) 1', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
  ivtype='long long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='g++-4', ldflags =' -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--stack,8388608 -Wl,--enable-auto-image-base -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib /lib
  libs=-lgdbm -ldb -ldl -lcrypt -lgdbm_compat
  perllibs=-ldl -lcrypt
  libc=/usr/lib/libc.a, so=dll, useshrplib=true, libperl=cygperl5_10.dll
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' --shared -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--stack,8388608 -Wl,--enable-auto-image-base -L/usr/local/lib -fstack-protector'

Locally applied patches​:
  CYG11 no-bs
  CYG12 no archlib in otherlibdirs
  CYG14 Dynaloader
  CYG15 static-Win32CORE
  CYG17 utf8-paths
  CYG21 LibList-Kid.patch
  CYG22 cygwin-1.7 hints
  CYG23 544-stat
  CYG24 build man pages
  CYG25 rebase_privlib
  Module-Build-0.36_13
  Bug#55162 CYG18 File​::Spec​::case_tolerant performance
  disable ExtUtils​::MakeMaker​::Coverage in Sys-Syslog


@​INC for perl 5.10.1​:
  /usr/lib/perl5/5.10/i686-cygwin
  /usr/lib/perl5/5.10
  /usr/lib/perl5/site_perl/5.10/i686-cygwin
  /usr/lib/perl5/site_perl/5.10
  /usr/lib/perl5/vendor_perl/5.10/i686-cygwin
  /usr/lib/perl5/vendor_perl/5.10
  /usr/lib/perl5/vendor_perl/5.10
  /usr/lib/perl5/site_perl/5.8
  /usr/lib/perl5/vendor_perl/5.8
  .


Environment for perl 5.10.1​:
  HOME=/home/rurban
  LANG=C.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/home/rurban/bin​:/usr/bin​:/usr/local/bin​:/sbin​:/usr/sbin​:/home/rurban/bin​:/cygdrive/c/WINDOWS/system32​:/cygdrive/c/WINDOWS
  PERL_BADLANG (unset)
  PERL_JSON_BACKEND=JSON​::XS
  PERL_YAML_BACKEND=YAML
  SHELL (unset)

@p5pRT
Copy link
Author

p5pRT commented Jan 24, 2012

From @cpansprout

On Tue Jan 24 07​:36​:23 2012, cygwin@​cygwin.com wrote​:

This is a bug report for perl from cygwin@​cygwin.com,
generated with the help of perlbug 1.39 running under perl 5.10.1.

From c5e55904c1bf97924e67dbd54a82a2864be4c427 Mon Sep 17 00​:00​:00 2001
From​: Reini Urban <rurban@​x-ray.at>
Date​: Tue, 24 Jan 2012 09​:30​:47 -0600
Subject​: [PATCH] skip sigdispatch.t on cygwin RT#88814
MIME-Version​: 1.0
Content-Type​: multipart/mixed; boundary="------------1.7.5.1"

This is a multi-part message in MIME format.
--------------1.7.5.1
Content-Type​: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding​: 8bit

---
t/op/sigdispatch.t | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)

--------------1.7.5.1
Content-Type​: text/x-patch; name="0001-skip-sigdispatch.t-on-cygwin-
RT-88814.patch"
Content-Transfer-Encoding​: 8bit
Content-Disposition​: attachment; filename="0001-skip-sigdispatch.t-on-
cygwin-RT-88814.patch"

diff --git a/t/op/sigdispatch.t b/t/op/sigdispatch.t
index 3b8d6ec..332507f 100644
--- a/t/op/sigdispatch.t
+++ b/t/op/sigdispatch.t

Thank you. Applied as 0ac0889.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Jan 24, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jan 24, 2012

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant