New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.14.0-642-g3ed94dc brakes AVAR/YAML-Syck-1.17.tar.gz #11724
Comments
From @andkgit bisect 3ed94dc is the first bad commit sample fail report http://www.cpantesters.org/cpan/report/13085272 perl -V Summary of my perl5 (revision 5 version 15 subversion 0) configuration: Characteristics of this binary (from libperl): |
From @cpansproutOn Mon Oct 31 15:09:00 2011, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
I wrote in
-- Father Chrysostomos |
The RT System itself - Status changed from 'new' to 'open' |
From @cpansproutI’ve just noticed the subject. Are you saying YAML::Syck is now slower? :-) -- Father Chrysostomos |
From @andk
> I’ve just noticed the subject. Are you saying YAML::Syck is now slower? :-) Oops, no! :) -- |
From @cpansproutI’m making this a 5.16 blocker, as it has 152 direct dependents, and 628 -- Father Chrysostomos |
From @tseeOn 11/02/2011 03:30 AM, Father Chrysostomos via RT wrote:
AEvar as made me primary maintainer of the module and added me to the Could somebody else please come up with a patch? --Steffen PS: Yes, I know everyone is now laughing at my naiveness. |
From @cpansproutOn Wed Nov 02 13:26:12 2011, smueller@cpan.org wrote:
Which of the five bug workarounds would you prefer? (You don’t have to answer that.) |
From @cpansproutOn Wed Nov 02 13:26:12 2011, smueller@cpan.org wrote:
See attachment. Interestingly: $ perl5.8.1 Makefile.PL But the tests passed anyway. I tested it with blead (f364061), 5.14.2, 5.12.4, 5.10.1, 5.10.0, 5.8.9, -- Father Chrysostomos |
From @cpansproutInline Patchdiff -rup YAML-Syck-1.17-CbywAU-orig/Changes YAML-Syck-1.17-CbywAU/Changes
--- YAML-Syck-1.17-CbywAU-orig/Changes 2010-11-21 08:41:23.000000000 -0800
+++ YAML-Syck-1.17-CbywAU/Changes 2011-11-02 16:03:59.000000000 -0700
@@ -1,3 +1,9 @@
+[Changes for ....]
+
+* perl RT #102606 - Only lvalue subroutines are supposed to return
+ the argument to "return" without copying it. Stop relying on a
+ pre-5.15 bug.
+
[Changes for 1.17 (YAML::Syck 0.40 ) - 2010-11-21]
* Change a C99 comment to a C89 comment
diff -rup YAML-Syck-1.17-CbywAU-orig/lib/YAML/Syck.pm YAML-Syck-1.17-CbywAU/lib/YAML/Syck.pm
--- YAML-Syck-1.17-CbywAU-orig/lib/YAML/Syck.pm 2010-11-21 08:41:22.000000000 -0800
+++ YAML-Syck-1.17-CbywAU/lib/YAML/Syck.pm 2011-11-02 16:16:53.000000000 -0700
@@ -13,7 +13,7 @@ use 5.006;
use Exporter;
BEGIN {
- $VERSION = '1.17';
+ $VERSION = '1.18';
@EXPORT = qw( Dump Load DumpFile LoadFile );
@ISA = qw( Exporter );
@@ -67,6 +67,10 @@ sub Dump {
: YAML::Syck::DumpYAML($_[0]);
}
+# We should be doing this always, but lvalue subs are too buggy prior
+# to 5.15. For pre-5.15, we are actually relying on a leavesub bug.
+BEGIN { if ($] ge '5.015') { eval 'sub Load :lvalue' } }
+
sub Load {
if (wantarray) {
my ($rv) = YAML::Syck::LoadYAML($_[0]); |
From @cpansproutOn Wed Nov 02 16:25:12 2011, sprout wrote:
Please disregard that one. Here’s a much better patch. -- Father Chrysostomos |
From @cpansproutInline Patchdiff -rup YAML-Syck-1.17-CbywAU-orig/Changes YAML-Syck-1.17-CbywAU/Changes
--- YAML-Syck-1.17-CbywAU-orig/Changes 2010-11-21 08:41:23.000000000 -0800
+++ YAML-Syck-1.17-CbywAU/Changes 2011-11-02 16:03:59.000000000 -0700
@@ -1,3 +1,9 @@
+[Changes for ....]
+
+* perl RT #102606 - Only lvalue subroutines are supposed to return
+ the argument to "return" without copying it. Stop relying on a
+ pre-5.15 bug.
+
[Changes for 1.17 (YAML::Syck 0.40 ) - 2010-11-21]
* Change a C99 comment to a C89 comment
diff -rup YAML-Syck-1.17-CbywAU-orig/lib/YAML/Syck.pm YAML-Syck-1.17-CbywAU/lib/YAML/Syck.pm
--- YAML-Syck-1.17-CbywAU-orig/lib/YAML/Syck.pm 2010-11-21 08:41:22.000000000 -0800
+++ YAML-Syck-1.17-CbywAU/lib/YAML/Syck.pm 2011-11-02 17:55:39.000000000 -0700
@@ -13,7 +13,7 @@ use 5.006;
use Exporter;
BEGIN {
- $VERSION = '1.17';
+ $VERSION = '1.18';
@EXPORT = qw( Dump Load DumpFile LoadFile );
@ISA = qw( Exporter );
@@ -73,7 +73,8 @@ sub Load {
@{$rv};
}
else {
- YAML::Syck::LoadYAML($_[0]);
+ @_ = $_[0];
+ goto &YAML::Syck::LoadYAML;
}
}
|
From @tseeOn 11/03/2011 01:58 AM, Father Chrysostomos via RT wrote:
Thanks, applied, tested, and released as a developer release. Feel free Best regards, |
@tsee - Status changed from 'open' to 'resolved' |
From paul@city-fan.orgOn Thu Nov 03 00:09:50 2011, smueller@cpan.org wrote:
This fix seems to cause t/leak.t to die with Perl < 5.10.0: $ make test TEST_FILES=t/leak.t TEST_VERBOSE=1 t/leak.t 0 139 11 14 127.27% 5-11 |
From @cpansproutOn Sun Nov 06 05:09:47 2011, pghmcfc wrote:
It crashes in 5.8.8, but not 5.8.9. I suspect an incompatibility Is it worth building a debugging 5.8.8 (which will not go smoothly) to -- Father Chrysostomos |
From @tseeOn 11/06/2011 08:53 PM, Father Chrysostomos via RT wrote:
Should be skipped. YAML::Syck is apparently long deprecated. Will do that asap. Best regards, |
From @tseeOn 11/06/2011 09:45 PM, Steffen Mueller wrote:
Done, YAML::Syck 1.19 without the t/leak.t for pre 5.8.9 perls released. --Steffen |
From paul@city-fan.orgOn Sun Nov 06 11:53:39 2011, sprout wrote:
Possibly, but the leak.t test *did* work on Perls prior to 5.8.9 prior |
Migrated from rt.perl.org#102606 (status was 'resolved')
Searchable as RT102606$
The text was updated successfully, but these errors were encountered: