Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_version.pl problem when run in Windows Command Prompt window. #2333

Closed
p6rt opened this issue Jan 20, 2011 · 6 comments
Closed

get_version.pl problem when run in Windows Command Prompt window. #2333

p6rt opened this issue Jan 20, 2011 · 6 comments

Comments

@p6rt
Copy link

p6rt commented Jan 20, 2011

Migrated from rt.perl.org#82524 (status was 'resolved')

Searchable as RT82524$

@p6rt
Copy link
Author

p6rt commented Jan 20, 2011

From @thundergnat

When building Rakudo under Windows, I noticed several warnings "fatal​:
No names found, cannot describe anything." during the make process.
Investigating it closer, it stems from Windows Command.exe CLI being
obstreperous about what quoting it will accept.

In /build/gen_version.pl, the line​:

if (-d '.git' && open(my $GIT, '-|', "git describe --match '2*'")) {

https://github.com/rakudo/rakudo/blob/master/build/gen_version.pl#L17

fails because the Command.exe doesn't like the single quotes around
'2*'. Changing it to​:

if (-d '.git' && open(my $GIT, '-|', "git describe --match \"2*\"")) {

lets it work correctly and shouldn't affect less brain dead terminals
negatively.

Before​:

C​:\Rakudo>C​:\strawberry\perl\bin\perl.exe build\gen_version.pl
# generated by build/gen_version.pl
fatal​: No names found, cannot describe anything.
.macro_const RAKUDO_VERSION ''
.macro_const RAKUDO_BUILD_DATE '2011-01-20T12​:59​:53Z'

C​:\Rakudo>perl6 -v
This is Rakudo Perl 6, version built on parrot 3.0.0 RELEASE_3_0_0

After​:

C​:\Rakudo>C​:\strawberry\perl\bin\perl.exe build\gen_version.pl
# generated by build/gen_version.pl
.macro_const RAKUDO_VERSION '2010.12-47-g13b405c'
.macro_const RAKUDO_BUILD_DATE '2011-01-20T13​:00​:03Z'

C​:\Rakudo>perl6 -v
This is Rakudo Perl 6, version 2010.12-47-g13b405c built on parrot
3.0.0 RELEASE_3_0_0

Patch attached.

@p6rt
Copy link
Author

p6rt commented Jan 20, 2011

From @thundergnat

gen_version_patch

@p6rt
Copy link
Author

p6rt commented Nov 14, 2013

From @coke

On Thu Jan 20 05​:47​:29 2011, thundergnat wrote​:

When building Rakudo under Windows, I noticed several warnings "fatal​:
No names found, cannot describe anything." during the make process.
Investigating it closer, it stems from Windows Command.exe CLI being
obstreperous about what quoting it will accept.

In /build/gen_version.pl, the line​:

if (-d '.git' && open(my $GIT, '-|', "git describe --match '2*'")) {

https://github.com/rakudo/rakudo/blob/master/build/gen_version.pl#L17

fails because the Command.exe doesn't like the single quotes around
'2*'. Changing it to​:

if (-d '.git' && open(my $GIT, '-|', "git describe --match \"2*\"")) {

lets it work correctly and shouldn't affect less brain dead terminals
negatively.

Before​:

C​:\Rakudo>C​:\strawberry\perl\bin\perl.exe build\gen_version.pl
# generated by build/gen_version.pl
fatal​: No names found, cannot describe anything.
.macro_const RAKUDO_VERSION ''
.macro_const RAKUDO_BUILD_DATE '2011-01-20T12​:59​:53Z'

C​:\Rakudo>perl6 -v
This is Rakudo Perl 6, version built on parrot 3.0.0 RELEASE_3_0_0

After​:

C​:\Rakudo>C​:\strawberry\perl\bin\perl.exe build\gen_version.pl
# generated by build/gen_version.pl
.macro_const RAKUDO_VERSION '2010.12-47-g13b405c'
.macro_const RAKUDO_BUILD_DATE '2011-01-20T13​:00​:03Z'

C​:\Rakudo>perl6 -v
This is Rakudo Perl 6, version 2010.12-47-g13b405c built on parrot
3.0.0 RELEASE_3_0_0

Patch attached.

Thanks for the report.

This file is now here​: parrot/tools/build/gen_version.pl

And no longer has the line referenced above; so any remaining problems are hopefully different. Closing ticket.

If you still have windows build problems with the current build system, please open a new ticket, thanks!

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Nov 14, 2013

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Oct 13, 2014

From @usev6

On the last note by Will Coleda I'm closing the ticket.

@p6rt
Copy link
Author

p6rt commented Oct 13, 2014

@usev6 - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant