Bug #38741 for qpsmtpd: [PATCH] Handle multi-line responses from plugins (Re: smtp-forward plugin) (fwd)

# Thu, 16 Mar 2006 07:28:39 -0800 Charlie Brady <charlieb@budge.apana.org.au> - Ticket created [Reply] [Comment]

Subject:	[PATCH] Handle multi-line responses from plugins (Re: smtp-forward plugin) (fwd)
Date:	Thu, 16 Mar 2006 10:28:16 -0500 (EST)
To:	bugs-qpsmtpd [...] rt.perl.org
From:	Charlie Brady <charlieb [...] budge.apana.org.au>

Download (untitled) / with headers
text/plain 957b

Show quoted text

---------- Forwarded message ---------- Date: Wed, 15 Mar 2006 12:01:54 -0500 (EST) From: Charlie Brady <charlieb-qpsmtpd@budge.apana.org.au> To: qpsmtpd@perl.org Subject: [PATCH] Handle multi-line responses from plugins (Re: smtp-forward plugin) On Thu, 2 Mar 2006, Charlie Brady wrote:

> The second problem is that Qpsmtpd::SMTP doesn't do the right thing with > multiline responses from plugins. If a response has any embedded newlines, > it should do a split on newlines before calling response(). > > run_hooks() allows plugins to return an array, but Qpsmtpd::SMTP discards > all but the first item on the list, and therefore doesn't pass the array to > response().

Both issues dealt with in the attached patch (against 0.32). These changes are required for a fully working smtp-forward plugin, as we wish to faithfully relay responses from the backend SMTP server. The also allow plugins to be more verbose in replies. --- Charlie

Download SMTP.pm.diff
text/plain 10.2k

Message body is not shown because sender requested not to inline it.

# Mon, 20 Mar 2006 07:28:15 -0800 John Peacock <jpeacock@cpan.org> - Correspondence added [Reply] [Comment]

Download (untitled) / with headers
text/plain 75b

Committed. Can you think of a simple way to test this functionality? John

# Mon, 20 Mar 2006 07:28:17 -0800 The RT System itself - Status changed from 'new' to 'open'

# Mon, 20 Mar 2006 07:28:17 -0800 John Peacock <jpeacock@cpan.org> - Status changed from 'open' to 'resolved'

# Mon, 20 Mar 2006 09:12:56 -0800 Charlie Brady <charlieb@budge.apana.org.au> - Correspondence added [Reply] [Comment]

Subject:	Re: [perl #38741] [PATCH] Handle multi-line responses from plugins (Re: smtp-forward plugin) (fwd)
Date:	Mon, 20 Mar 2006 12:10:28 -0500 (EST)
To:	John Peacock via RT <qpsmtpd-bugs-followup [...] develooper.com>
From:	Charlie Brady <charlieb [...] budge.apana.org.au>

Download (untitled) / with headers
text/plain 416b

On Mon, 20 Mar 2006, John Peacock via RT wrote: Show quoted text

> Committed. Can you think of a simple way to test this functionality?

- Write a plugin which returns "string1\nstring2". Check what is sent back to the client. - Write a plugin which returns ("string1", "string2"). Check what is sent back to the client. - Write a plugin which returns ("string1\nstring2", "string3"). Check what is sent back to the client.

# Mon, 20 Mar 2006 09:12:58 -0800 The RT System itself - Status changed from 'resolved' to 'open'

# Mon, 20 Mar 2006 11:42:11 -0800 John Peacock <jpeacock@rowman.com> - Correspondence added [Reply] [Comment]

CC:	John Peacock via RT <qpsmtpd-bugs-followup [...] develooper.com>
Subject:	Re: [perl #38741] [PATCH] Handle multi-line responses from plugins(Re: smtp-forward plugin) (fwd)
Date:	Mon, 20 Mar 2006 14:42:08 -0500
To:	qpsmtpd [...] perl.org, Charlie Brady <charlieb [...] budge.apana.org.au>
From:	John Peacock <jpeacock [...] rowman.com>

Download (untitled) / with headers
text/plain 655b

Charlie Brady wrote: Show quoted text

> > On Mon, 20 Mar 2006, John Peacock via RT wrote: >

>> Committed. Can you think of a simple way to test this functionality?

> > - Write a plugin which returns "string1\nstring2". Check what is sent > back to the client. > > - Write a plugin which returns ("string1", "string2"). Check what is > sent back to the client. > > - Write a plugin which returns ("string1\nstring2", "string3"). Check > what is sent back to the client.

I guess we will have to wait on the "multiple plugin directories" patch that was discussed last week(?), since right now, there is no way to create a plugin for testing purposes only. John

# Mon, 20 Mar 2006 12:55:04 -0800 Charlie Brady <charlieb@budge.apana.org.au> - Correspondence added [Reply] [Comment]

Subject:	Re: [perl #38741] [PATCH] Handle multi-line responses from plugins(Re: smtp-forward plugin) (fwd)
Date:	Mon, 20 Mar 2006 15:49:35 -0500 (EST)
To:	John Peacock via RT <qpsmtpd-bugs-followup [...] develooper.com>
From:	Charlie Brady <charlieb [...] budge.apana.org.au>

Download (untitled) / with headers
text/plain 849b

On Mon, 20 Mar 2006, John Peacock via RT wrote: Show quoted text

> Charlie Brady wrote:

>> >> On Mon, 20 Mar 2006, John Peacock via RT wrote: >>

>>> Committed. Can you think of a simple way to test this functionality?

>> >> - Write a plugin which returns "string1\nstring2". Check what is sent >> back to the client. >> >> - Write a plugin which returns ("string1", "string2"). Check what is >> sent back to the client. >> >> - Write a plugin which returns ("string1\nstring2", "string3"). Check >> what is sent back to the client.

> > I guess we will have to wait on the "multiple plugin directories" patch > that was discussed last week(?), since right now, there is no way to > create a plugin for testing purposes only.

Sure there is. Just drop a file in the right place. But for the sake of testing, temporarily hacking any existing plugin will suffice.