New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.21.1-11-g4077a6b breaks GFUJI/Text-Xslate-3.2.4.tar.gz #13952
Comments
From @andkgit bisect commit 4077a6b Add a new warning about redundant printf arguments also affected TOBYINK/Kavorka-0.030.tar.gz sample fail report http://www.cpantesters.org/cpan/report/c8e16e60-f97a-11e3-b4ce-9dae0a370852 perl -V Summary of my perl5 (revision 5 version 21 subversion 2) configuration: Characteristics of this binary (from libperl): |
From @jkeenanOn Sun Jun 22 23:04:08 2014, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
I confirmed each of these failures with a program evolved from khw's debug program. Before we go submitting patches to the various CPAN authors, I would like to ask: Have we decided to include this new new feature in 5.22? Thank you very much. |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Tue Jun 24 13:39:43 2014, jkeenan wrote:
Four months ago, I asked for opinions on the question of this proposed new warning and -- surprisingly, for this list -- got none! So how shall we proceed? Thank you very much. -- |
From @khwilliamsonOn Thu Oct 16 18:13:59 2014, jkeenan wrote:
FWIW, I think this is useful to include in 5.22 |
From @andkalso affected: |
From @cpansproutOn Thu Oct 16 18:49:50 2014, khw wrote:
I have just looked at Badger, and the offending code is this subroutine in lib/Badger/Utils.pm: sub xprintf { Getting code like that to work around the warning is going to be a pain. And, to me, this code seems perfectly idiomatic. I’m not sure this warning is so helpful after all. (Especially consider that redundant arguments are generally harmless, whereas missing arguments are generally indications of a bug.) -- Father Chrysostomos |
From @cpansproutOn Sun Nov 16 16:56:51 2014, sprout wrote:
However, ‘printf "%s", $foo, $bar’ is almost undoubtedly a mistake. So maybe what we really want to do is make this a compile-time warning that only applies when we know ahead of time that the list will overflow the format. -- Father Chrysostomos |
From @rjbs* Father Chrysostomos via RT <perlbug-followup@perl.org> [2014-11-16T19:56:51]
I fixed a real bug in PAUSE because of this warning, this week. -- |
From @cpansproutOn Sun Nov 23 14:18:01 2014, perl.p5p@rjbs.manxome.org wrote:
And since I wrote that I have seen about 3 or 4 cases of false positives, and one case of clearly badly-written code. The latter would have been caught by my suggestion of doing a compile-time check. What do you think of that suggestion, BTW? Would it have caught the PAUSE bug? It’s basically to warn only about sprintf "constant string", $known, $number, $of, $arguments. -- Father Chrysostomos |
From @rjbs* Father Chrysostomos via RT <perlbug-followup@perl.org> [2014-11-23T19:06:38]
It would not, fwiw, have caught the PAUSE bug, which passed the arguments in an In https://rt.perl.org/Public/Bug/Display.html?id=122159#txn-1318809 you vited I don't have really strong feelings about this warning, but I remain leaning -- |
From @cpansproutOn Sat Feb 07 18:48:00 2015, perl.p5p@rjbs.manxome.org wrote:
In that case I relent, especially since I don’t want to go fiddling with that type of op tree examination this close to 5.22. -- Father Chrysostomos |
From @cpansproutOne thing we really ought to do, in addition to patching the failing modules, is fix this message, which I get when starting the CPAN shell, since it is embarrassing: Redundant argument in sprintf at /usr/local/lib/perl5/5.21.11/CPAN.pm line 314. -- Father Chrysostomos |
From @andk
> One thing we really ought to do, in addition to patching the failing Oh yes, how embarrassing. I never saw it until now, sorry for that. From 0aae0334bc38975f7ebea5fd9bf244d3f3684e5d Mon Sep 17 00:00:00 2001 lib/CPAN.pm | 3 +-- Inline Patchdiff --git a/lib/CPAN.pm b/lib/CPAN.pm
index 60a5e6c..731765c 100644
--- a/lib/CPAN.pm
+++ b/lib/CPAN.pm
@@ -2,7 +2,7 @@
# vim: ts=4 sts=4 sw=4:
use strict;
package CPAN;
-$CPAN::VERSION = '2.10';
+$CPAN::VERSION = '2.11';
$CPAN::VERSION =~ s/_//;
# we need to run chdir all over and we would get at wrong libraries
@@ -318,7 +318,6 @@ Enter 'h' for help.
},
$CPAN::VERSION,
- $rl_avail
)
}
my($continuation) = "";
--
-- |
From @andk0001-Fix-Redundant-argument-in-sprintf-reported-by-Father.patchFrom 0aae0334bc38975f7ebea5fd9bf244d3f3684e5d Mon Sep 17 00:00:00 2001
From: Andreas Koenig <andk@cpan.org>
Date: Wed, 25 Mar 2015 23:47:01 +0100
Subject: [PATCH] Fix "Redundant argument in sprintf", reported by Father
Chrysostomos
---
lib/CPAN.pm | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/CPAN.pm b/lib/CPAN.pm
index 60a5e6c..731765c 100644
--- a/lib/CPAN.pm
+++ b/lib/CPAN.pm
@@ -2,7 +2,7 @@
# vim: ts=4 sts=4 sw=4:
use strict;
package CPAN;
-$CPAN::VERSION = '2.10';
+$CPAN::VERSION = '2.11';
$CPAN::VERSION =~ s/_//;
# we need to run chdir all over and we would get at wrong libraries
@@ -318,7 +318,6 @@ Enter 'h' for help.
},
$CPAN::VERSION,
- $rl_avail
)
}
my($continuation) = "";
--
2.1.4
|
From @tonycozMost of the modules mentioned in this ticket have been updated, the exceptions are: HKOBA/YATT-v0.0.8.tar.gz - this has been broken since inlinable constants changed ANDK/CPAN - as discussed in this ticket. One of the dists doesn't seem to have had a format issue: SATOH/Teng-0.23.tar.gz - now at 0.28, the only change (in 0.25) I saw involving The following have been fixed: GFUJI/Text-Xslate-3.2.4.tar.gz - fixed in 3.3.1 (Unicode-Stringprep is a dep too TOBYINK/Kavorka-0.030.tar.gz - fixed in 0.032. JMATES/App-MusicTools-1.16.tar.gz - fixed in 1.18. CFAERBER/Unicode-Stringprep-1.104.tar.gz - fixed in 1.105 TEAM/EntityModel-Log-0.005.tar.gz - fixed in 0.006 SKINGTON/warnings-everywhere-0.007.tar.gz - fixed in 0.006 Again, tracking this at https://docs.google.com/spreadsheets/d/1aBWdK3Y-dDM5rxg70P0af8FfwmdEubTUtPV0li5eb3M/edit?usp=sharing Tony |
From @jkeenanOn Wed Apr 01 21:13:20 2015, tonyc wrote:
And HKOBA has responded with gratitude: https://rt.cpan.org/Ticket/Display.html?id=95311#txn-1480881 -- |
From @iabynOn Wed, Mar 25, 2015 at 11:51:15PM +0100, Andreas Koenig wrote:
I've applied this as 3198fda. Other than that, I don't think this ticket needs to be a blocker for 5.22. -- |
From @rjbsThis ticket is no longer a blocker, and I am closing it. -- |
@rjbs - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#122159 (status was 'resolved')
Searchable as RT122159$
The text was updated successfully, but these errors were encountered: