From @andk

git bisect

commit b321173
Author​: Karl Williamson <khw@​cpan.org>
Date​: Tue Jun 17 09​:39​:51 2014 -0600

  PATCH​: [perl #121816] Add warning for repetition x < 0
 
  I consider this experimental, so that if code breaks as a result, we
  will remove it.

perl -V

Summary of my perl5 (revision 5 version 21 subversion 1) configuration​:
  Commit id​: b321173
  Platform​:
  osname=linux, osvers=3.14-1-amd64, archname=x86_64-linux-thread-multi
  uname='linux k83 3.14-1-amd64 #1 smp debian 3.14.5-1 (2014-06-05) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.21.0-434-gb321173/9980 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2 -g',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.8.3', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_ITHREADS USE_LARGE_FILES USE_LOCALE
  USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_PERLIO USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Jun 22 2014 08​:36​:19
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.0-434-gb321173/9980/lib/site_perl/5.21.1/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.0-434-gb321173/9980/lib/site_perl/5.21.1
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.0-434-gb321173/9980/lib/5.21.1/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.21.0-434-gb321173/9980/lib/5.21.1
  .

footnote

This is a recording. Commits like this should not be allowed in the
trunk. If you want to play minefieldsweeper, you know where to find it.
--
andreas

From @rjbs

* "Andreas J. Koenig via RT" <perlbug-followup@​perl.org> [2014-06-22T03​:05​:28]

PATCH&#8203;: \[perl \#121816\] Add warning for repetition x \< 0

I consider this experimental\, so that if code breaks as a result\, we
will remove it\.

http​://www.cpantesters.org/cpan/report/3f1d2a9c-f967-11e3-8474-4f640a370852

This is (unsurprisingly) an "ensure no warnings issued" test.

The triggering code is hard to judge. It's more or less doing a table of
contents thing like​:

  foo ........ bar

where we make the middle bit with​:

  '.' x ($max - len $str)

So, is it doing the right or wrong thing by using -n as zero and letting things
overflow. Up to the author to decide.

--
rjbs

The RT System itself - Status changed from 'new' to 'open'

From david@justatheory.com

On Jun 22, 2014, at 4​:36 AM, Ricardo Signes <perl.p5p@​rjbs.manxome.org> wrote​:

http​://www.cpantesters.org/cpan/report/3f1d2a9c-f967-11e3-8474-4f640a370852

<snip/?

So, is it doing the right or wrong thing by using -n as zero and letting things
overflow. Up to the author to decide.

Not the wrong thing, exactly, since the code that decides the operands in the subtraction is determined elsewhere. It just isn’t set off before the method is called in the test. So I'm adding a call to it in the test.

In general I’m in favor of changes like this, as they do alert me to weaknesses in my code, even stuff like this that is mostly wrong as a side-effect of how the tests are written.

Best,

David

From @jkeenan

On Mon Jun 23 10​:34​:53 2014, david@​justatheory.com wrote​:

On Jun 22, 2014, at 4​:36 AM, Ricardo Signes
<perl.p5p@​rjbs.manxome.org> wrote​:

http​://www.cpantesters.org/cpan/report/3f1d2a9c-f967-11e3-8474-
4f640a370852

<snip/?

So, is it doing the right or wrong thing by using -n as zero and
letting things
overflow. Up to the author to decide.

Not the wrong thing, exactly, since the code that decides the operands
in the subtraction is determined elsewhere. It just isn’t set off
before the method is called in the test. So I'm adding a call to it in
the test.

In general I’m in favor of changes like this, as they do alert me to
weaknesses in my code, even stuff like this that is mostly wrong as a
side-effect of how the tests are written.

Best,

David

David,

Looking at http​://cpantesters.org/distro/A/App-Sqitch.html, it appears that a version of App-Sqitch more recent than the one which was the subject of this ticket is passing on Perl 5.21.4.

Can we close this ticket?

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

From @tonycoz

On Thu Oct 16 18​:11​:44 2014, jkeenan wrote​:

Looking at http​://cpantesters.org/distro/A/App-Sqitch.html, it appears
that a version of App-Sqitch more recent than the one which was the
subject of this ticket is passing on Perl 5.21.4.

Can we close this ticket?

From Changes​:

0.996 2014-09-05T21​:11​:00Z
  - Fixed one more test failure due to the introduction of "Negative repeat
  count does nothing" warning in Perl 5.21.1.

Closing.

Tony

@tonycoz - Status changed from 'open' to 'resolved'