New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SvTRUE changed behavior in 5.18 #12990
Comments
From @wumpusCreated by @wumpusIn upgrading the blekko search engine backend to Perl 5.18.0, one of $ perl -MScalar::Util=dualvar -le 'print $]; $a = dualvar 1, ""; print $a ? "true" : "false";' $ perl -MScalar::Util=dualvar -le 'print $]; $a = dualvar 1, ""; print $a ? "true" : "false";' $ perl -MScalar::Util=dualvar -le 'print $]; $a = dualvar 1, ""; print $a ? "true" : "false";' Is this intended? We were surprised. It became visible to us because some Graphics Magik functions return Graphics Magick doesn't document this return value and does not test it. We don't have an opinion about what behavior is correct here, but it Thanks! Perl Info
|
From @tonycozOn Fri, May 24, 2013 at 01:42:52PM -0700, Greg Lindahl wrote:
This appears to have changed in 4bac9ae. Previously SvTRUE was: # define SvTRUE(sv) ( \ which checks *only* the PV part of the scalar if the scalar is flagged The new version, largely in SvTRUE_common(): #define SvTRUE_common(sv,fallback) ( \ checks each part of the SV until it finds a true part (if any). Tony |
The RT System itself - Status changed from 'new' to 'open' |
From @cpansproutOn Fri May 24 21:06:07 2013, tonyc wrote:
I can’t believe I missed that when reviewing the patch in question. So this seems like a bug to me. Should we change it back? -- Father Chrysostomos |
From @rjbs* Father Chrysostomos via RT <perlbug-followup@perl.org> [2013-05-25T14:20:32]
I think we should. -- |
From @cpansproutOn Sat May 25 18:26:31 2013, perl.p5p@rjbs.manxome.org wrote:
I have just done so in commit 762dbf2. -- Father Chrysostomos |
@cpansprout - Status changed from 'open' to 'resolved' |
From @chipdudeOn 5/26/2013 12:20 AM, Father Chrysostomos via RT wrote:
Yup, it was inadvertent. "I'm the author of the bug, and I approve this |
From @iabynOn Sun, May 26, 2013 at 07:06:40PM -0700, Reverend Chip wrote:
Now cherry-picked into maint-5.18 as -- |
Migrated from rt.perl.org#118159 (status was 'resolved')
Searchable as RT118159$
The text was updated successfully, but these errors were encountered: