old hash behaviour test fails, op/each.t ../ext/Devel-Peek/t/Peek.t #12959
Comments
From @bulk88Created by @bulk88Turning on pre 5.18 has behaviour with a modified hv_func.h as such #ifndef PERL_SEEN_HV_FUNC_H /* compile once */ #define PERL_HASH_FUNC_ONE_AT_A_TIME_OLD is causing the following unusual test failures on my machine. 32 bit ______________________________________________________________ Test Summary Report C:\p518src\perl-05f5908\t>..\perl.exe -I..\lib harness # Failed test 'ENAMEs on a stash' Test Summary Report C:\p518src\perl-05f5908\t> Perl Info |
From @demerphqOn 11 May 2013 21:23, bulk88 <perlbug-followup@perl.org> wrote:
This is non-standard build mode, so some test failures are expected,
Given the build options you provided I don't expect this to fail, but
Again, im not sure why your build options lead to this output (have I will do my best to look into this, but as it is an experimental Yves -- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @TuxOn Sun, 12 May 2013 11:31:29 +0200, demerphq <demerphq@gmail.com> wrote:
And I/we need to tell Config::Perl::V
-- |
From @bulk88On Sun May 12 02:32:08 2013, demerphq wrote:
I am attaching a diff from 05f5908 to -- |
From @bulk880001-getting-old-has-behaviour.patchFrom 65e73ddf707f386b52a7a439a780042216726f27 Mon Sep 17 00:00:00 2001
From: bulk88 <bulk88@hotmail.com>
Date: Sun, 12 May 2013 22:27:14 -0400
Subject: [PATCH] getting old has behaviour
---
hv.h | 2 ++
hv_func.h | 4 ++++
perl.c | 10 +++++-----
perl.h | 9 ++++-----
win32/Makefile | 16 ++++++++--------
win32/win32.c | 2 +-
6 files changed, 24 insertions(+), 19 deletions(-)
diff --git a/hv.h b/hv.h
index 2eea477..da22a0c 100644
--- a/hv.h
+++ b/hv.h
@@ -12,6 +12,8 @@
* Currently disabling this functionality will break a few tests, but should otherwise work fine.
* See perlrun for more details. */
+#define PERL_PERTURB_KEYS_DISABLED 1
+
#if defined(PERL_PERTURB_KEYS_DISABLED)
# define PL_HASH_RAND_BITS_ENABLED 0
# define PERL_HASH_ITER_BUCKET(iter) ((iter)->xhv_riter)
diff --git a/hv_func.h b/hv_func.h
index 7678807..a40386d 100644
--- a/hv_func.h
+++ b/hv_func.h
@@ -12,6 +12,10 @@
#ifndef PERL_SEEN_HV_FUNC_H /* compile once */
#define PERL_SEEN_HV_FUNC_H
+#define PERL_HASH_FUNC_ONE_AT_A_TIME_OLD
+#undef USE_HASH_SEED
+#undef USE_HASH_SEED_EXPLICIT
+
#if !( 0 \
|| defined(PERL_HASH_FUNC_SIPHASH) \
|| defined(PERL_HASH_FUNC_SDBM) \
diff --git a/perl.c b/perl.c
index 80b3bdd..0f8d4f7 100644
--- a/perl.c
+++ b/perl.c
@@ -1883,7 +1883,7 @@ S_parse_body(pTHX_ char **env, XSINIT_t xsinit)
#if SILENT_NO_TAINT_SUPPORT
/* silently ignore */
#elif NO_TAINT_SUPPORT
- Perl_croak("This perl was compiled without taint support. "
+ Perl_croak_nocontext("This perl was compiled without taint support. "
"Cowardly refusing to run with -t or -T flags");
#else
CHECK_MALLOC_TOO_LATE_FOR('t');
@@ -1898,7 +1898,7 @@ S_parse_body(pTHX_ char **env, XSINIT_t xsinit)
#if SILENT_NO_TAINT_SUPPORT
/* silently ignore */
#elif NO_TAINT_SUPPORT
- Perl_croak("This perl was compiled without taint support. "
+ Perl_croak_nocontext("This perl was compiled without taint support. "
"Cowardly refusing to run with -t or -T flags");
#else
CHECK_MALLOC_TOO_LATE_FOR('T');
@@ -2015,7 +2015,7 @@ S_parse_body(pTHX_ char **env, XSINIT_t xsinit)
#if SILENT_NO_TAINT_SUPPORT
/* silently ignore */
#elif NO_TAINT_SUPPORT
- Perl_croak("This perl was compiled without taint support. "
+ Perl_croak_nocontext("This perl was compiled without taint support. "
"Cowardly refusing to run with -t or -T flags");
#else
CHECK_MALLOC_TOO_LATE_FOR('T');
@@ -2054,7 +2054,7 @@ S_parse_body(pTHX_ char **env, XSINIT_t xsinit)
#if SILENT_NO_TAINT_SUPPORT
/* silently ignore */
#elif NO_TAINT_SUPPORT
- Perl_croak("This perl was compiled without taint support. "
+ Perl_croak_nocontext("This perl was compiled without taint support. "
"Cowardly refusing to run with -t or -T flags");
#else
if( !TAINTING_get) {
@@ -3383,7 +3383,7 @@ Perl_moreswitches(pTHX_ const char *s)
#if SILENT_NO_TAINT_SUPPORT
/* silently ignore */
#elif NO_TAINT_SUPPORT
- Perl_croak("This perl was compiled without taint support. "
+ Perl_croak_nocontext("This perl was compiled without taint support. "
"Cowardly refusing to run with -t or -T flags");
#else
if (!TAINTING_get)
diff --git a/perl.h b/perl.h
index 89f4c98..54b51c7 100644
--- a/perl.h
+++ b/perl.h
@@ -2494,11 +2494,10 @@ typedef AV PAD;
typedef AV PADNAMELIST;
typedef SV PADNAME;
-/* XXX for 5.18, disable the COW by default
- * #if !defined(PERL_OLD_COPY_ON_WRITE) && !defined(PERL_NEW_COPY_ON_WRITE) && !defined(PERL_NO_COW)
- * # define PERL_NEW_COPY_ON_WRITE
- * #endif
- */
+#if !defined(PERL_OLD_COPY_ON_WRITE) && !defined(PERL_NEW_COPY_ON_WRITE) && !defined(PERL_NO_COW)
+# define PERL_NEW_COPY_ON_WRITE
+#endif
+
#if defined(PERL_OLD_COPY_ON_WRITE) || defined(PERL_NEW_COPY_ON_WRITE)
# if defined(PERL_OLD_COPY_ON_WRITE) && defined(PERL_NEW_COPY_ON_WRITE)
diff --git a/win32/Makefile b/win32/Makefile
index b8cb17f..7ad9d1f 100644
--- a/win32/Makefile
+++ b/win32/Makefile
@@ -21,7 +21,7 @@
# newly built perl.
#
INST_DRV = c:
-INST_TOP = $(INST_DRV)\perl
+INST_TOP = $(INST_DRV)\perl518
#
# Uncomment if you want to build a 32-bit Perl using a 32-bit compiler
@@ -102,9 +102,9 @@ USE_LARGE_FILES = define
# uncomment exactly one of the following
#
# Visual C++ 6.x (aka Visual C++ 98)
-CCTYPE = MSVC60
+#CCTYPE = MSVC60
# Visual C++ .NET 2002/2003 (aka Visual C++ 7.x) (full version)
-#CCTYPE = MSVC70
+CCTYPE = MSVC70
# Visual C++ Toolkit 2003 (aka Visual C++ 7.x) (free command-line tools)
#CCTYPE = MSVC70FREE
# Windows Server 2003 SP1 Platform SDK (April 2005)
@@ -191,7 +191,7 @@ CCLIBDIR = $(CCHOME)\lib
#
# Additional compiler flags can be specified here.
#
-BUILDOPT = $(BUILDOPTEXTRA)
+BUILDOPT = $(BUILDOPTEXTRA)
#
# This should normally be disabled. Enabling it will disable the File::Glob
@@ -429,7 +429,7 @@ OPTIMIZE = -Od -MD -Zi -DDEBUGGING
LINK_DBG = -debug
!ELSE
# -O1 yields smaller code, which turns out to be faster than -O2 on x86 and x64
-OPTIMIZE = -O1 -MD -Zi -DNDEBUG
+OPTIMIZE = -O1 -MD -Zi -DNDEBUG -G6
# we enable debug symbols in release builds also
LINK_DBG = -debug -opt:ref,icf
# you may want to enable this if you want COFF symbols in the executables
@@ -438,11 +438,11 @@ LINK_DBG = -debug -opt:ref,icf
# installed to get better stack traces from just the PDB symbols, so we
# avoid the bloat of COFF symbols by default.
#LINK_DBG = $(LINK_DBG) -debugtype:both
-! IF "$(WIN64)" == "define"
+#! IF "$(WIN64)" == "define"
# enable Whole Program Optimizations (WPO) and Link Time Code Generation (LTCG)
OPTIMIZE = $(OPTIMIZE) -GL
LINK_DBG = $(LINK_DBG) -ltcg
-! ENDIF
+#! ENDIF
!ENDIF
!IF "$(WIN64)" == "define"
@@ -500,7 +500,7 @@ EXEOUT_FLAG = -Fe
CFLAGS_O = $(CFLAGS) $(BUILDOPT)
!IF "$(PREMSVC80)" == "undef"
-LINK_FLAGS = $(LINK_FLAGS) "/manifestdependency:type='Win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' processorArchitecture='*' publicKeyToken='6595b64144ccf1df' language='*'"
+#LINK_FLAGS = $(LINK_FLAGS) "/manifestdependency:type='Win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' processorArchitecture='*' publicKeyToken='6595b64144ccf1df' language='*'"
!ELSE
RSC_FLAGS = -DINCLUDE_MANIFEST
!ENDIF
diff --git a/win32/win32.c b/win32/win32.c
index bda5356..3dd4e82 100644
--- a/win32/win32.c
+++ b/win32/win32.c
@@ -4362,7 +4362,7 @@ Perl_win32_init(int *argcp, char ***argvp)
* the standard control classes. Without this even normal Windows APIs
* like MessageBox() can fail under some versions of Windows XP.
*/
- InitCommonControls();
+ //InitCommonControls();
g_osver.dwOSVersionInfoSize = sizeof(g_osver);
GetVersionEx(&g_osver);
--
1.7.9.msysgit.0
|
From @jkeenanOn Sun May 12 19:35:13 2013, bulk88 wrote:
There has been no further discussion in this ticket in nearly two-and-a-half years. And when there was no discussion, there was little agreement on changes to be made. I recommend that this ticket be closed and am taking it for the purpose of closing it within 7 days unless there is a compelling reason not to do so. Thank you very much. -- |
From @jkeenanOn Mon Oct 05 19:09:12 2015, jkeenan wrote:
No one spoke up in favor of keeping this ticket open; closing. -- |
|
@jkeenan - Status changed from 'open' to 'rejected' |
Migrated from rt.perl.org#117963 (status was 'rejected')
Searchable as RT117963$
The text was updated successfully, but these errors were encountered: