Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-PP fails test when hash iterator randomization is enabled. (5.18 blocker) #12788

Closed
p5pRT opened this issue Feb 18, 2013 · 4 comments
Closed

Comments

@p5pRT
Copy link

p5pRT commented Feb 18, 2013

Migrated from rt.perl.org#116825 (status was 'resolved')

Searchable as RT116825$

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2013

From @demerphq

I have filed the following ticket against JSON-PP, and am filing this
ticket so it can be tracked as a 5.18 blocker.

perl -V output​:

$ ./perl -Ilib -V
Summary of my perl5 (revision 5 version 17 subversion 9) configuration​:
  Derived from​: d6998a16edfcd657911312b7a2b5ec7ca27cab42
  Ancestor​: f06d65f6bfe67affa8060b7efaecb108f57ceed8
  Platform​:
  osname=linux, osvers=3.0.0-12-generic, archname=x86_64-linux
  uname='linux yam 3.0.0-12-generic #20-ubuntu smp fri oct 7
14​:56​:25 utc 2011 x86_64 x86_64 x86_64 gnulinux '
  config_args='-Doptimize=-g -d -Dusedevel -Dcc=ccache gcc -Dld=gcc
-DDEBUGGING'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='ccache gcc', ccflags ='-DDEBUGGING -fno-strict-aliasing -pipe
-fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64',
  optimize='-g',
  cppflags='-DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector
-I/usr/local/include'
  ccversion='', gccversion='4.6.1', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='gcc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib
/usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib
  libs=-lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -g -L/usr/local/lib
-fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: DEBUGGING HAS_TIMES PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_PERLIO
  USE_PERL_ATOF
  Locally applied patches​:
  uncommitted-changes
  d6998a16edfcd657911312b7a2b5ec7ca27cab42
  Built under linux
  Compiled at Feb 17 2013 16​:44​:58
  @​INC​:
  lib
  /usr/local/lib/perl5/site_perl/5.17.9/x86_64-linux
  /usr/local/lib/perl5/site_perl/5.17.9
  /usr/local/lib/perl5/5.17.9/x86_64-linux
  /usr/local/lib/perl5/5.17.9
  .

---------- Forwarded message ----------
From​: Bugs in JSON-PP via RT <bug-JSON-PP@​rt.cpan.org>
Date​: 18 February 2013 07​:51
Subject​: [rt.cpan.org #83421] AutoReply​: JSON-PP fails test when hash
iterator randomization is enabled.
To​: demerphq@​gmail.com

Greetings,

This message has been automatically generated in response to the
creation of a trouble ticket regarding​:
  "JSON-PP fails test when hash iterator randomization is enabled.",
a summary of which appears below.

There is no need to reply to this message right now. Your ticket has been
assigned an ID of [rt.cpan.org #83421]. Your ticket is accessible
on the web at​:

  https://rt.cpan.org/Ticket/Display.html?id=83421

Please include the string​:

  [rt.cpan.org #83421]

in the subject line of all future correspondence about this issue. To do so,
you may reply to this message.

  Thank you,
  bug-JSON-PP@​rt.cpan.org


JSON-PP occasionally fails test when hash iterator randomization is
enabled.

The solution is to enabled canonical mode in the failing test.

We plan to enable this in 5.18.

The attached patch from my perl.git branch yves/hv_h_split fixes the bug,
and tweaks the eval logic to check the return code and die with an
appropriate message if the eval fails.

I have marked this patch as important as it is a blocker for 5.18
release.

--
perl -Mre=debug -e "/just|another|perl|hacker/"

@p5pRT
Copy link
Author

p5pRT commented Mar 13, 2013

From @rjbs

13​:31 * p5commits Chris 'Bingos' Williams pushed to blead
  (v5.17.9-159-g4aacaee)​: Chris 'BinGOs' Williams​: CPAN Module-CoreList
  be 2.84; http​://perl5.git.perl.org/perl.git/commit/4aacaee2 Chris
  'BinGOs' Williams​: Update JSON-PP to CPAN version 2.27202;
  http​://perl5.git.perl.org/perl.git/commit/16880a15

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Mar 13, 2013

From [Unknown Contact. See original ticket]

13​:31 * p5commits Chris 'Bingos' Williams pushed to blead
  (v5.17.9-159-g4aacaee)​: Chris 'BinGOs' Williams​: CPAN Module-CoreList
  be 2.84; http​://perl5.git.perl.org/perl.git/commit/4aacaee2 Chris
  'BinGOs' Williams​: Update JSON-PP to CPAN version 2.27202;
  http​://perl5.git.perl.org/perl.git/commit/16880a15

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Mar 13, 2013

@rjbs - Status changed from 'new' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant