Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.17.0-325-gbaed7fa breaks OPI/Linux-Smaps-0.09.tar.gz #12324

Closed
p5pRT opened this issue Aug 8, 2012 · 10 comments
Closed

Bleadperl v5.17.0-325-gbaed7fa breaks OPI/Linux-Smaps-0.09.tar.gz #12324

p5pRT opened this issue Aug 8, 2012 · 10 comments

Comments

@p5pRT
Copy link

p5pRT commented Aug 8, 2012

Migrated from rt.perl.org#114424 (status was 'resolved')

Searchable as RT114424$

@p5pRT
Copy link
Author

p5pRT commented Aug 8, 2012

From @andk

git bisect


commit baed7fa
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Fri Jun 8 12​:58​:42 2012 -0700

  Constant folding for x

diagnostics


http​://www.cpantesters.org/cpan/report/22421973

perl -V


Summary of my perl5 (revision 5 version 17 subversion 0) configuration​:
  Commit id​: baed7fa
  Platform​:
  osname=linux, osvers=3.2.0-3-amd64, archname=x86_64-linux
  uname='linux k83 3.2.0-3-amd64 #1 smp mon jul 23 02​:45​:17 utc 2012 x86_64 gnulinux '
  config_args='-Dprefix=/home/src/perl/repoperls/installed-perls/perl/v5.17.0-325-gbaed7fa/165a -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Uuseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2 -g',
  cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.7.1', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib
  libs=-lnsl -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES PERLIO_LAYERS PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP PERL_PRESERVE_IVUV PERL_USE_DEVEL
  USE_64_BIT_ALL USE_64_BIT_INT USE_LARGE_FILES
  USE_LOCALE USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_PERLIO USE_PERL_ATOF
  Built under linux
  Compiled at Aug 8 2012 06​:54​:26
  @​INC​:
  /home/src/perl/repoperls/installed-perls/perl/v5.17.0-325-gbaed7fa/165a/lib/site_perl/5.17.0/x86_64-linux
  /home/src/perl/repoperls/installed-perls/perl/v5.17.0-325-gbaed7fa/165a/lib/site_perl/5.17.0
  /home/src/perl/repoperls/installed-perls/perl/v5.17.0-325-gbaed7fa/165a/lib/5.17.0/x86_64-linux
  /home/src/perl/repoperls/installed-perls/perl/v5.17.0-325-gbaed7fa/165a/lib/5.17.0
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Aug 8, 2012

From @nwc10

On Tue, Aug 07, 2012 at 10​:10​:52PM -0700, Andreas J. Koenig via RT wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #114424]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=114424 >

git bisect
----------
commit baed7fa
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Fri Jun 8 12​:58​:42 2012 -0700

Constant folding for x

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/22421973

  my $dirty=$s->private_dirty;
  {
  no warnings qw{void};
  "a"x(1024*1024);
  }
  $s->update;
  print "# dirty grows from $dirty to ".$s->private_dirty."\n";
  ok $s->private_dirty>$dirty+1024, 'dirty has grown';

Looks to be using x to generate a megabyte of churn, and assuming that this
happens at runtime. So not really surprising that it now fails. :-)

Nicholas Clark

@p5pRT
Copy link
Author

p5pRT commented Aug 8, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 8, 2012

From @cpansprout

On Tue Aug 07 22​:10​:52 2012, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

git bisect
----------
commit baed7fa
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Fri Jun 8 12​:58​:42 2012 -0700

Constant folding for x

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/22421973

Does the attached patch fix it?

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Aug 8, 2012

From @cpansprout

Inline Patch
diff -rup Linux-Smaps-0.09-E687pl-orig/t/02.t Linux-Smaps-0.09-E687pl/t/02.t
--- Linux-Smaps-0.09-E687pl-orig/t/02.t	2011-04-01 06:36:43.000000000 -0700
+++ Linux-Smaps-0.09-E687pl/t/02.t	2012-08-07 23:28:53.000000000 -0700
@@ -36,7 +36,7 @@ ok @$newlist==0 && @$difflist==0 && @$ol
 my $dirty=$s->private_dirty;
 {
   no warnings qw{void};
-  "a"x(1024*1024);
+  eval '"a"x(1024*1024)';
 }
 $s->update;
 print "# dirty grows from $dirty to ".$s->private_dirty."\n";

@p5pRT
Copy link
Author

p5pRT commented Aug 9, 2012

From @andk

On Tue, 07 Aug 2012 23​:30​:15 -0700, "Father Chrysostomos via RT" <perlbug-followup@​perl.org> said​:

  > On Tue Aug 07 22​:10​:52 2012, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

git bisect
----------
commit baed7fa
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Fri Jun 8 12​:58​:42 2012 -0700

Constant folding for x

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/22421973

  > Does the attached patch fix it?

Unfortunately no, because the next test checks whether private_dirty()
has grown *enough*. Here is the output after the patch​:

1..10
ok 1 - constructor
ok 2 - perl found
ok 3 - no diff
# dirty grows from 3384 to 3704
not ok 4 - dirty has grown

# Failed test 'dirty has grown'
# at t/02.t line 43.
[...]

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Sep 19, 2012

From @cpansprout

On Wed Aug 08 22​:50​:35 2012, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

On Tue, 07 Aug 2012 23​:30​:15 -0700, "Father Chrysostomos via RT"
<perlbug-followup@​perl.org> said​:

On Tue Aug 07 22​:10​:52 2012,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

git bisect
----------
commit baed7fa
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Fri Jun 8 12​:58​:42 2012 -0700

Constant folding for x

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/22421973

Does the attached patch fix it?

Unfortunately no, because the next test checks whether private_dirty()
has grown *enough*. Here is the output after the patch​:

1..10
ok 1 - constructor
ok 2 - perl found
ok 3 - no diff
# dirty grows from 3384 to 3704
not ok 4 - dirty has grown

# Failed test 'dirty has grown'
# at t/02.t line 43.
[...]

Then how about this one?

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Sep 19, 2012

From @cpansprout

Inline Patch
diff -rup Linux-Smaps-0.09-eJpiev-orig/t/02.t Linux-Smaps-0.09-eJpiev/t/02.t
--- Linux-Smaps-0.09-eJpiev-orig/t/02.t	2011-04-01 06:36:43.000000000 -0700
+++ Linux-Smaps-0.09-eJpiev/t/02.t	2012-09-19 06:14:07.000000000 -0700
@@ -36,7 +36,8 @@ ok @$newlist==0 && @$difflist==0 && @$ol
 my $dirty=$s->private_dirty;
 {
   no warnings qw{void};
-  "a"x(1024*1024);
+  my $a = "a";
+  $a x(1024*1024);
 }
 $s->update;
 print "# dirty grows from $dirty to ".$s->private_dirty."\n";

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2012

From @cpansprout

On Wed Sep 19 06​:14​:52 2012, sprout wrote​:

On Wed Aug 08 22​:50​:35 2012, andreas.koenig.7os6VVqR@​franz.ak.mind.de
wrote​:

On Tue, 07 Aug 2012 23​:30​:15 -0700, "Father Chrysostomos via RT"
<perlbug-followup@​perl.org> said​:

On Tue Aug 07 22​:10​:52 2012,
andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

git bisect
----------
commit baed7fa
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Fri Jun 8 12​:58​:42 2012 -0700

Constant folding for x

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/22421973

Does the attached patch fix it?

Unfortunately no, because the next test checks whether private_dirty()
has grown *enough*. Here is the output after the patch​:

1..10
ok 1 - constructor
ok 2 - perl found
ok 3 - no diff
# dirty grows from 3384 to 3704
not ok 4 - dirty has grown

# Failed test 'dirty has grown'
# at t/02.t line 43.
[...]

Then how about this one?

I have submitted this upstream, so I am marking this as resolved.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Oct 13, 2012

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant