New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] 2d8d7b1 replace B::COP::stashflags by B::COP::stashlen #12125
Comments
From @rurbanThis is a bug report for perl from rurban@cpanel.net, From 2d8d7b1c730932ee5a45c88f1ec23e5fbedd9b81 Mon Sep 17 00:00:00 2001 This is a multi-part message in MIME format. 6379d4a (between 5.15.9 and 5.16.0) broke B::COP::stashflags which was added ext/B/B.pm | 4 ++-- --------------1.7.10 Inline Patchdiff --git a/ext/B/B.pm b/ext/B/B.pm
index b19693c..75ead53 100644
--- a/ext/B/B.pm
+++ b/ext/B/B.pm
@@ -15,7 +15,7 @@ require Exporter;
# walkoptree comes from B.xs
BEGIN {
- $B::VERSION = '1.34';
+ $B::VERSION = '1.35';
@B::EXPORT_OK = ();
# Our BOOT code needs $VERSION set, and will append to @EXPORT_OK.
@@ -1211,7 +1211,7 @@ Only when perl was compiled with ithreads.
=item stashpv
-=item stashflags
+=item stashlen
=item file
diff --git a/ext/B/B.xs b/ext/B/B.xs
index 4a5ab44..632c874 100644
--- a/ext/B/B.xs
+++ b/ext/B/B.xs
@@ -1227,8 +1227,8 @@ pv(o)
ST(0) = newSVpvn_flags(o->op_pv, strlen(o->op_pv), SVs_TEMP);
#define COP_label(o) CopLABEL(o)
-#ifdef CopSTASH_flags
-#define COP_stashflags(o) CopSTASH_flags(o)
+#ifdef CopSTASH_len
+#define COP_stashlen(o) CopSTASH_len(o)
#endif
MODULE = B PACKAGE = B::COP PREFIX = COP_
@@ -1253,10 +1253,10 @@ COP_stash(o)
PUSHs(make_sv_object(aTHX_
ix ? (SV *)CopFILEGV(o) : (SV *)CopSTASH(o)));
-#ifdef CopSTASH_flags
+#ifdef CopSTASH_len
U32
-COP_stashflags(o)
+COP_stashlen(o)
B::COP o
#endif
--------------1.7.10--
---
Site configuration information for perl 5.15.7: Configured by rurban at Sun Jan 22 12:13:34 CST 2012. Summary of my perl5 (revision 5 version 15 subversion 7) configuration: Locally applied patches: @INC for perl 5.15.7: Environment for perl 5.15.7: |
From @rurbanThis needs to go into 5.16.1 and 5.17. |
From [Unknown Contact. See original ticket]This needs to go into 5.16.1 and 5.17. |
From @cpansproutOn Tue May 22 09:37:53 2012, rurban@cpanel.net wrote:
Thank you. Applied as 667d593. -- Father Chrysostomos |
The RT System itself - Status changed from 'new' to 'open' |
@cpansprout - Status changed from 'open' to 'resolved' |
From @rurbanOn Tue, May 22, 2012 at 2:56 PM, Father Chrysostomos via RT
In a subsequent commit This is not quite exactly right. |
From @cpansproutOn Wed Jun 06 13:42:21 2012, rurban wrote:
http://perl5.git.perl.org/perl.git/commit/a60c099b83a336be6df44b89eb468b0cdfe351ca
But I thought you said you didn’t need it, because ->stash->NAME is
Not quite renamed. It works differently now. -- Father Chrysostomos |
From @rurbanOn 06/06/2012 04:00 PM, Father Chrysostomos via RT wrote:
If the NAME method returns a PV with the right length, why not. But for 5.17 For consistency with 5.16 I need B::COP::stashlen.
I know :) |
From @rurbanSigh, Sending again, the third time now. ---------- Forwarded message ---------- This needs to go into 5.16.1 and 5.17. |
Migrated from rt.perl.org#113034 (status was 'resolved')
Searchable as RT113034$
The text was updated successfully, but these errors were encountered: