Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code broken by latest build #6518

Open
p6rt opened this issue Sep 14, 2017 · 5 comments
Open

code broken by latest build #6518

p6rt opened this issue Sep 14, 2017 · 5 comments
Labels
NativeCall regression Issue did not exist previously

Comments

@p6rt
Copy link

p6rt commented Sep 14, 2017

Migrated from rt.perl.org#132088 (status was 'open')

Searchable as RT132088$

@p6rt
Copy link
Author

p6rt commented Sep 14, 2017

From ash.gabriel@gmail.com

Hello,

I've written a module with release 2017-07.

source here​: https://github.com/gabrielash/perl6-zmq

It fails travis ci test with 'latest' release, but passes with '2017-07'.

This is the error

./t/11.t ..... Too few positionals passed; expected 5 arguments but got 3

in method send at
/home/travis/build/gabrielash/perl6-zmq/lib/Net/ZMQ/Message.pm
(Net​::ZMQ​::Message) line 244

in block <unit> at ./t/11.t line 55

I am not sure what is wrong and whether it is a bug or my mistake.

I tried to isolate the problem with the following test, but that test,
in isolation, does work on the latest build.

So there is something in the module interacting badly with this
nativecall, but only on the latest release.

class zmq_msg_t is repr('CStruct') {
  has int64 $._;
  has int64 $._1;
  has int64 $._2;
  has int64 $._3;
  has int64 $._4;
  has int64 $._5;
  has int64 $._6;
  has int64 $._7;
}

sub zmq_msg_init_data(zmq_msg_t
  ,Pointer
  ,size_t
  ,Pointer = nativecast( Pointer, 0)
  ,Pointer = nativecast( Pointer, 0)
  ) is native('zmq', v5)
  returns int32 is export { * }

my buf8 $b .= new(0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0);
my Pointer $p = nativecast(Pointer, $b);
my zmq_msg_t $m .= new ;

lives-ok {zmq_msg_init_data($m, $p , 10 )}, "native call ok ";

Hoping you can help.

Gabriel Ash

@p6rt
Copy link
Author

p6rt commented Sep 15, 2017

From @AlexDaniel

Bisected to rakudo/rakudo@cd7dc4c

Committable output https://gist.github.com/Whateverable/ee36fb271f2700f1684e1290a966e709

On 2017-09-14 08​:16​:43, ash.gabriel@​gmail.com wrote​:

Hello,

I've written a module with release 2017-07.

source here​: https://github.com/gabrielash/perl6-zmq

It fails travis ci test with 'latest' release, but passes with '2017-07'.

This is the error

./t/11.t ..... Too few positionals passed; expected 5 arguments but got 3

in method send at
/home/travis/build/gabrielash/perl6-zmq/lib/Net/ZMQ/Message.pm
(Net​::ZMQ​::Message) line 244

in block <unit> at ./t/11.t line 55

I am not sure what is wrong and whether it is a bug or my mistake.

I tried to isolate the problem with the following test, but that test,
in isolation, does work on the latest build.

So there is something in the module interacting badly with this
nativecall, but only on the latest release.

class zmq_msg_t is repr('CStruct') {
has int64 $._;
has int64 $._1;
has int64 $._2;
has int64 $._3;
has int64 $._4;
has int64 $._5;
has int64 $._6;
has int64 $._7;
}

sub zmq_msg_init_data(zmq_msg_t
,Pointer
,size_t
,Pointer = nativecast( Pointer, 0)
,Pointer = nativecast( Pointer, 0)
) is native('zmq', v5)
returns int32 is export { * }

my buf8 $b .= new(0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0);
my Pointer $p = nativecast(Pointer, $b);
my zmq_msg_t $m .= new ;

lives-ok {zmq_msg_init_data($m, $p , 10 )}, "native call ok ";

Hoping you can help.

Gabriel Ash

@p6rt
Copy link
Author

p6rt commented Sep 15, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Sep 15, 2017

From @timo

I just committed a hotfix so the upcoming release can go through.
Hopefully it can be replaced with a proper implementation of optional
parameters for the nativecall compiler soon.

rakudo/rakudo@1818de9

@p6rt
Copy link
Author

p6rt commented Sep 16, 2017

From ash.gabriel@gmail.com

Thank you!!

On 9/15/2017 2​:03 PM, Timo Paulssen via RT wrote​:

I just committed a hotfix so the upcoming release can go through.
Hopefully it can be replaced with a proper implementation of optional
parameters for the nativecall compiler soon.

rakudo/rakudo@1818de9

@p6rt p6rt added NativeCall regression Issue did not exist previously labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NativeCall regression Issue did not exist previously
Projects
None yet
Development

No branches or pull requests

1 participant