Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplier.done is only handled by first tap #6124

Closed
p6rt opened this issue Mar 4, 2017 · 5 comments
Closed

Supplier.done is only handled by first tap #6124

p6rt opened this issue Mar 4, 2017 · 5 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Mar 4, 2017

Migrated from rt.perl.org#130919 (status was 'resolved')

Searchable as RT130919$

@p6rt
Copy link
Author

p6rt commented Mar 4, 2017

From @briandfoy

The .done method of a Supplier should call all the done handlers in
all the taps that have one. I don't think that's happening in 2017.01.

It looks like only the first .tap gets to the done message​:

  my $supplier = Supplier.new;
  my $supply = $supplier.Supply;

  $supply.tap(
  done => { put "1. Done" },
  );
  $supply.tap(
  done => { put "2. Done" },
  );

  $supplier.done; # output only first

I get just the first handler​:

  1. Done

And, if the first .tap does not have a done handler, I get no
output​:

  my $supplier = Supplier.new;
  my $supply = $supplier.Supply;

  $supply.tap(
  );
  $supply.tap(
  done => { put "2. Done" },
  );

  $supplier.done; # no output

@p6rt
Copy link
Author

p6rt commented Jul 13, 2017

From @ugexe

Resolved in​: rakudo/rakudo@32b72cd

Tests​: Raku/roast@927b026

@p6rt
Copy link
Author

p6rt commented Jul 13, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jul 13, 2017

From @dogbert17

On Thu, 13 Jul 2017 10​:54​:27 -0700, ugexe@​cpan.org wrote​:

Resolved in​: rakudo/rakudo@32b72cd

Tests​: Raku/roast@927b026

Closing issue. ugexe++

@p6rt
Copy link
Author

p6rt commented Jul 13, 2017

@dogbert17 - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Jul 13, 2017
@p6rt p6rt added the conc label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant