Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests in S32-hash/adverbs.t and S32-array/adverbts.t: Ordering of elements of @!unexpected in X::Adverb #4761

Closed
p6rt opened this issue Nov 18, 2015 · 6 comments
Labels
JVM Related to Rakudo-JVM

Comments

@p6rt
Copy link

p6rt commented Nov 18, 2015

Migrated from rt.perl.org#126671 (status was 'resolved')

Searchable as RT126671$

@p6rt
Copy link
Author

p6rt commented Nov 18, 2015

From @usev6

On rakudo.jvm there are failing tests in S32-hash/adverbs.t because the returned elements of @​!unexpected in X​::Adverb are not ordered as expected.

The following evaluation shows the difference between rakudo.moar and rakudo.jvm​: ["zip", "zop"] vs. ["zop", "zip"]

$ perl6-m -e 'my %h; { say %h{}​:kv​:p​:zip​:zop; CATCH { default { say $_.perl } } }'
X​::Adverb.new(what => "slice", source => "\%h", unexpected => ["zip", "zop"], nogo => ["kv", "p"])

$ perl6-j -e 'my %h; { say %h{}​:kv​:p​:zip​:zop; CATCH { default { say $_.perl } } }'
X​::Adverb.new(what => "slice", source => "\%h", unexpected => ["zop", "zip"], nogo => ["kv", "p"])

I'm going to fudge the tests for the moment, but this looks like a low hanging fruit to fix.

@p6rt
Copy link
Author

p6rt commented Nov 18, 2015

From @usev6

The same thing happens in S32-array/adverbs.t.

1 similar comment
@p6rt
Copy link
Author

p6rt commented Nov 18, 2015

From @usev6

The same thing happens in S32-array/adverbs.t.

@p6rt
Copy link
Author

p6rt commented Nov 28, 2015

From @usev6

I changed the tests to not expect a specific order with commit​: Raku/roast@f1df147714

I'm closing this ticket as 'resolved'.

1 similar comment
@p6rt
Copy link
Author

p6rt commented Nov 28, 2015

From @usev6

I changed the tests to not expect a specific order with commit​: Raku/roast@f1df147714

I'm closing this ticket as 'resolved'.

@p6rt p6rt closed this as completed Nov 28, 2015
@p6rt
Copy link
Author

p6rt commented Nov 28, 2015

@usev6 - Status changed from 'new' to 'resolved'

@p6rt p6rt added the JVM Related to Rakudo-JVM label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JVM Related to Rakudo-JVM
Projects
None yet
Development

No branches or pull requests

1 participant