Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Than Ugly error message: "take without gather" #4300

Closed
p6rt opened this issue Jun 5, 2015 · 6 comments
Closed

More Than Ugly error message: "take without gather" #4300

p6rt opened this issue Jun 5, 2015 · 6 comments

Comments

@p6rt
Copy link

p6rt commented Jun 5, 2015

Migrated from rt.perl.org#125339 (status was 'resolved')

Searchable as RT125339$

@p6rt
Copy link
Author

p6rt commented Jun 5, 2015

From @AlexDaniel

Code​:
take 1;

Result​:
take without gather

Yes, that's it – "take without gather". No line number, no nothing.

@p6rt
Copy link
Author

p6rt commented Jun 18, 2015

From @hoelzro

On 2015-06-05 15​:10​:36, alex.jakimenko@​gmail.com wrote​:

Code​:
take 1;

Result​:
take without gather

Yes, that's it – "take without gather". No line number, no nothing.

This looks fixed to me, as of 3b5c4a8f.

@p6rt
Copy link
Author

p6rt commented Jun 18, 2015

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jun 18, 2015

From @hoelzro

On 2015-06-18 09​:24​:11, rob@​hoelz.ro wrote​:

On 2015-06-05 15​:10​:36, alex.jakimenko@​gmail.com wrote​:

Code​:
take 1;

Result​:
take without gather

Yes, that's it – "take without gather". No line number, no nothing.

This looks fixed to me, as of 3b5c4a8f.

My mistake; I did a 'take;' rather than 'take 1;'

@p6rt
Copy link
Author

p6rt commented Jun 19, 2015

From @jnthn

On Fri Jun 05 15​:10​:36 2015, alex.jakimenko@​gmail.com wrote​:

Code​:
take 1;

Result​:
take without gather

Yes, that's it – "take without gather". No line number, no nothing.

The exception got thrown after unwinding the call stack looking for the "take" handler, meaning we ended up with an empty stack trace. Now we steal the backtrace of the original control exception, which is far more useful.

Test added in S04-exception-handlers/control.t.

@p6rt p6rt closed this as completed Jun 19, 2015
@p6rt
Copy link
Author

p6rt commented Jun 19, 2015

@jnthn - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant