Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let .make pass on its parameter without containerizing it #4274

Closed
p6rt opened this issue May 28, 2015 · 5 comments
Closed

Let .make pass on its parameter without containerizing it #4274

p6rt opened this issue May 28, 2015 · 5 comments
Labels

Comments

@p6rt
Copy link

p6rt commented May 28, 2015

Migrated from rt.perl.org#125269 (status was 'resolved')

Searchable as RT125269$

@p6rt
Copy link
Author

p6rt commented May 28, 2015

From @smls

...thus making it consistent with the make *subroutine*.

( See http://irclog.perlgeek.de/perl6/2015-05-28#i_10669973 )

@p6rt
Copy link
Author

p6rt commented May 28, 2015

From @smls

0001-Make-sure-that-.make-never-forces-itemization.patch
From a63b2c5a0febd4ed64edf2b56e51d19a8b1ce26d Mon Sep 17 00:00:00 2001
From: smls <smls75@gmail.com>
Date: Thu, 28 May 2015 20:22:45 +0200
Subject: [PATCH] Make sure that .make never forces itemization

(see http://irclog.perlgeek.de/perl6/2015-05-28#i_10669973 )
---
 src/core/Match.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/Match.pm b/src/core/Match.pm
index d21a907..f827c52 100644
--- a/src/core/Match.pm
+++ b/src/core/Match.pm
@@ -82,7 +82,7 @@ my class Match is Capture is Cool {
     }
 
     method make(Match:D: Mu \made) {
-        $!made = made;
+        $!made := made;
         nqp::bindattr(
             nqp::decont(self.CURSOR),
             Cursor,
-- 
2.4.1

@p6rt
Copy link
Author

p6rt commented May 28, 2015

From @lizmat

Fixed with 0a0051c6979d21bfdc2e

On 28 May 2015, at 20​:28, Sam S. (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Sam S.
# Please include the string​: [perl #​125269]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=125269 >

...thus making it consistent with the make *subroutine*.

( See http://irclog.perlgeek.de/perl6/2015-05-28#i_10669973 )
<0001-Make-sure-that-.make-never-forces-itemization.patch>

@p6rt
Copy link
Author

p6rt commented May 28, 2015

The RT System itself - Status changed from 'new' to 'open'

@p6rt p6rt closed this as completed May 29, 2015
@p6rt
Copy link
Author

p6rt commented May 29, 2015

@smls - Status changed from 'open' to 'resolved'

@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant