Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi sub with where clause + temp crashing on MoarVM #3659

Closed
p6rt opened this issue Jan 27, 2015 · 10 comments
Closed

multi sub with where clause + temp crashing on MoarVM #3659

p6rt opened this issue Jan 27, 2015 · 10 comments

Comments

@p6rt
Copy link

p6rt commented Jan 27, 2015

Migrated from rt.perl.org#123686 (status was 'resolved')

Searchable as RT123686$

@p6rt
Copy link
Author

p6rt commented Jan 27, 2015

From @dwarring

Consider​:

  my $x;
  multi sub foo($n where True) { temp $x; }
  foo($_) for 1 ... 1000; # crashing here on MoarVM
  say 'ok';

This runs to completion on JVM and Parrot, but crashes on MoarVM 2015.01-30-gd671638. Typically at around 100 iterations.

[Golfed from flapping CSS​::Writer tests]

@p6rt
Copy link
Author

p6rt commented Jan 28, 2015

From @dwarring

A test case has been added to integration/weird-errors.t

Fudged for rakudo.moar
On Tue Jan 27 12​:03​:24 2015, david.warring wrote​:

Consider​:

my $x;
multi sub foo($n where True) { temp $x; }
foo($_) for 1 ... 1000; # crashing here on MoarVM
say 'ok';

This runs to completion on JVM and Parrot, but crashes on MoarVM
2015.01-30-gd671638. Typically at around 100 iterations.

[Golfed from flapping CSS​::Writer tests]

@p6rt
Copy link
Author

p6rt commented Feb 1, 2015

From @usev6

The test passes now and was unfudged with commit Raku/roast@4954d43df4

I'm closing this ticket now. (whoever fixed this)++

1 similar comment
@p6rt
Copy link
Author

p6rt commented Feb 1, 2015

From @usev6

The test passes now and was unfudged with commit Raku/roast@4954d43df4

I'm closing this ticket now. (whoever fixed this)++

@p6rt
Copy link
Author

p6rt commented Feb 1, 2015

@usev6 - Status changed from 'new' to 'resolved'

@p6rt
Copy link
Author

p6rt commented Feb 15, 2015

From @dwarring

On Sun Feb 01 12​:21​:33 2015, bartolin@​gmx.de wrote​:

The test passes now and was unfudged with commit
Raku/roast@4954d43df4

I'm closing this ticket now. (whoever fixed this)++

This bug seems to be back :-| e.g.
https://github.com/coke/perl6-roast-data/blob/f327f9a3387549f96d160b2e23993be2518c4d51/log/rakudo.moar-jit_summary.out#L3147

Reverted Raku/roast@4954d43df4 to refudge.

I might try bisecting when I get a chance, to see when this was reintroduced.

@p6rt
Copy link
Author

p6rt commented Feb 15, 2015

@dwarring - Status changed from 'resolved' to 'open'

@p6rt
Copy link
Author

p6rt commented Apr 16, 2015

From @lizmat

On 01 Feb 2015, at 21​:21, Christian Bartolomaeus via RT <bugs-comment@​bugs6.perl.org> wrote​:

The test passes now and was unfudged with commit Raku/roast@4954d43df4

I'm closing this ticket now. (whoever fixed this)++

Seems #​124318 is related to this.

Liz

@p6rt
Copy link
Author

p6rt commented Jun 10, 2015

From @jnthn

On Thu Apr 16 13​:19​:13 2015, elizabeth wrote​:

On 01 Feb 2015, at 21​:21, Christian Bartolomaeus via RT <bugs-
comment@​bugs6.perl.org> wrote​:

The test passes now and was unfudged with commit
Raku/roast@4954d43df4

I'm closing this ticket now. (whoever fixed this)++

Seems #​124318 is related to this.

It was, though the dynamic optimizer was not involved, as #​124318 suggested; it just rearranged memory such that we saw it further. It was a bug involving reading bogus memory, so could easily have appeared to go away, then come back. Now it should be fixed for good. Test re-enabled.

@p6rt p6rt closed this as completed Jun 10, 2015
@p6rt
Copy link
Author

p6rt commented Jun 10, 2015

@jnthn - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant