New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.13.8-98-g4155e4f breaks TSCH/Gtk2-1.222.tar.gz #11059
Comments
From @andkrelated tickets: http://rt.perl.org/rt3/Ticket/Display.html?id=81662 (Tk) git log: commit 4155e4f [perl #36347] Object destruction incomplete do_clean_objs only looks for objects referenced by RVs, so blessed This commit adds a new visit() call to sv_clean_objs, which curses example fail report: http://www.cpantesters.org/cpan/report/10395903 perl -V: Summary of my perl5 (revision 5 version 13 subversion 8) configuration: Characteristics of this binary (from libperl): -- |
From @cpansproutNow resolved by 7f586e4, which simply disables the bug fix that 4155e4f |
@cpansprout - Status changed from 'new' to 'resolved' |
From kaffeetisch@gmx.deWhile I could reproduce this problem with 5.13.9, I cannot reproduce it |
From @cpansproutOn Wed Mar 23 15:49:50 2011, kaffeetisch@gmx.de wrote:
I disabled a bug fix with commit 7f586e4, to provide more time to |
From @cpansproutInline Patchdiff --git a/sv.c b/sv.c
index 9351076..0d2df5a 100644
--- a/sv.c
+++ b/sv.c
@@ -552,7 +552,6 @@ do_clean_named_io_objs(pTHX_ SV *const sv)
}
/* Void wrapper to pass to visit() */
-/* XXX
static void
do_curse(pTHX_ SV * const sv) {
if ((PL_stderrgv && GvGP(PL_stderrgv) && (SV*)GvIO(PL_stderrgv) == sv)
@@ -560,7 +559,6 @@ do_curse(pTHX_ SV * const sv) {
return;
(void)curse(sv, 0);
}
-*/
/*
=for apidoc sv_clean_objs
@@ -584,9 +582,7 @@ Perl_sv_clean_objs(pTHX)
visit(do_clean_named_io_objs, SVt_PVGV|SVpgv_GP, SVTYPEMASK|SVp_POK|SVpgv_GP);
/* And if there are some very tenacious barnacles clinging to arrays,
closures, or what have you.... */
- /* XXX This line breaks Tk and Gtk2. See [perl #82542].
visit(do_curse, SVs_OBJECT, SVs_OBJECT);
- */
olddef = PL_defoutgv;
PL_defoutgv = NULL; /* disable skip of PL_defoutgv */
if (olddef && isGV_with_GP(olddef)) |
From @cpansproutWith commit 640c0c3, I’ve re-enabled the bug fix that caused this, so |
@cpansprout - Status changed from 'resolved' to 'open' |
From @cpansproutThis is now resolved. See |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#82542 (status was 'resolved')
Searchable as RT82542$
The text was updated successfully, but these errors were encountered: