Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.13.8-98-g4155e4f breaks TSCH/Gtk2-1.222.tar.gz #11059

Closed
p5pRT opened this issue Jan 20, 2011 · 10 comments
Closed

Bleadperl v5.13.8-98-g4155e4f breaks TSCH/Gtk2-1.222.tar.gz #11059

p5pRT opened this issue Jan 20, 2011 · 10 comments

Comments

@p5pRT
Copy link

p5pRT commented Jan 20, 2011

Migrated from rt.perl.org#82542 (status was 'resolved')

Searchable as RT82542$

@p5pRT
Copy link
Author

p5pRT commented Jan 20, 2011

From @andk

related tickets​:


  http​://rt.perl.org/rt3/Ticket/Display.html?id=81662 (Tk)
  http​://rt.perl.org/rt3/Ticket/Display.html?id=82154 (KinoSearch)

git log​:


  commit 4155e4f
  Author​: Father Chrysostomos <sprout@​cpan.org>
  Date​: Sun Jan 2 14​:51​:21 2011 -0800

  [perl #36347] Object destruction incomplete

  do_clean_objs only looks for objects referenced by RVs, so blessed
  array references and lexical variables (and probably other SVs, too)
  are not DESTROYed.

  This commit adds a new visit() call to sv_clean_objs, which curses
  [...]

example fail report​:


  http​://www.cpantesters.org/cpan/report/10395903

perl -V​:


  Summary of my perl5 (revision 5 version 13 subversion 8) configuration​:
  Commit id​: 4155e4f
  Platform​:
  osname=linux, osvers=2.6.32-5-xen-amd64, archname=x86_64-linux-thread-multi
  uname='linux k81 2.6.32-5-xen-amd64 #1 smp thu nov 25 20​:08​:32 utc 2010 x86_64 gnulinux '
  config_args='-Dprefix=/home/src/perl/repoperls/installed-perls/perl/v5.13.8-98-g4155e4f -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.4.5', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib /usr/lib /lib64 /usr/lib64
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=/lib/libc-2.11.2.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.11.2'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

  Characteristics of this binary (from libperl)​:
  Compile-time options​: MULTIPLICITY PERL_DONT_CREATE_GVSV
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP PERL_USE_DEVEL
  USE_64_BIT_ALL USE_64_BIT_INT USE_ITHREADS
  USE_LARGE_FILES USE_PERLIO USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Jan 4 2011 10​:59​:06
  @​INC​:
  /home/src/perl/repoperls/installed-perls/perl/v5.13.8-98-g4155e4f/lib/site_perl/5.13.8/x86_64-linux-thread-multi
  /home/src/perl/repoperls/installed-perls/perl/v5.13.8-98-g4155e4f/lib/site_perl/5.13.8
  /home/src/perl/repoperls/installed-perls/perl/v5.13.8-98-g4155e4f/lib/5.13.8/x86_64-linux-thread-multi
  /home/src/perl/repoperls/installed-perls/perl/v5.13.8-98-g4155e4f/lib/5.13.8
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Jan 31, 2011

From @cpansprout

Now resolved by 7f586e4, which simply disables the bug fix that 4155e4f
added. Ticket #36347 has been re-opened.

@p5pRT
Copy link
Author

p5pRT commented Jan 31, 2011

@cpansprout - Status changed from 'new' to 'resolved'

@p5pRT
Copy link
Author

p5pRT commented Mar 23, 2011

From kaffeetisch@gmx.de

While I could reproduce this problem with 5.13.9, I cannot reproduce it
with 5.13.10 nor with 5.13.11. So I think the issue has been resolved.

@p5pRT
Copy link
Author

p5pRT commented Mar 27, 2011

From @cpansprout

On Wed Mar 23 15​:49​:50 2011, kaffeetisch@​gmx.de wrote​:

While I could reproduce this problem with 5.13.9, I cannot reproduce it
with 5.13.10 nor with 5.13.11. So I think the issue has been resolved.

I disabled a bug fix with commit 7f586e4, to provide more time to
resolve this. I plan to reinstate it for 5.16.
If you apply the attached patch to a recent copy of perl (e.g.,
5.13.11), the problem should resurface. It has to do with destructors’
not being called on some objects. See
<http​://rt.perl.org/rt3/Ticket/Display.html?id=36347> and
<http​://perl5.git.perl.org/perl.git/commitdiff/4155e4fe>.

@p5pRT
Copy link
Author

p5pRT commented Mar 27, 2011

From @cpansprout

Inline Patch
diff --git a/sv.c b/sv.c
index 9351076..0d2df5a 100644
--- a/sv.c
+++ b/sv.c
@@ -552,7 +552,6 @@ do_clean_named_io_objs(pTHX_ SV *const sv)
 }
 
 /* Void wrapper to pass to visit() */
-/* XXX
 static void
 do_curse(pTHX_ SV * const sv) {
     if ((PL_stderrgv && GvGP(PL_stderrgv) && (SV*)GvIO(PL_stderrgv) == sv)
@@ -560,7 +559,6 @@ do_curse(pTHX_ SV * const sv) {
 	return;
     (void)curse(sv, 0);
 }
-*/
 
 /*
 =for apidoc sv_clean_objs
@@ -584,9 +582,7 @@ Perl_sv_clean_objs(pTHX)
     visit(do_clean_named_io_objs, SVt_PVGV|SVpgv_GP, SVTYPEMASK|SVp_POK|SVpgv_GP);
     /* And if there are some very tenacious barnacles clinging to arrays,
        closures, or what have you.... */
-    /* XXX This line breaks Tk and Gtk2. See [perl #82542].
     visit(do_curse, SVs_OBJECT, SVs_OBJECT);
-    */
     olddef = PL_defoutgv;
     PL_defoutgv = NULL; /* disable skip of PL_defoutgv */
     if (olddef && isGV_with_GP(olddef))

@p5pRT
Copy link
Author

p5pRT commented May 18, 2011

From @cpansprout

With commit 640c0c3, I’ve re-enabled the bug fix that caused this, so
I’m re-opening it.

@p5pRT
Copy link
Author

p5pRT commented May 18, 2011

@cpansprout - Status changed from 'resolved' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jan 5, 2012

From @cpansprout

This is now resolved.

See
<http​://www.nntp.perl.org/group/perl.perl5.porters/;msgid=4F05DFBF.3050501@​gmx.de>
and
<http​://git.gnome.org/browse/perl-Glib/commit/?id=1361e9d22763ef008b6f3bcd82ffeb53c80120c5>.

@p5pRT
Copy link
Author

p5pRT commented Jan 5, 2012

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant