Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some rotor cases are no longer working as expected (.rotor: 2 => -2, 1) #6157

Closed
p6rt opened this issue Mar 19, 2017 · 6 comments
Closed

Some rotor cases are no longer working as expected (.rotor: 2 => -2, 1) #6157

p6rt opened this issue Mar 19, 2017 · 6 comments
Labels
regression Issue did not exist previously testneeded

Comments

@p6rt
Copy link

p6rt commented Mar 19, 2017

Migrated from rt.perl.org#131018 (status was 'resolved')

Searchable as RT131018$

@p6rt
Copy link
Author

p6rt commented Mar 19, 2017

From @AlexDaniel

Code​:
.say for <a b c d e f>.rotor(2 => -2, 1)

Result (2015.12..2016.12)​:
(a b)
(a)
(b c)
(b)
(c d)
(c)
(d e)
(d)
(e f)
(e)

Result (2017.01)​:
Rotorizing gap is out of range. Is​: -2, should be in -1..^Inf;
Ensure a negative gap is not larger than the length of the sublist
  in block <unit> at /tmp/uYWEuzId1z line 1

Result (2017.02,2017.03,HEAD(fbe7ace))​:
(a b)

The first change happened in rakudo/rakudo@d7b8214
Then it was brought back to life in rakudo/rakudo@b9d9279

Previous behavior (2015.12-ish) is what I expect to happen. It is consistent with behavior observed in other cases, for example​:

Code​:
.say for <a b c d e f>.rotor(2 => -1, 1)

Result​:
(a b)
(b)
(c d)
(d)
(e f)
(f)

@p6rt
Copy link
Author

p6rt commented Mar 19, 2017

From @lizmat

am looking at it

On 19 Mar 2017, at 22​:03, Aleks-Daniel Jakimenko-Aleksejev (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Aleks-Daniel Jakimenko-Aleksejev
# Please include the string​: [perl #​131018]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131018 >

Code​:
.say for <a b c d e f>.rotor(2 => -2, 1)

Result (2015.12..2016.12)​:
(a b)
(a)
(b c)
(b)
(c d)
(c)
(d e)
(d)
(e f)
(e)

Result (2017.01)​:
Rotorizing gap is out of range. Is​: -2, should be in -1..^Inf;
Ensure a negative gap is not larger than the length of the sublist
in block <unit> at /tmp/uYWEuzId1z line 1

Result (2017.02,2017.03,HEAD(fbe7ace))​:
(a b)

The first change happened in rakudo/rakudo@d7b8214
Then it was brought back to life in rakudo/rakudo@b9d9279

Previous behavior (2015.12-ish) is what I expect to happen. It is consistent with behavior observed in other cases, for example​:

Code​:
.say for <a b c d e f>.rotor(2 => -1, 1)

Result​:
(a b)
(b)
(c d)
(d)
(e f)
(f)

@p6rt
Copy link
Author

p6rt commented Mar 19, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Mar 20, 2017

From @lizmat

Fixed with rakudo/rakudo@5917b817c6 , tests needed

On 19 Mar 2017, at 22​:03, Aleks-Daniel Jakimenko-Aleksejev (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Aleks-Daniel Jakimenko-Aleksejev
# Please include the string​: [perl #​131018]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131018 >

Code​:
.say for <a b c d e f>.rotor(2 => -2, 1)

Result (2015.12..2016.12)​:
(a b)
(a)
(b c)
(b)
(c d)
(c)
(d e)
(d)
(e f)
(e)

Result (2017.01)​:
Rotorizing gap is out of range. Is​: -2, should be in -1..^Inf;
Ensure a negative gap is not larger than the length of the sublist
in block <unit> at /tmp/uYWEuzId1z line 1

Result (2017.02,2017.03,HEAD(fbe7ace))​:
(a b)

The first change happened in rakudo/rakudo@d7b8214
Then it was brought back to life in rakudo/rakudo@b9d9279

Previous behavior (2015.12-ish) is what I expect to happen. It is consistent with behavior observed in other cases, for example​:

Code​:
.say for <a b c d e f>.rotor(2 => -1, 1)

Result​:
(a b)
(b)
(c d)
(d)
(e f)
(f)

@p6rt
Copy link
Author

p6rt commented Jul 22, 2017

From @zoffixznet

On Mon, 20 Mar 2017 04​:46​:18 -0700, elizabeth wrote​:

Fixed with rakudo/rakudo@5917b817c6 , tests
needed

On 19 Mar 2017, at 22​:03, Aleks-Daniel Jakimenko-Aleksejev (via RT)
<perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Aleks-Daniel Jakimenko-Aleksejev
# Please include the string​: [perl #​131018]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131018 >

Code​:
.say for <a b c d e f>.rotor(2 => -2, 1)

Result (2015.12..2016.12)​:
(a b)
(a)
(b c)
(b)
(c d)
(c)
(d e)
(d)
(e f)
(e)

Result (2017.01)​:
Rotorizing gap is out of range. Is​: -2, should be in -1..^Inf;
Ensure a negative gap is not larger than the length of the sublist
in block <unit> at /tmp/uYWEuzId1z line 1

Result (2017.02,2017.03,HEAD(fbe7ace))​:
(a b)

The first change happened in
rakudo/rakudo@d7b8214
Then it was brought back to life in
rakudo/rakudo@b9d9279

Previous behavior (2015.12-ish) is what I expect to happen. It is
consistent with behavior observed in other cases, for example​:

Code​:
.say for <a b c d e f>.rotor(2 => -1, 1)

Result​:
(a b)
(b)
(c d)
(d)
(e f)
(f)

Tests added​: Raku/roast#287

@p6rt
Copy link
Author

p6rt commented Jul 22, 2017

@zoffixznet - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Jul 22, 2017
@p6rt p6rt added regression Issue did not exist previously testneeded labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue did not exist previously testneeded
Projects
None yet
Development

No branches or pull requests

1 participant