Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splice no longer attempts to numify things (@a.splice: ^3) #5937

Open
p6rt opened this issue Dec 29, 2016 · 5 comments
Open

splice no longer attempts to numify things (@a.splice: ^3) #5937

p6rt opened this issue Dec 29, 2016 · 5 comments
Labels
regression Issue did not exist previously

Comments

@p6rt
Copy link

p6rt commented Dec 29, 2016

Migrated from rt.perl.org#130439 (status was 'open')

Searchable as RT130439$

@p6rt
Copy link
Author

p6rt commented Dec 29, 2016

From @AlexDaniel

Code​:
my @​a = <a b c d e f g>; say @​a.splice​: ^3

Result (2015.12,2016.07.1)​:
[d e f g]

Result (HEAD)​:
Cannot resolve caller splice(Array​: Range); none of these signatures match​:
  (Array​:D \SELF​: *%_)
  (Array​:D $​: Whatever, *%_)
  (Array​:D $​: Callable​:D $offset, *%_)
  (Array​:D $​: Int​:D $offset, *%_)
  (Array​:D $​: Whatever, Whatever, *%_)
  (Array​:D $​: Whatever, Int​:D $size, *%_)
  (Array​:D $​: Whatever, Callable​:D $size, *%_)
  (Array​:D $​: Callable​:D $offset, Callable​:D $size, *%_)
  (Array​:D $​: Callable​:D $offset, Whatever, *%_)
  (Array​:D $​: Callable​:D $offset, Int​:D $size, *%_)
  (Array​:D $​: Int​:D $offset, Whatever, *%_)
  (Array​:D $​: Int​:D $offset, Callable​:D $size, *%_)
  (Array​:D $​: Int​:D $offset, Int​:D $size, *%_)
  (Array​:D $​: Whatever $offset, Whatever $size, **@​new, *%_)
  (Array​:D $​: Whatever $offset, Callable​:D $size, **@​new, *%_)
  (Array​:D $​: Whatever $offset, Int​:D $size, **@​new, *%_)
  (Array​:D $​: Callable​:D $offset, Whatever $size, **@​new, *%_)
  (Array​:D $​: Callable​:D $offset, Callable​:D $size, **@​new, *%_)
  (Array​:D $​: Callable​:D $offset, Int​:D $size, **@​new, *%_)
  (Array​:D $​: Int​:D $offset, Whatever $size, **@​new, *%_)
  (Array​:D $​: Int​:D $offset, Callable​:D $size, **@​new, *%_)
  (Array​:D $​: Int​:D $offset, Int​:D $size, **@​new, *%_)
  (Array​:D $​: Whatever, Whatever, @​new, *%_)
  (Array​:D $​: Whatever, Int​:D $size, @​new, *%_)
  (Array​:D $​: Whatever, Callable​:D $size, @​new, *%_)
  (Array​:D $​: Callable​:D $offset, Callable​:D $size, @​new, *%_)
  (Array​:D $​: Callable​:D $offset, Whatever, @​new, *%_)
  (Array​:D $​: Callable​:D $offset, Int​:D $size, @​new, *%_)
  (Array​:D $​: Int​:D $offset, Whatever, @​new, *%_)
  (Array​:D $​: Int​:D $offset, Callable​:D $size, @​new, *%_)
  (Array​:D $​: Int​:D $offset, Int​:D $size, @​new, *%_)
in block <unit> at /tmp/SItA2b7BIp line 1

Bisectable points to rakudo/rakudo@f32173b

Given that the commit was attempting to improve the performance, I think the change was unintentional. However, feel free to argue that the current behavior is correct. If so, please treat this ticket as [LTA] (the amount of candidates printed is insane).

@p6rt
Copy link
Author

p6rt commented Dec 29, 2016

From @zoffixznet

FWIW, my math[^1] suggests with current system we'd need 22 more candidates to handle Cool, bringing the total to 52 candidates.

IMO Cool candidates are important to have, perhaps we can de-optimize something that won't have a huge performance hit, while reducing the candidates to saner levels?

[1] https://irclog.perlgeek.de/perl6-dev/2016-12-29#i_13819263

@p6rt
Copy link
Author

p6rt commented Dec 29, 2016

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jan 18, 2017

From @lizmat

Fixed in rakudo/rakudo@76f14a5c1f

Marking tests needed

@p6rt
Copy link
Author

p6rt commented Jan 21, 2017

From @zoffixznet

The original fix was reverted in rakudo/rakudo@121e5e32e9 per discussion https://irclog.perlgeek.de/perl6-dev/2017-01-21#i_13962511

@p6rt p6rt added the regression Issue did not exist previously label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue did not exist previously
Projects
None yet
Development

No branches or pull requests

1 participant