New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi method cache causes Base64 regression #5428
Comments
From @ugexeThe failures are only for decoding. Encoding still works. Failures: Relevant code: The first multi dispatch cache commit only caused failures sometimes. The commit afterwards (d4ac15c) to fix a different multi dispatch cache problem causes it to always fail, and often segfault. |
From @ugexeNote that the final decode-base64 candidate shows the correct results when debugging statements are added This gist also shows a small change that makes it produce the correct values but it still segfaults more often than not |
From @jnthnOn Tue Jul 05 17:51:46 2016, ugexe@cpan.org wrote:
Having dug into it a little, I'm not sure that the new multi-caching stuff has caused this, so much as uncovered it (perhaps by moving GC collection points). The valgrind output is as follows: ok 1 - decoding the empty string Which is suggestive of some kind of memory corruption (seemingly due to over-sharing or a premature free) inside of the argument capture. Still trying to figure out exactly what leads to this. |
The RT System itself - Status changed from 'new' to 'open' |
From @ugexeOn Sat Jul 09 07:13:48 2016, jnthn@jnthn.net wrote:
You are right. I golfed it down to the following gist which does not use multi methods: In the gist comments there is also a link to the bisect output, but for brevity: |
From @LLFournI've been getting segfaults in this area recently. The trace is a bit (lldb) r (MVMGCWorklist *) worklist = 0x000000010d27c1a0 (MVMArgProcContext *) ctx = 0x000000010a6f3c00 (MVMuint8 *) flag_map = 0x0000000010a72533 "" On Sun, Jul 10, 2016 at 12:19 AM jnthn@jnthn.net via RT <
|
From @LLFournBy flag_map I mean ctx->callsite->arg_flags: (lldb) p ctx->arg_flags On Mon, Jul 11, 2016 at 3:59 AM Lloyd Fournier <lloyd.fourn@gmail.com>
|
From @dogbert17On Wed, 27 Jul 2016 17:43:48 -0700, lloyd.fourn@gmail.com wrote:
Fixed with commit (2017-09-30) rakudo/rakudo@41896b7. |
Migrated from rt.perl.org#128553 (status was 'open')
Searchable as RT128553$
The text was updated successfully, but these errors were encountered: