Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/spec/S32-temporal/DateTime.t #5148

Closed
p6rt opened this issue Feb 22, 2016 · 5 comments
Closed

t/spec/S32-temporal/DateTime.t #5148

p6rt opened this issue Feb 22, 2016 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Feb 22, 2016

Migrated from rt.perl.org#127590 (status was 'resolved')

Searchable as RT127590$

@p6rt
Copy link
Author

p6rt commented Feb 22, 2016

From @coke

This test fails with a release candidate for the 2016.02 branch,
against the 6.c-errata roast branch​:

not ok 196 - adding a day to a leap second

# Failed test 'adding a day to a leap second'
# at t/spec/S32-temporal/DateTime.t line 504
# expected​: '2009-01-02T00​:00​:00Z'
# got​: '2009-01-01T23​:59​:59Z'

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Feb 22, 2016

From @moritz

This is the commit that changed the behavior in roast/master​:

commit 5e60103de6e4c7dd73e979b42115c9da0415f591
Author​: Elizabeth Mattijsen <liz@​dijkmat.nl>
Date​: 2015-12-29 13​:22​:41 +0100

  Fix faulty test and some spelling errors
 
  Moving from a leap-second by anything but seconds, should clip,
  not rollover to the next minute/hour/day

Inline Patch
diff --git a/S32-temporal/DateTime.t b/S32-temporal/DateTime.t
index 186beff..d0ea3af 100644
--- a/S32-temporal/DateTime.t
+++ b/S32-temporal/DateTime.t
@@ -502,8 +502,8 @@ is DateTime.now.Date, Date.today, 'coercion to Date';
        'adding 2 days, overflowing to March';
 
     is ds('2008-12-31T23:59:60Z').later(day => 1),
-       ds('2009-01-02T00:00:00Z'),
-       'adding a day to a leap second';
+       ds('2009-01-01T23:59:59Z'),
+       'adding a day to a leap second clips';
 
     is ds('1972-12-31T23:59:60Z').later(year => 1),
        ds('1973-12-31T23:59:60Z'),

(hunks removed that don't alter behavior).

I wonder if this should be cherry-picked to the 6.c-errata branch

@p6rt
Copy link
Author

p6rt commented Apr 11, 2016

From @usev6

The faulty test was fixed in the 6.c-errata branch with commit 6af3c5b5de.

I'm closing this ticket as 'resolved'.

1 similar comment
@p6rt
Copy link
Author

p6rt commented Apr 11, 2016

From @usev6

The faulty test was fixed in the 6.c-errata branch with commit 6af3c5b5de.

I'm closing this ticket as 'resolved'.

@p6rt
Copy link
Author

p6rt commented Apr 11, 2016

@usev6 - Status changed from 'new' to 'resolved'

@p6rt p6rt closed this as completed Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant