Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race when creating buf8 objects (involving typed roles?) #3662

Closed
p6rt opened this issue Jan 31, 2015 · 4 comments
Closed

Race when creating buf8 objects (involving typed roles?) #3662

p6rt opened this issue Jan 31, 2015 · 4 comments

Comments

@p6rt
Copy link

p6rt commented Jan 31, 2015

Migrated from rt.perl.org#123702 (status was 'resolved')

Searchable as RT123702$

@p6rt
Copy link
Author

p6rt commented Jan 31, 2015

From andrew@egeler.us

'await do for 1..5 { start { buf8.new } }' results in error 50+% of the time on my machine (perl6-m). https://github.com/retupmoca/rakudo/commit/d2eba029e90d89b48085b800118251deb578f43b seems to fix the issue, but I don't know if it's a good idea or what other implications that change would have; or even if that's the best way to implement the fix.

@p6rt
Copy link
Author

p6rt commented May 15, 2015

From @jnthn

On Sat Jan 31 10​:59​:49 2015, root+bitcard@​retupmoca.com wrote​:

'await do for 1..5 { start { buf8.new } }' results in error 50+% of
the time on my machine (perl6-m).
https://github.com/retupmoca/rakudo/commit/d2eba029e90d89b48085b800118251deb578f43b
seems to fix the issue, but I don't know if it's a good idea or what
other implications that change would have; or even if that's the best
way to implement the fix.

I did a few different changes to achieve a fix, but yes, some concurrency control was required in one place. Added a test in S17-promise/start.t to cover this; it seems to pass very reliably now (can't get it to fail).

@p6rt
Copy link
Author

p6rt commented May 15, 2015

The RT System itself - Status changed from 'new' to 'open'

@p6rt p6rt closed this as completed May 15, 2015
@p6rt
Copy link
Author

p6rt commented May 15, 2015

@jnthn - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant