[PATCH] fix Win32 nmake cant rebuild DynaLoader.obj on Makefile regen bug #14206
Comments
From @bulk88Created by @bulk88Need #. The problem C:\perl521\srcnewb4opt\win32> ..\miniperl.exe -I..\lib Generating a nmake-style Makefile C:\perl521\srcnewb4opt\win32> C:\perl521\srcnewb4opt\win32> ..\miniperl.exe -I..\lib Microsoft (R) Program Maintenance Utility Version 7.10.3077 ..\..\miniperl.exe "-I..\..\lib" "-I..\..\lib" Makefile.PL C:\perl521\srcnewb4opt\win32> Writing Makefile for DynaLoader C:\perl521\srcnewb4opt\win32> ..\miniperl.exe -I..\lib Microsoft (R) Program Maintenance Utility Version 7.10.3077 ..\..\miniperl.exe "-I..\..\lib" Makefile.PL "INSTALLDIRS=perl" C:\perl521\srcnewb4opt\win32> RT is swallowing my email without a trace. No emails back, nothing on Perl Info |
From @bulk88On Mon Nov 03 19:34:12 2014, bulk88 wrote:
Yep, RT/something in p5p's system was rejecting the email because of the gif. Gif attached. -- |
From @bulk88 |
From @tonycozOn Mon Nov 03 19:34:12 2014, bulk88 wrote:
The subject includes "[PATCH]", but I don't see one. Should there be one? Tony |
|
The RT System itself - Status changed from 'new' to 'open' |
From @bulk88On Mon Nov 03 21:02:36 2014, tonyc wrote:
Attached. -- |
From @bulk880001-fix-Win32-nmake-cant-rebuild-DynaLoader.obj-on-Makef.patchFrom 35970193dfd79adc31b0fe59ba3795b7a89c22af Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Tue, 4 Nov 2014 01:14:04 -0500
Subject: [PATCH] fix Win32 nmake cant rebuild DynaLoader.obj on Makefile
regen bug
See [perl #123123] for details.
---
ext/DynaLoader/Makefile.PL | 3 ++-
make_ext.pl | 5 +----
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/ext/DynaLoader/Makefile.PL b/ext/DynaLoader/Makefile.PL
index 76c3bc0..864af3e 100644
--- a/ext/DynaLoader/Makefile.PL
+++ b/ext/DynaLoader/Makefile.PL
@@ -14,7 +14,8 @@ WriteMakefile(
VERSION_FROM => 'DynaLoader_pm.PL',
PL_FILES => {'DynaLoader_pm.PL'=>'DynaLoader.pm'},
PM => {'DynaLoader.pm' => '$(INST_LIBDIR)/DynaLoader.pm'},
- depend => {'DynaLoader$(OBJ_EXT)' => 'dlutils.c'},
+ depend => { 'DynaLoader$(OBJ_EXT)' => 'dlutils.c',
+ 'DynaLoader.c' => 'DynaLoader.xs'},
clean => {FILES => 'DynaLoader.c DynaLoader.xs DynaLoader.pm'},
);
diff --git a/make_ext.pl b/make_ext.pl
index 6e7955d..717d1b3 100644
--- a/make_ext.pl
+++ b/make_ext.pl
@@ -185,10 +185,7 @@ if ($is_Win32) {
next;
}
push @extspec, $_;
- if($_ eq 'DynaLoader' and $target !~ /clean$/) {
- # No, we don't know why nmake can't work out the dependency chain
- push @{$extra_passthrough{$_}}, 'DynaLoader.c';
- } elsif(FindExt::is_static($_)) {
+ if($_ ne 'DynaLoader' && FindExt::is_static($_)) {
push @{$extra_passthrough{$_}}, 'LINKTYPE=static';
}
}
--
1.7.9.msysgit.0
|
From @cpansproutOn Mon Nov 03 22:16:02 2014, bulk88 wrote:
Nice bug number. :-)
Thank you. Applied as 1ea1c22. -- Father Chrysostomos |
|
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#123123 (status was 'resolved')
Searchable as RT123123$
The text was updated successfully, but these errors were encountered: