Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

die() shouldn't abort LEAVE queue, but it does on JVM and on MoarVM #3363

Closed
p6rt opened this issue Mar 28, 2014 · 4 comments
Closed

die() shouldn't abort LEAVE queue, but it does on JVM and on MoarVM #3363

p6rt opened this issue Mar 28, 2014 · 4 comments

Comments

@p6rt
Copy link

p6rt commented Mar 28, 2014

Migrated from rt.perl.org#121530 (status was 'resolved')

Searchable as RT121530$

@p6rt
Copy link
Author

p6rt commented Mar 28, 2014

From @moritz

S04-phasers/enter-leave.t has this test​:

  my $str;
  try {
  LEAVE { $str ~= '1' }
  LEAVE { $str ~= '2'; die 'foo' }
  }
  is $str, '21', 'die doesn\'t abort LEAVE queue';

which passes on parrot, but fails on the JVM and MoarVM, with

not ok 19 - die doesn't abort LEAVE queue
# got​: '2'
# expected​: '21'

@p6rt
Copy link
Author

p6rt commented Oct 5, 2015

From @jnthn

On Fri Mar 28 12​:59​:42 2014, moritz wrote​:

S04-phasers/enter-leave.t has this test​:

my $str;
try \{
    LEAVE \{ $str ~= '1' \}
    LEAVE \{ $str ~= '2'; die 'foo' \}
\}
is $str, '21', 'die doesn\\'t abort LEAVE queue';

which passes on parrot, but fails on the JVM and MoarVM, with

not ok 19 - die doesn't abort LEAVE queue
# got​: '2'
# expected​: '21'

Fixed, test unfudged. Also added a mechanism for conveying multiple exceptions if multiple LEAVEs throw and tested that too.

@p6rt
Copy link
Author

p6rt commented Oct 5, 2015

The RT System itself - Status changed from 'new' to 'open'

@p6rt p6rt closed this as completed Oct 5, 2015
@p6rt
Copy link
Author

p6rt commented Oct 5, 2015

@jnthn - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant