Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the git protocol instead of https, as the build is breaking in systems where curl-devel packages are not installed(Or more importantly can't be installed, due to various reasons) #3320

Closed
p6rt opened this issue Jan 24, 2014 · 8 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Jan 24, 2014

Migrated from rt.perl.org#121072 (status was 'resolved')

Searchable as RT121072$

@p6rt
Copy link
Author

p6rt commented Jan 24, 2014

From arafatkamaal@gmail.com

0001-Use-the-git-protocol-instead-of-https-as-the-build-i.patch
From 7aced261936a8b5e807ccfc06b9c6174370ca741 Mon Sep 17 00:00:00 2001
From: kamaal <arafatkamaal@gmail.com>
Date: Fri, 24 Jan 2014 06:04:40 +0000
Subject: [PATCH] Use the git protocol instead of https, as the build is
 breaking in systems where curl-devel packages are not
 installed(Or more importantly can't be installed, due to
 various reasons)

---
 tools/lib/NQP/Configure.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/lib/NQP/Configure.pm b/tools/lib/NQP/Configure.pm
index 000845e..86ee08c 100644
--- a/tools/lib/NQP/Configure.pm
+++ b/tools/lib/NQP/Configure.pm
@@ -29,9 +29,9 @@ our @required_nqp_files = qw(
     @bindir@/nqp-p@exe@
 );
 
-our $nqp_git = 'https://github.com/perl6/nqp.git';
-our $par_git = 'https://github.com/parrot/parrot.git';
-our $moar_git= 'https://github.com/MoarVM/MoarVM.git';
+our $nqp_git = 'git://github.com/perl6/nqp.git';
+our $par_git = 'git://github.com/parrot/parrot.git';
+our $moar_git= 'git://github.com/MoarVM/MoarVM.git';
 
 our $nqp_push = 'git@github.com:perl6/nqp.git';
 our $par_push = 'git@github.com:parrot/parrot.git';
-- 
1.7.12

@p6rt
Copy link
Author

p6rt commented Jan 24, 2014

From @coke

On Thu Jan 23 22​:11​:10 2014, arafatkamaal@​gmail.com wrote​:

There are other situations where *only* http connections are allowed, and git connections are not (corporate firewalls). I'd like to have some discussion here before it gets applied.

--
Will "Coke" Coleda

1 similar comment
@p6rt
Copy link
Author

p6rt commented Jan 24, 2014

From @coke

On Thu Jan 23 22​:11​:10 2014, arafatkamaal@​gmail.com wrote​:

There are other situations where *only* http connections are allowed, and git connections are not (corporate firewalls). I'd like to have some discussion here before it gets applied.

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Jan 24, 2014

From @pmichaud

On Fri Jan 24 08​:15​:45 2014, coke wrote​:

There are other situations where *only* http connections are allowed,
and git connections are not (corporate firewalls). I'd like to have
some discussion here before it gets applied.

Agreed with coke -- originally we were using git​: connections, and
then we changed it to http​: because of firewalling issues.

I prefer that http​: remain the default, and perhaps we provide a
configure option that enables git​: connections to be used instead.
Even better would be to probe to select the best option.

Pm

@p6rt
Copy link
Author

p6rt commented Jan 24, 2014

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jan 24, 2014

From @moritz

On 01/24/2014 05​:15 PM, Will Coleda via RT wrote​:

On Thu Jan 23 22​:11​:10 2014, arafatkamaal@​gmail.com wrote​:

There are other situations where *only* http connections are allowed, and git connections are not (corporate firewalls). I'd like to have some discussion here before it gets applied.

I've started a discussion here​:

Raku/nqp#153

Cheers,
Moritz

@p6rt
Copy link
Author

p6rt commented Jan 26, 2014

From @moritz

Now made configurable in rakudo/rakudo@c2982df7c4

@p6rt
Copy link
Author

p6rt commented Jan 26, 2014

@moritz - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Jan 26, 2014
@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant