Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] fixed usage of "no if .. warnings" in perldelta #13006

Closed
p5pRT opened this issue May 30, 2013 · 7 comments
Closed

[PATCH] fixed usage of "no if .. warnings" in perldelta #13006

p5pRT opened this issue May 30, 2013 · 7 comments
Labels

Comments

@p5pRT
Copy link

p5pRT commented May 30, 2013

Migrated from rt.perl.org#118249 (status was 'resolved')

Searchable as RT118249$

@p5pRT
Copy link
Author

p5pRT commented May 30, 2013

From @domm

This is a bug report for perl from domm@​plix.at,
generated with the help of perlbug 1.39 running under perl 5.14.2.

From eeeadd16dcfaa7977dfba9a1ba07ac7708ad16f0 Mon Sep 17 00​:00​:00 2001
From​: Thomas Klausner <domm@​plix.at>
Date​: Thu, 30 May 2013 11​:10​:30 +0200
Subject​: [PATCH] fixed usage of "no if .. warnings" in perldelta


pod/perl5180delta.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Inline Patch
diff --git a/pod/perl5180delta.pod b/pod/perl5180delta.pod
index aa244dc..03341b6 100644
--- a/pod/perl5180delta.pod
+++ b/pod/perl5180delta.pod
@@ -405,7 +405,7 @@ is not recommended.
 Warnings will now be issued when the parser sees C<~~>, C<given>, or C<when>.
 To disable these warnings, you can add this line to the appropriate scope:
 
-  no if $] >= 5.018, "experimental::smartmatch";
+  no if $] >= 5.018, 'warnings', "experimental::smartmatch";
 
 Consider, though, replacing the use of these features, as they may change
 behavior again before becoming stable.
-- 
1.7.10.4

Flags​:
  category=docs
  severity=low


Site configuration information for perl 5.14.2​:

Configured by Debian Project at Wed Apr 10 16​:58​:16 UTC 2013.

Summary of my perl5 (revision 5 version 14 subversion 2) configuration​:
 
  Platform​:
  osname=linux, osvers=3.2.0-4-amd64, archname=x86_64-linux-gnu-thread-multi
  uname='linux madeleine 3.2.0-4-amd64 #1 smp debian 3.2.39-2 x86_64 gnulinux '
  config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Dldflags= -Wl,-z,relro -Dlddlflags=-shared -Wl,-z,relro -Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.14 -Darchlib=/usr/lib/perl/5.14 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.14.2 -Dsitearch=/usr/local/lib/perl/5.14.2 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Duse64bitint -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -Ui_libutil -DDEBUGGING=-g -Doptimize=-O2 -Duseshrplib -Dlibperl=libperl.so.5.14.2 -des'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fstack-protector -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2 -g',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fstack-protector -fno-strict-aliasing -pipe -I/usr/local/include'
  ccversion='', gccversion='4.7.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib
  libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt
  perllibs=-ldl -lm -lpthread -lc -lcrypt
  libc=, so=so, useshrplib=true, libperl=libperl.so.5.14.2
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib -fstack-protector'

Locally applied patches​:
 


@​INC for perl 5.14.2​:
  /etc/perl
  /usr/local/lib/perl/5.14.2
  /usr/local/share/perl/5.14.2
  /usr/lib/perl5
  /usr/share/perl5
  /usr/lib/perl/5.14
  /usr/share/perl/5.14
  /usr/local/lib/site_perl
  .


Environment for perl 5.14.2​:
  HOME=/home/domm
  LANG (unset)
  LANGUAGE (unset)
  LC_CTYPE=en_US.UTF-8
  LC_MESSAGES=POSIX
  LC_MONETARY=de_AT.utf8
  LC_NUMERIC=de_AT.utf8
  LC_PAPER=de_AT.utf8
  LC_RESPONSE=POSIX
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/home/domm/perl5/perlbrew/bin​:/home/domm/bin​:/usr/local/bin​:/usr/bin​:/bin​:/usr/local/games​:/usr/games​:/home/domm/bin
  PERLBREW_BASHRC_VERSION=0.63
  PERLBREW_HOME=/home/domm/.perlbrew
  PERLBREW_ROOT=/home/domm/perl5/perlbrew
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented May 30, 2013

From @karenetheridge

On Thu, May 30, 2013 at 02​:20​:45AM -0700, Thomas Klausner wrote​:

# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=118249 >

- no if $] >= 5.018, "experimental​::smartmatch";
+ no if $] >= 5.018, 'warnings', "experimental​::smartmatch";

I'd change that to​:

  no if $] >= 5.018, warnings => "experimental​::smartmatch";

...to make it more clear that it's the warnings pragma being called,
with "experimental​::smartmatch" as its argument, rather than two unrelated
arguments being used.

@p5pRT
Copy link
Author

p5pRT commented May 30, 2013

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 30, 2013

From @Hugmeir

On Thu, May 30, 2013 at 6​:17 PM, Karen Etheridge <perl@​froods.org> wrote​:

On Thu, May 30, 2013 at 02​:20​:45AM -0700, Thomas Klausner wrote​:

# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=118249 >

- no if $] >= 5.018, "experimental​::smartmatch";
+ no if $] >= 5.018, 'warnings', "experimental​::smartmatch";

I'd change that to​:

no if $] >= 5.018, warnings => "experimental​::smartmatch";

...to make it more clear that it's the warnings pragma being called,
with "experimental​::smartmatch" as its argument, rather than two unrelated
arguments being used.

+1

@p5pRT
Copy link
Author

p5pRT commented May 31, 2013

From @rjbs

How embarrassing!

I have fixed this in blead as 2153ce5 and maint-5.18 as 576348d, using the tweak that Karen
suggested. Thanks.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented May 31, 2013

From [Unknown Contact. See original ticket]

How embarrassing!

I have fixed this in blead as 2153ce5 and maint-5.18 as 576348d, using the tweak that Karen
suggested. Thanks.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented May 31, 2013

@rjbs - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant