New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] constant.pm: remove 5.6 checks, small test adjustment for 5.8 #12381
Comments
From @maddingueThis is a bug report for perl from saper@cpan.org, Hello, Attached are two patches for constant.pm: * constant.pm-1.24-utf8-test.diff Regards, Sébastien Aperghis-Tramoni file: constant.pm-1.24-remove-5.6-checks.diff Inline Patch--- blead/dist/constant/lib/constant.pm 2012-09-04 11:15:26.000000000 +0200
+++ blead/dist/constant/lib/constant.pm 2012-09-05 21:25:14.000000000 +0200
@@ -1,5 +1,5 @@
package constant;
-use 5.005;
+use 5.008;
use strict;
use warnings::register;
@@ -17,10 +17,9 @@
my %forbidden = (%keywords, %forced_into_main);
-my $str_end = $] >= 5.006 ? "\\z" : "\\Z";
-my $normal_constant_name = qr/^_?[^\W_0-9]\w*$str_end/;
-my $tolerable = qr/^[A-Za-z_]\w*$str_end/;
-my $boolean = qr/^[01]?$str_end/;
+my $normal_constant_name = qr/^_?[^\W_0-9]\w*\z/;
+my $tolerable = qr/^[A-Za-z_]\w*\z/;
+my $boolean = qr/^[01]?\z/;
BEGIN {
# We'd like to do use constant _CAN_PCS => $] > 5.009002
--- blead/dist/constant/t/constant.t 2009-12-28 13:04:37.000000000 +0100
+++ blead/dist/constant/t/constant.t 2012-09-04 11:17:30.000000000 +0200
@@ -167,7 +167,6 @@
@warnings = ();
eval q{
no warnings;
- #local $^W if $] < 5.006;
use warnings 'constant';
use constant 'BEGIN' => 1 ;
use constant 'INIT' => 1 ;
Inline Patch--- blead/dist/constant/t/utf8.t 2011-04-18 10:16:25.000000000 +0200
+++ blead/dist/constant/t/utf8.t 2012-09-03 17:04:36.000000000 +0200
@@ -1,9 +1,15 @@
#!./perl -T
+use Test::More;
+BEGIN {
+ plan skip_all => "irrelevant on pre-5.8.4" if $] < 5.008004
+}
+
# Tests for constant.pm that require the utf8 pragma
use utf8;
-use Test::More tests => 2;
+
+plan tests => 2;
use constant π => 4 * atan2 1, 1;
---
Site configuration information for perl 5.16.1: Configured by maddingue at Tue Aug 14 00:18:54 CEST 2012. Summary of my perl5 (revision 5 version 16 subversion 1) configuration: Locally applied patches: @INC for perl 5.16.1: Environment for perl 5.16.1: |
From @rurbanOn Wed, Sep 5, 2012 at 3:13 PM, Sebastien Aperghis-Tramoni
Veto. constant does not work on 5.6 anymore because the former change was wrong. I'll come up with a patch, but I'm lying sick in bed for a few days. Why are you guys are so destructive all the time? |
The RT System itself - Status changed from 'new' to 'open' |
From @iabynOn Wed, Sep 05, 2012 at 07:40:39PM -0500, Reini Urban wrote:
Why are you an obnoxious arsehole all the time? -- |
From @nwc10I'm going to beat Ricardo to this: On Thu, Sep 06, 2012 at 11:53:13AM +0100, Dave Mitchell wrote:
That sort of language is not acceptable on this list from *anyone*. You, me, Whatever you feel. However true it is (or might seem to be). (And to be clear here, I don't agree with your statement) Nicholas Clark |
From @ap* Reini Urban <rurban@x-ray.at> [2012-09-06 02:45]:
People work on what they care about. So do you. Most people consider If you are the only one who cares about something, it will fall on you That’s not malice. That is just the consequence of people working on But if you are willing to take on the work for what you care about and That is what I have seen happen to you so far, at least. People aren’t destructive or against you, you are simply the only one Sorry. :-/ Regards, |
From @renormalistAristotle Pagaltzis <pagaltzis@gmx.de> writes:
Just to put in a statement from the side: Besides the style of It's very fair to negotiate communication style but don't forget the Speed matters, that's a fact. Not allowing discussion before Reini comes Kind regards, |
From @maddingueSteffen Schwigon wrote via RT:
In this very case, and unless I misunderstood, it was not about speed but about keeping or not constant.pm compatible with Perl 5.6. Personally, I am all in favor of not breaking backcompat as long as it doesn't require unreasonable efforts. Most of the work that the Perl 5 Porters did on constant.pm in the past year has been to correctly handle Unicode names, which AFAICT really requires Perl 5.8. -- Close the world, txEn eht nepO. |
From @doyOn Tue, Sep 11, 2012 at 10:00:19AM +0100, Steffen Schwigon wrote:
I fail to see where anyone here is not allowing discussion. In fact, we -doy |
From @nwc10On Tue, Sep 11, 2012 at 09:27:27AM -0500, Jesse Luehrs wrote:
There is no silver bullet. I think that it's accurate to say that everyone agrees that Perl 5 (as is) Reini's broad thrust seems to be to take the approach of toning down the That will get some speedup, but without (at least) prototyping it, it's not But it's certainly not a silver bullet. The silver bullet would be a way
Agree. We seem to have a lot of discussions about this and quite a few things It's not "no discussion". It's "please, more code, less code-free discussion" Very much a reaction to "meetings, the practical alternative to work". Nicholas Clark |
From @maddingueHello all, On Sep 5. 2012 at 22:13, Sebastien Aperghis-Tramoni wrote via RT:
May I respectfully ask the status about these patches? Thanks -- Close the world, txEn eht nepO. |
From @khwilliamsonOn Wed Dec 05 14:37:29 2012, Maddingue_ wrote:
I just looked them over, and the thread for this ticket. I applied the |
From @maddingueKarl Williamson wrote via RT:
Thank you. -- Close the world, txEn eht nepO. |
From @jkeenanOn Wed Dec 05 16:22:03 2012, khw wrote:
If I read Sebastien's original post correctly, this is the ##### Inline Patch--- blead/dist/constant/lib/constant.pm 2012-09-04 11:15:26.000000000 +0200
+++ blead/dist/constant/lib/constant.pm 2012-09-05 21:25:14.000000000 +0200
@@ -1,5 +1,5 @@
@@ -17,10 +17,9 @@ my %forbidden = (%keywords, %forced_into_main); -my BEGIN { Inline Patch--- blead/dist/constant/t/constant.t 2009-12-28 13:04:37.000000000 +0100
+++ blead/dist/constant/t/constant.t 2012-09-04 11:17:30.000000000 +0200
@@ -167,7 +167,6 @@
##### Thank you very much. |
From @bulk88On Mon Jan 14 16:24:44 2013, jkeenan wrote:
Probably not :-( What is the technical question regarding the changes? I ask, what used To support old Perls, I personally use BEGIN block constants and -- |
From @iabynOn Mon, Jan 14, 2013 at 04:24:45PM -0800, James E Keenan via RT wrote:
My understanding is that previous change(s) to constant.pm broke backwards The other alternative is to restore 5.6.x compatibility. However, since Bear in mind that we're talking about support for a 10-year old version of -- |
From @maddingueDave Mitchell wrote:
Yes, it is exactly this. Knowing that porters' time is limited, and given that all the recent changes to constant.pm were to improve its Unicode support, I thought it was better to remove what was left of 5.6-isms.
I remember trying to fix the module for 5.6, but was unable to do so, for the reasons previously exposed.
And the need to upgrade from their perfectly working constant.pm included with their distribution is quite low. -- Close the world, txEn eht nepO. |
1 similar comment
From @maddingueDave Mitchell wrote:
Yes, it is exactly this. Knowing that porters' time is limited, and given that all the recent changes to constant.pm were to improve its Unicode support, I thought it was better to remove what was left of 5.6-isms.
I remember trying to fix the module for 5.6, but was unable to do so, for the reasons previously exposed.
And the need to upgrade from their perfectly working constant.pm included with their distribution is quite low. -- Close the world, txEn eht nepO. |
From @jkeenanOn Fri Jan 18 12:11:03 2013, Maddingue_ wrote:
I extracted the remaining patch submission from Maddingue's post, bumped Closing ticket. Thank you very much. |
@jkeenan - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#114770 (status was 'resolved')
Searchable as RT114770$
The text was updated successfully, but these errors were encountered: