Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building nqp 2012.02 on NetBSD #2657

Closed
p6rt opened this issue Feb 29, 2012 · 4 comments
Closed

Error building nqp 2012.02 on NetBSD #2657

p6rt opened this issue Feb 29, 2012 · 4 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Feb 29, 2012

Migrated from rt.perl.org#111426 (status was 'resolved')

Searchable as RT111426$

@p6rt
Copy link
Author

p6rt commented Feb 29, 2012

From smallm@panix.com

I got this error building rakudo star 2012.01 and again with the latest
nqp from git on NetBSD 5.1​:


cd 3rdparty/dyncall && BUILD_DIR=. make
make​: no target to make.

make​: stopped in /usr/local/src/nqp/3rdparty/dyncall
*** Error code 2

Stop.
make​: stopped in /usr/local/src/nqp


NetBSD's make (unlike OpenBSD's and FreeBSD's) doesn't look for
BSDmakefile, only makefile and Makefile, so it can't find any targets in
the dyncall directory. The dyncall manual says to use
make -f BSDmakefile for NetBSD. The attached patch does that.

--
Mike Small
smallm@​panix.com

@p6rt
Copy link
Author

p6rt commented Feb 29, 2012

From smallm@panix.com

0001-Fix-build-problem-in-NetBSD.patch
From f1b736029d356c04958b5e24230883a5cfe503af Mon Sep 17 00:00:00 2001
From: Mike Small <smallm@panix.com>
Date: Tue, 28 Feb 2012 23:10:52 -0500
Subject: [PATCH] Fix build problem in NetBSD. NetBSD's make doesn't look for
 BSDmakefile. Dyncall manual says to build with -f
 BSDmakefile. OpenBSD and FreeBSD should be fine as is,
 since their makes do look for BSDmakefile.

---
 Configure.pl |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/Configure.pl b/Configure.pl
index 4eaf937..0fcf2d8 100644
--- a/Configure.pl
+++ b/Configure.pl
@@ -126,7 +126,11 @@ MAIN: {
             $config{'dyncall_build'} = "cd 3rdparty/dyncall && $make BUILD_DIR=. -f GNUmakefile";
         } else {
             system_or_die('cd 3rdparty/dyncall && sh configure');
-            $config{'dyncall_build'} = "cd 3rdparty/dyncall && BUILD_DIR=. $make";
+            if ($^O eq 'netbsd') {
+                $config{'dyncall_build'} = "cd 3rdparty/dyncall && BUILD_DIR=. $make -f BSDmakefile";
+            } else {
+                $config{'dyncall_build'} = "cd 3rdparty/dyncall && BUILD_DIR=. $make";
+            }
         }
     }
 
-- 
1.7.7.2

@p6rt
Copy link
Author

p6rt commented Feb 29, 2012

From @moritz

Thank you very much. I've applied the patch, it will be included in our
next release.

@p6rt
Copy link
Author

p6rt commented Feb 29, 2012

@moritz - Status changed from 'new' to 'resolved'

@p6rt p6rt closed this as completed Feb 29, 2012
@p6rt p6rt added the patch label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant