New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9b0adf19 breaks tests in ext/File-Find/t/ when run in harness #16747
Comments
From @jkeenanI am observing new test failures in File::Find in blead. When ext/File-Find/t/taint.t and ext/File-Find/t/find.t are run within ##### Test Summary Report ../ext/File-Find/t/find.t (Wstat: 4352 Tests: 12 Failed: 1) This is the directory from which the following smoke test report was ##### But if you run either test by itself, each passes. ##### [perl-current] $ cd t;./perl harness ../ext/File-Find/t/taint.t ; cd - They also run fine when each is run within a harness with any other test ##### While the data above is from FreeBSD-11, I also observed this when I suspect the problem arises from this commit: ##### Add more parallelism to t/harness ... because I do not get these errors on the immediately preceding commit. Thank you very much. |
From @jkeenanSummary of my perl5 (revision 5 version 29 subversion 5) configuration: Characteristics of this binary (from libperl): |
From @jkeenanOn Wed, 14 Nov 2018 21:22:07 GMT, jkeenan@pobox.com wrote:
Fixed in blead by commit ed0ccc6. The commit previously cited gives t/harness an internal list of directories whose tests must not be run in parallel. I added ext/File-Find/t to that list. Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
@jkeenan - Status changed from 'open' to 'resolved' |
From @jkeenanOn Wed, 14 Nov 2018 21:32:44 GMT, jkeenan wrote:
Unfortunately, the fix doesn't seem to be working consistently, so I have to re-open this ticket. ##### # Failed test 'able to mkdir: dangling_dir' # Failed test 'able to mkdir: fa' Test Summary Report ../ext/File-Find/t/find.t (Wstat: 512 Tests: 151 Failed: 2) -- |
From @jkeenanSummary of my perl5 (revision 5 version 29 subversion 5) configuration: Characteristics of this binary (from libperl): |
@jkeenan - Status changed from 'resolved' to 'open' |
From @iabynOn Sat, Nov 17, 2018 at 02:18:00PM -0800, James E Keenan via RT wrote:
I've fixed it with the following commit: commit f09dd91 ext/File-Find: support parallel testing M ext/File-Find/t/taint.t -- |
From @jkeenanOn Mon, 19 Nov 2018 14:22:52 GMT, davem wrote:
I'll monitor this ticket for several days, then re-close it. Thanks. -- |
From @karenetheridgeAfter Dave's change, should it be possible to revert ed0ccc6? |
From @jkeenanOn Tue, 20 Nov 2018 18:18:37 GMT, ether wrote:
I wouldn't object to it; I have no strong attachment to that commit. But I don't see that it's necessary. I don't have enough understanding of the possible ramifications of 'git revert' to object. Thank you very much. -- |
From @khwilliamsonOn 11/20/18 11:58 AM, James E Keenan via RT wrote:
Dave's change included the reversion |
From @jkeenanOn Mon, 19 Nov 2018 23:16:28 GMT, jkeenan wrote:
No further problems reported; closing ticket. |
@jkeenan - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been Perl 5.30.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#133658 (status was 'resolved')
Searchable as RT133658$
The text was updated successfully, but these errors were encountered: