New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time::HiRes: macOS checks for both futimes() and utimensat(). #16354
Comments
From @doughera88Created by @doughera88after commit c9412ef, compilation on cc -c -fno-common -DPERL_DARWIN -mmacosx-version-min=10.13 This is fixed in the attached patch, which uses the same check for both This mattered on Mac OS X High Sierra 10.13.2 with Apple LLVM version I'd appreciate confirmation that it doesn't break for others. (perl -V info below is irrelevant, from a different machine.) -- Perl Info
|
From @doughera88Inline Patchdiff --git a/dist/Time-HiRes/Changes b/dist/Time-HiRes/Changes
index 5328dc0c02..aa4dc4ef36 100644
--- a/dist/Time-HiRes/Changes
+++ b/dist/Time-HiRes/Changes
@@ -1,4 +1,6 @@
Revision history for the Perl extension Time::HiRes.
+1.9751 [2018-01-07]
+ - in macOS (OS X) use same check for both futimens() and utimensat()
1.9750 [2017-12-22]
- update META.yml and META.json for XSLoader instead of DynaLoader
diff --git a/dist/Time-HiRes/HiRes.pm b/dist/Time-HiRes/HiRes.pm
index 8f01b5e679..97412e6861 100644
--- a/dist/Time-HiRes/HiRes.pm
+++ b/dist/Time-HiRes/HiRes.pm
@@ -49,7 +49,7 @@ our @EXPORT_OK = qw (usleep sleep ualarm alarm gettimeofday time tv_interval
stat lstat utime
);
-our $VERSION = '1.9750';
+our $VERSION = '1.9751';
our $XS_VERSION = $VERSION;
$VERSION = eval $VERSION;
diff --git a/dist/Time-HiRes/HiRes.xs b/dist/Time-HiRes/HiRes.xs
index 34c9db5067..06f5f3de0f 100644
--- a/dist/Time-HiRes/HiRes.xs
+++ b/dist/Time-HiRes/HiRes.xs
@@ -947,7 +947,7 @@ static int th_clock_nanosleep(clockid_t clock_id, int flags,
# define FUTIMENS_AVAILABLE 0
#endif
#ifdef HAS_UTIMENSAT
-# ifdef PERL_DARWIN
+# if defined(PERL_DARWIN) && __has_builtin(__builtin_available)
# define UTIMENSAT_AVAILABLE __builtin_available(macOS 10.13, *)
# else
# define UTIMENSAT_AVAILABLE 1 |
From @jkeenanOn Tue, 09 Jan 2018 18:56:29 GMT, doughera wrote:
Andy, does this commit, made earlier today, resolve the problem for you? ##### Update Time-HiRes to CPAN version 1.9752 Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @doughera88On Tue, Jan 09, 2018 at 11:26:29AM -0800, James E Keenan via RT wrote:
Yes it does. Thanks for catching that and following up. My ticket can be closed. Thanks, -- |
From @jkeenanOn Wed, 10 Jan 2018 02:29:28 GMT, doughera wrote:
Closed, as pending release, per OP request. Thank you very much. |
@jkeenan - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#132700 (status was 'resolved')
Searchable as RT132700$
The text was updated successfully, but these errors were encountered: