New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t/op/pack.t fails two tests in GCC "long doubles" builds on Windows #16265
Comments
From @steve-m-hayCreated by @steve-m-hayAs noted in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=123113#txn-1317316 C:\Dev\Git\perl\t>.\perl harness op\pack.t These failures are being recorded here in a separate ticket so that the earlier Perl Info
|
From @sisyphus
Just attaching the simple patch to pack.t that fixes the bug. Steve, could you apply it please ? (Then *both* tickets can be closed ;-) Cheers, |
From @sisyphuspack.t.patch--- pack.t_orig 2017-10-21 23:32:24 +1100
+++ pack.t 2017-10-21 23:34:37 +1100
@@ -1414,7 +1414,7 @@
my @b = unpack "$t X[$t] $t", $p; # Extract, step back, extract again
is(scalar @b, 2 * scalar @a);
$b = "@b";
- $b =~ s/(?:17000+|16999+)\d+(e-45) /17$1 /gi; # stringification is gamble
+ $b =~ s/(?:17000+|16999+)\d+(e-0?45) /17$1 /gi; # stringification is gamble
is($b, "@a @a");
use warnings qw(NONFATAL all);;
@@ -1427,7 +1427,7 @@
is($warning, undef);
is(scalar @b, scalar @a);
$b = "@b";
- $b =~ s/(?:17000+|16999+)\d+(e-45) /17$1 /gi; # stringification is gamble
+ $b =~ s/(?:17000+|16999+)\d+(e-0?45) /17$1 /gi; # stringification is gamble
is($b, "@a");
} |
The RT System itself - Status changed from 'new' to 'open' |
From @steve-m-hayOn Tue, 21 Nov 2017 13:49:10 -0800, sisyphus wrote:
Great! Thanks for the quick fix! Applied in commit 0e45f48. |
@steve-m-hay - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#132479 (status was 'resolved')
Searchable as RT132479$
The text was updated successfully, but these errors were encountered: