New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Net::Ping 2.61 test failures #16211
Comments
From mhasch-cpanbugs@cozap.comCreated by mhasch-cpanbugs@cozap.comAs of version 2.61, the Net::Ping test suite makes assumptions While replacing the RFC 1918 address by an RFC 5737 address Interestingly, some tests against "known" internet hosts are Even better though would be a test strategy aiming for code If nothing else, at least provide an opt-out configuration Regards, Perl Info
|
From @jkeenanOn Fri, 27 Oct 2017 09:52:32 GMT, mhasch-cpanbugs@cozap.com wrote:
For the record, I note that Net::Ping tests using 172.29.249.249 were introduced long before 2.61. They date at least to commit f569508 in October 2002.
-- |
The RT System itself - Status changed from 'new' to 'open' |
From mhasch-p5p@cozap.comOn Fri, 27 Oct 2017 02:52:32 -0700, I wrote:
Here is a patch introducing another environment variable, It can be used as a workaround to avoid test failures in private -Martin |
From mhasch-p5p@cozap.comNet-Ping-2.61-MHASCH-01.patchdiff -Nrup Net-Ping-2.61.orig/t/190_alarm.t Net-Ping-2.61/t/190_alarm.t
--- Net-Ping-2.61.orig/t/190_alarm.t 2016-09-15 10:57:50.000000000 +0200
+++ Net-Ping-2.61/t/190_alarm.t 2017-10-30 09:02:45.249094171 +0100
@@ -4,7 +4,7 @@
# Based on code written by radu@netsoft.ro (Radu Greab).
BEGIN {
- if ($ENV{PERL_CORE}) {
+ if ($ENV{PERL_CORE} || $ENV{SKIP_NETWORK_TESTS}) {
unless ($ENV{PERL_TEST_Net_Ping}) {
print "1..0 \# Skip: network dependent test\n";
exit;
diff -Nrup Net-Ping-2.61.orig/t/200_ping_tcp.t Net-Ping-2.61/t/200_ping_tcp.t
--- Net-Ping-2.61.orig/t/200_ping_tcp.t 2017-06-05 12:42:30.000000000 +0200
+++ Net-Ping-2.61/t/200_ping_tcp.t 2017-10-30 09:06:22.261097533 +0100
@@ -1,7 +1,7 @@
use strict;
BEGIN {
- if ($ENV{PERL_CORE}) {
+ if ($ENV{PERL_CORE} || $ENV{SKIP_NETWORK_TESTS}) {
unless ($ENV{PERL_TEST_Net_Ping}) {
print "1..0 # Skip: network dependent test\n";
exit;
diff -Nrup Net-Ping-2.61.orig/t/250_ping_hires.t Net-Ping-2.61/t/250_ping_hires.t
--- Net-Ping-2.61.orig/t/250_ping_hires.t 2016-09-15 10:57:50.000000000 +0200
+++ Net-Ping-2.61/t/250_ping_hires.t 2017-10-30 09:06:08.409097317 +0100
@@ -3,7 +3,7 @@
use strict;
BEGIN {
- if ($ENV{PERL_CORE}) {
+ if ($ENV{PERL_CORE} || $ENV{SKIP_NETWORK_TESTS}) {
unless ($ENV{PERL_TEST_Net_Ping}) {
print "1..0 # Skip: network dependent test\n";
exit;
diff -Nrup Net-Ping-2.61.orig/t/300_ping_stream.t Net-Ping-2.61/t/300_ping_stream.t
--- Net-Ping-2.61.orig/t/300_ping_stream.t 2016-09-15 10:57:50.000000000 +0200
+++ Net-Ping-2.61/t/300_ping_stream.t 2017-10-30 09:04:08.345095456 +0100
@@ -1,6 +1,6 @@
use strict;
BEGIN {
- if ($ENV{PERL_CORE}) {
+ if ($ENV{PERL_CORE} || $ENV{SKIP_NETWORK_TESTS}) {
unless ($ENV{PERL_TEST_Net_Ping}) {
print "1..0 # Skip: network dependent test\n";
exit;
diff -Nrup Net-Ping-2.61.orig/t/400_ping_syn.t Net-Ping-2.61/t/400_ping_syn.t
--- Net-Ping-2.61.orig/t/400_ping_syn.t 2017-06-08 07:51:22.000000000 +0200
+++ Net-Ping-2.61/t/400_ping_syn.t 2017-10-30 09:06:51.029097977 +0100
@@ -1,7 +1,7 @@
use strict;
BEGIN {
- if ($ENV{PERL_CORE}) {
+ if ($ENV{PERL_CORE} || $ENV{SKIP_NETWORK_TESTS}) {
unless ($ENV{PERL_TEST_Net_Ping}) {
print "1..0 # Skip: network dependent test\n";
exit;
diff -Nrup Net-Ping-2.61.orig/t/410_syn_host.t Net-Ping-2.61/t/410_syn_host.t
--- Net-Ping-2.61.orig/t/410_syn_host.t 2017-01-19 07:34:30.000000000 +0100
+++ Net-Ping-2.61/t/410_syn_host.t 2017-10-30 09:03:49.161095161 +0100
@@ -2,7 +2,7 @@
use strict;
BEGIN {
- if ($ENV{PERL_CORE}) {
+ if ($ENV{PERL_CORE} || $ENV{SKIP_NETWORK_TESTS}) {
unless ($ENV{PERL_TEST_Net_Ping}) {
print "1..0 # Skip: network dependent test\n";
exit;
|
Migrated from rt.perl.org#132363 (status was 'open')
Searchable as RT132363$
The text was updated successfully, but these errors were encountered: