Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT removing loop construct and confusing last() #6595

Open
p6rt opened this issue Oct 11, 2017 · 3 comments
Open

JIT removing loop construct and confusing last() #6595

p6rt opened this issue Oct 11, 2017 · 3 comments
Labels
Bug exotictest regression Issue did not exist previously testneeded

Comments

@p6rt
Copy link

p6rt commented Oct 11, 2017

Migrated from rt.perl.org#132269 (status was 'open')

Searchable as RT132269$

@p6rt
Copy link
Author

p6rt commented Oct 11, 2017

From @ugexe

Discovered by failing tests in Net​::HTTP xt/* on rakudo/nqp/moar master, the following output shows a compile time error that did not occur in the previous rakudo release (2017.09)​:

$ perl6 -I. xt/500-transport.t
1..4
===SORRY!===
last without loop construct

Besiect output​:
https://gist.github.com/Whateverable/5e61264647a48c145c8bf0d93178087d <https://gist.github.com/Whateverable/5e61264647a48c145c8bf0d93178087d>

Changes brought in by​:
MoarVM/MoarVM@2017.09.1-62-g89ca8eb...2017.09.1-553-ga4fef0b <MoarVM/MoarVM@2017.09.1-62-g89ca8eb...2017.09.1-553-ga4fef0b>

IRC discussion​:
https://irclog.perlgeek.de/perl6-dev/2017-10-11#i_15286229 <https://irclog.perlgeek.de/perl6-dev/2017-10-11#i_15286229>

Note that I worked around this bug in a recent version bump (0.0.7), so to reproduce you would need to use version 0.0.6 (I was unable to golf this).

Net​::HTTP​:ver("0.0.6")
https://github.com/ugexe/Perl6-Net--HTTP/archive/140b02d56adbb9026fda611e8b03466f49b27205.tar.gz <https://github.com/ugexe/Perl6-Net--HTTP/archive/140b02d56adbb9026fda611e8b03466f49b27205.tar.gz>

Net​::HTTP workaround​:
ugexe/Raku-Net--HTTP@df628c2#diff-50314871012a1cd9a7b0d9310f517607L17

@p6rt
Copy link
Author

p6rt commented Oct 19, 2017

From @AlexDaniel

Alright, so this was fixed, or at least Committable is sure that it was​: https://gist.github.com/Whateverable/569f4cd48eb7e12e50922035d0d4d94e

According to brrt the fix is in this moarvm commit​: MoarVM/MoarVM@bedc851

I guess we need tests for this, but it's probably non-trivial.

Anyway, 「testneeded」.

On 2017-10-11 09​:11​:01, nlogan@​gmail.com wrote​:

Discovered by failing tests in Net​::HTTP xt/* on rakudo/nqp/moar
master, the following output shows a compile time error that did not
occur in the previous rakudo release (2017.09)​:

$ perl6 -I. xt/500-transport.t
1..4
===SORRY!===
last without loop construct

Besiect output​:
https://gist.github.com/Whateverable/5e61264647a48c145c8bf0d93178087d
<https://gist.github.com/Whateverable/5e61264647a48c145c8bf0d93178087d>

Changes brought in by​:
https://github.com/MoarVM/MoarVM/compare/2017.09.1-62-
g89ca8eb...2017.09.1-553-ga4fef0b
<https://github.com/MoarVM/MoarVM/compare/2017.09.1-62-
g89ca8eb...2017.09.1-553-ga4fef0b>

IRC discussion​:
https://irclog.perlgeek.de/perl6-dev/2017-10-11#i_15286229
<https://irclog.perlgeek.de/perl6-dev/2017-10-11#i_15286229>

Note that I worked around this bug in a recent version bump (0.0.7),
so to reproduce you would need to use version 0.0.6 (I was unable to
golf this).

Net​::HTTP​:ver("0.0.6")
https://github.com/ugexe/Perl6-Net--
HTTP/archive/140b02d56adbb9026fda611e8b03466f49b27205.tar.gz
<https://github.com/ugexe/Perl6-Net--
HTTP/archive/140b02d56adbb9026fda611e8b03466f49b27205.tar.gz>

Net​::HTTP workaround​:
https://github.com/ugexe/Perl6-Net--
HTTP/commit/df628c2e636149c81a648b95f33aff4a523f8e3d#diff-
50314871012a1cd9a7b0d9310f517607L17

@p6rt
Copy link
Author

p6rt commented Oct 19, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt p6rt added Bug exotictest regression Issue did not exist previously testneeded labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug exotictest regression Issue did not exist previously testneeded
Projects
None yet
Development

No branches or pull requests

1 participant