Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair.kv/.keys/.values dies if either the key or the value is Mu #6467

Closed
p6rt opened this issue Aug 26, 2017 · 5 comments
Closed

Pair.kv/.keys/.values dies if either the key or the value is Mu #6467

p6rt opened this issue Aug 26, 2017 · 5 comments
Labels
regression Issue did not exist previously testneeded

Comments

@p6rt
Copy link

p6rt commented Aug 26, 2017

Migrated from rt.perl.org#131962 (status was 'resolved')

Searchable as RT131962$

@p6rt
Copy link
Author

p6rt commented Aug 26, 2017

From @smls

  ➜ say (4 => Mu).kv;
  Type check failed in binding to parameter 'val2';
  expected Any but got Mu (Mu)

  ➜ say ((Mu) => 4).kv;
  Type check failed in binding to parameter 'val1';
  expected Any but got Mu (Mu)

  ➜ say ((Mu) => Mu).kv;
  Type check failed in binding to parameter 'val1';
  expected Any but got Mu (Mu)

`Pair` methods that are affected​:
  .kv
  .keys
  .values

`Pair` methods that NOT are affected​:
  .key
  .value
  .pairs
  .antipairs
  .Str
  .gist
  .perl

bisectable finds that this was broken two weeks ago​:

  https://gist.github.com/Whateverable/03a10377df0b3e0409eaa69330750868

rakudo/rakudo@30584da

@p6rt
Copy link
Author

p6rt commented Aug 26, 2017

From @lizmat

Fixed with a5014fd0855545cc083b3590 , tests needed.

On 26 Aug 2017, at 13​:10, Sam S. (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Sam S.
# Please include the string​: [perl #​131962]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131962 >

➜  say \(4 => Mu\)\.kv;
Type check failed in binding to parameter 'val2';
expected Any but got Mu \(Mu\)

➜  say \(\(Mu\) => 4\)\.kv;
Type check failed in binding to parameter 'val1';
expected Any but got Mu \(Mu\)

➜  say \(\(Mu\) => Mu\)\.kv;
Type check failed in binding to parameter 'val1';
expected Any but got Mu \(Mu\)

`Pair` methods that are affected​:
.kv
.keys
.values

`Pair` methods that NOT are affected​:
.key
.value
.pairs
.antipairs
.Str
.gist
.perl

bisectable finds that this was broken two weeks ago​:

https://gist.github.com/Whateverable/03a10377df0b3e0409eaa69330750868

rakudo/rakudo@30584da

@p6rt
Copy link
Author

p6rt commented Aug 26, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Sep 14, 2017

From @skids

On Sat, 26 Aug 2017 06​:17​:15 -0700, elizabeth wrote​:

Fixed with a5014fd0855545cc083b3590 , tests needed.

On 26 Aug 2017, at 13​:10, Sam S. (via RT) <perl6-bugs-
followup@​perl.org> wrote​:

# New Ticket Created by Sam S.
# Please include the string​: [perl #​131962]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131962 >

➜ say (4 => Mu).kv;
Type check failed in binding to parameter 'val2';
expected Any but got Mu (Mu)

➜ say ((Mu) => 4).kv;
Type check failed in binding to parameter 'val1';
expected Any but got Mu (Mu)

➜ say ((Mu) => Mu).kv;
Type check failed in binding to parameter 'val1';
expected Any but got Mu (Mu)

`Pair` methods that are affected​:
.kv
.keys
.values

`Pair` methods that NOT are affected​:
.key
.value
.pairs
.antipairs
.Str
.gist
.perl

bisectable finds that this was broken two weeks ago​:

https://gist.github.com/Whateverable/03a10377df0b3e0409eaa69330750868

rakudo/rakudo@30584da

Tests added in roast 8fdce37ba, so resolving.

@p6rt p6rt closed this as completed Sep 14, 2017
@p6rt
Copy link
Author

p6rt commented Sep 14, 2017

@skids - Status changed from 'open' to 'resolved'

@p6rt p6rt added regression Issue did not exist previously testneeded labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue did not exist previously testneeded
Projects
None yet
Development

No branches or pull requests

1 participant