Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix.roll doesn't work with fractional weights #6430

Closed
p6rt opened this issue Aug 7, 2017 · 5 comments
Closed

Mix.roll doesn't work with fractional weights #6430

p6rt opened this issue Aug 7, 2017 · 5 comments
Labels
regression Issue did not exist previously testneeded

Comments

@p6rt
Copy link

p6rt commented Aug 7, 2017

Migrated from rt.perl.org#131855 (status was 'resolved')

Searchable as RT131855$

@p6rt
Copy link
Author

p6rt commented Aug 7, 2017

From @b2gills

  > Mix( 'a' => 0.3 ).roll

  Type check failed in binding; expected Int but got Rat (0.3)
  in block <unit> at <unknown file> line 1

This worked prior to `Add R​:Q.MIX-ROLL, make Mix.roll() about 2.5x as fast`[1]

[1] rakudo/rakudo@a2602b9

@p6rt
Copy link
Author

p6rt commented Aug 7, 2017

From @lizmat

Oops. Caught by a copy-pasto. Fixed with a91ad2da854831a7a38c1d , tests needed.

On 7 Aug 2017, at 20​:59, Brad Gilbert (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Brad Gilbert
# Please include the string​: [perl #​131855]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131855 >

Mix( 'a' => 0.3 ).roll

Type check failed in binding; expected Int but got Rat (0.3)
in block <unit> at <unknown file> line 1

This worked prior to `Add R​:Q.MIX-ROLL, make Mix.roll() about 2.5x as fast`[1]

[1] rakudo/rakudo@a2602b9

@p6rt
Copy link
Author

p6rt commented Aug 7, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Oct 13, 2017

From @zoffixznet

Tests Raku/roast@522e3da803

@p6rt p6rt closed this as completed Oct 13, 2017
@p6rt
Copy link
Author

p6rt commented Oct 13, 2017

@zoffixznet - Status changed from 'open' to 'resolved'

@p6rt p6rt added regression Issue did not exist previously testneeded labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue did not exist previously testneeded
Projects
None yet
Development

No branches or pull requests

1 participant