Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instructions on how to patch Configure unclear #16062

Open
p5pRT opened this issue Jul 2, 2017 · 3 comments
Open

instructions on how to patch Configure unclear #16062

p5pRT opened this issue Jul 2, 2017 · 3 comments
Labels
documentation metaconfig type-configure

Comments

@p5pRT
Copy link

p5pRT commented Jul 2, 2017

Migrated from rt.perl.org#131688 (status was 'open')

Searchable as RT131688$
@p5pRT
Copy link
Author

p5pRT commented Jul 2, 2017

From @mauke

Created by @mauke

A comment at the beginning of Configure says​:

# Though this script was generated by metaconfig from metaunits, it is
# OK to send patches against Configure itself. It's up to the Configure
# pumpkin to backport the patch to the metaunits if it is accepted.
# For more information on patching Configure, see pod/perlhack.pod

But pod/perlhack.pod says nothing about patching Configure.

- What does it mean to "send patches"? (Attach them to a bug ticket? Mail them
  to the perl5-porters list? Commit them straight to blead?)
- Who is the Configure pumpkin? (Tux?)

Perl Info 

Flags:
    category=docs
    severity=low

Site configuration information for perl 5.26.0:

Configured by mauke at Tue May 30 23:06:36 CEST 2017.

Summary of my perl5 (revision 5 version 26 subversion 0) configuration:
   
  Platform:
    osname=linux
    osvers=4.10.11-1-arch
    archname=i686-linux
    uname='linux simplicio 4.10.11-1-arch #1 smp preempt tue apr 18 09:00:04 cest 2017 i686 gnulinux '
    config_args=''
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=undef
    use64bitall=undef
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
    optimize='-O2 -march=native'
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='7.1.1 20170516'
    gccosandvers=''
    intsize=4
    longsize=4
    ptrsize=4
    doublesize=8
    byteorder=1234
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=12
    longdblkind=3
    ivtype='long'
    ivsize=4
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=4
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags ='-fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/i686-pc-linux-gnu/7.1.1/include-fixed /usr/lib /lib
    libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.25.so
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.25'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -march=native -L/usr/local/lib -fstack-protector-strong'



@INC for perl 5.26.0:
    /home/mauke/usr/lib/perl5/site_perl/5.26.0/i686-linux
    /home/mauke/usr/lib/perl5/site_perl/5.26.0
    /home/mauke/usr/lib/perl5/5.26.0/i686-linux
    /home/mauke/usr/lib/perl5/5.26.0


Environment for perl 5.26.0:
    HOME=/home/mauke
    LANG=en_US.UTF-8
    LANGUAGE=en_US
    LC_COLLATE=C
    LC_MONETARY=de_DE.UTF-8
    LC_TIME=de_DE.UTF-8
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/mauke/perl5/perlbrew/bin:/home/mauke/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl
    PERLBREW_BASHRC_VERSION=0.73
    PERLBREW_HOME=/home/mauke/.perlbrew
    PERLBREW_ROOT=/home/mauke/perl5/perlbrew
    PERL_BADLANG (unset)
    PERL_UNICODE=SAL
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Jul 2, 2017

From @Tux

On Sun, 02 Jul 2017 00​:14​:57 -0700, "l.mai@​web.de (via RT)"
<perlbug-followup@​perl.org> wrote​:

A comment at the beginning of Configure says​:

# Though this script was generated by metaconfig from metaunits, it is
# OK to send patches against Configure itself. It's up to the Configure
# pumpkin to backport the patch to the metaunits if it is accepted.
# For more information on patching Configure, see pod/perlhack.pod

But pod/perlhack.pod says nothing about patching Configure.

Good point. If docs are added there, I'd like to have a statement like

"Patching Configure should be a last resort, as it is shared between
most supported architectures and Operating Systems. In most cases,
patching hints/your-os.sh is sufficient and a *lot* easier and less
error-prone."

- What does it mean to "send patches"? (
* Attach them to a bug ticket?

Acceptable

Mail them to the perl5-porters list?

Acceptable

Commit them straight to blead?

Acceptable on the condition that I (or my co-maints) am/are notified

- Who is the Configure pumpkin? (Tux?)

At this moment, yes. But there is at least arc to help me​: he knows
about all steps involved and has the same rights I have.

--
H.Merijn Brand http​://tux.nl Perl Monger http​://amsterdam.pm.org/
using perl5.00307 .. 5.27 porting perl5 on HP-UX, AIX, and openSUSE
http​://mirrors.develooper.com/hpux/ http​://www.test-smoke.org/
http​://qa.perl.org http​://www.goldmark.org/jeff/stupid-disclaimers/

@p5pRT
Copy link
Author

p5pRT commented Jul 2, 2017

The RT System itself - Status changed from 'new' to 'open'

@toddr toddr mentioned this issue Oct 28, 2019
Open
@xenu xenu removed the affects-5.26 label Nov 19, 2021
@xenu xenu removed the Severity Low label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation metaconfig type-configure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@toddr @xenu @p5pRT