New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoLoader implies suitability for constants, fails to mention inlining incompatibility [patch] #15866
Comments
From @wchristianCreated by @wchristianThe problem is with this section of the AutoLoader documentation: http://perldoc.perl.org/AutoLoader.html#Overriding-*AutoLoader*'s-AUTOLOAD-Subroutine It describes how to do certain things with the module, but choses to make its example with constants, despite the fact that AutoLoader cannot create inlinable constant functions, due to always executing after compile time. The attached patch adds a note of this limitation. Perl Info
|
From @wchristian0001-AutoLoader-note-incompatibility-with-constant-inlini.patchFrom ebaa5bca18e0e78b78277f54cad889c2e3876555 Mon Sep 17 00:00:00 2001
From: Christian Walde <walde.christian@googlemail.com>
Date: Tue, 7 Feb 2017 19:23:05 +0100
Subject: [PATCH] AutoLoader: note incompatibility with constant inlining
---
cpan/AutoLoader/lib/AutoLoader.pm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/cpan/AutoLoader/lib/AutoLoader.pm b/cpan/AutoLoader/lib/AutoLoader.pm
index 5546f9e..398fc0b 100644
--- a/cpan/AutoLoader/lib/AutoLoader.pm
+++ b/cpan/AutoLoader/lib/AutoLoader.pm
@@ -305,6 +305,11 @@ If any module's own AUTOLOAD subroutine has no need to fallback to the
AutoLoader's AUTOLOAD subroutine (because it doesn't have any AutoSplit
subroutines), then that module should not use B<AutoLoader> at all.
+Note: Despite the example above talking about constants, there are
+currently no circumstances under which a function loaded by AutoLoader
+can be inlined as a constant. If you desire to make use of this
+optimization AutoLoader can not be used.
+
=head2 Package Lexicals
Package lexicals declared with C<my> in the main block of a package
--
2.10.1.windows.1
|
From @jkeenanOn Tue, 07 Feb 2017 18:31:35 GMT, walde.christian@gmail.com wrote:
We have a bit of a technical problem here. The AutoLoader library is found within the core distribution under 'cpan/Autoloader/'. This suggests that it is maintained upstream on cpan rather than in blead. This impression is confirmed by its entry in Porting/Maintainers.pl. However, when I go to https://rt.cpan.org//Dist/Display.html?Queue=AutoLoader and click on "Preferred Bug Tracker," I'm taken back to rt.perl.org -- which implies that it's maintained in core. So we need to clarify where this bug report should go. copying the maintainer. Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Wed, 08 Feb 2017 18:30:09 GMT, jkeenan wrote:
I have not heard back from the listed maintainer (SMUELLER). pumpking: guidance requested. Thank you very much. -- |
From @xsawyerxOn 02/26/2017 11:41 PM, James E Keenan via RT wrote:
SMUELLER is sometimes overflowing in email. Let's give it another day or |
From @xsawyerxOn Mon, 27 Feb 2017 06:06:29 -0800, xsawyerx@gmail.com wrote:
Now knowing the maintainer is overwhelmed with other issues at the moment, I think we need to decide whether to move this into core or not without him. He's fine with it. The benefit of bringing it into core is that it's widely used enough that I would consider crucial, and will benefit from having a net of developers, which is why I'm leaning towards that. |
@xsawyerx what did you decide? |
We should move |
On 4/10/20 4:54 AM, Sawyer X wrote:
We should move |AutoLoader| to core.
When?
…
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15866 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA2DHZ5NMBKWDIVT526AOLRL33FDANCNFSM4KU5ZP2A>.
|
We're in code freeze. Hence, my recommendation: 5.33.1. |
I've created #17707 to track transfer of AutoLoader to Thank you very much. |
To get back to the original subject of this ticket ... Is the following patch to AutoLoader.pm's documentation valid?
|
Migrated from rt.perl.org#130735 (status was 'open')
Searchable as RT130735$
The text was updated successfully, but these errors were encountered: