New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.21.8-322-gd27f4b9 breaks ETHER/Devel-Declare-0.006017.tar.gz #14521
Comments
From @andkbisect commit d27f4b9 [perl #123712] Don’t check sub_inwhat sample report http://www.cpantesters.org/cpan/report/cd9dfae6-b5e4-11e4-8cc6-8f928971dd2f perl -V Summary of my perl5 (revision 5 version 21 subversion 9) configuration: Characteristics of this binary (from libperl): -- |
From @wolfsageOn Tue Feb 17 19:47:06 2015, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
Possible patch attached. Review would be good. Makes the dist pass tests on 5.21.9 (where it was broken), also tested on 5.21.4, 5.14.4, 5.8.8. -- Matthew Horsfall (alh) |
From @wolfsagedont_use_sub_inwhat.patch--- Devel-Declare-0.006017/stolen_chunk_of_toke.c 2015-03-23 15:28:33.230055110 -0400
+++ Devel-Declare-0.006017-patched/stolen_chunk_of_toke.c 2015-03-23 15:27:48.402102674 -0400
@@ -342,7 +342,7 @@
* of the buffer, we're not reading from a source filter, and
* we're in normal lexing mode
*/
- if (s < PL_bufend || !PL_rsfp || PL_sublex_info.sub_inwhat ||
+ if (s < PL_bufend || !PL_rsfp || PL_lex_inwhat ||
PL_lex_state == LEX_FORMLINE)
return s;
|
The RT System itself - Status changed from 'new' to 'open' |
From perl5-porters@perl.orgMatthew Horsfall wrote:
Thank you for beating me to it. I think your patch is exactly what is needed. |
From @wolfsageOn Mon, Mar 23, 2015 at 5:55 PM, <Father@lists-nntp.develooper.com> wrote:
No prob, thanks for the review. I've put the patch in Devel::Declare's RT queue. -- Matthew Horsfall (alh) |
From @karenetheridgeDevel-Declare-0.006018 has been uploaded. many thanks! |
@karenetheridge - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#123865 (status was 'resolved')
Searchable as RT123865$
The text was updated successfully, but these errors were encountered: