New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] Also work around renameat() kernel bug on GNU/kFreeBSD #16756
Comments
From jrtc27@jrtc27.comCreated by jrtc27@jrtc27.com#127663 works around https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222258 Perl Info
|
From jrtc27@jrtc27.com0001-Also-work-around-renameat-kernel-bug-on-GNU-kFreeBSD.patchFrom 62b69e1d626c7b24ecf12c2e56e83d139f750461 Mon Sep 17 00:00:00 2001
From: James Clarke <jrtc27@jrtc27.com>
Date: Mon, 19 Nov 2018 14:25:56 +0000
Subject: [PATCH] Also work around renameat() kernel bug on GNU/kFreeBSD
---
doio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doio.c b/doio.c
index cc15bf9..8d9131c 100644
--- a/doio.c
+++ b/doio.c
@@ -1461,7 +1461,7 @@ Perl_nextargv(pTHX_ GV *gv, bool nomagicopen)
}
#ifdef ARGV_USE_ATFUNCTIONS
-# if defined(__FreeBSD__)
+# if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
/* FreeBSD 11 renameat() mis-behaves strangely with absolute paths in cases where the
* equivalent rename() succeeds
@@ -1481,7 +1481,7 @@ S_my_renameat(int olddfd, const char *oldpath, int newdfd, const char *newpath)
# else
# define S_my_renameat(dh1, pv1, dh2, pv2) renameat((dh1), (pv1), (dh2), (pv2))
-# endif /* if defined(__FreeBSD__) */
+# endif /* if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) */
#endif
static bool
--
2.5.1
|
From @tonycozOn Mon, 19 Nov 2018 07:18:49 -0800, jrtc27@jrtc27.com wrote:
Thanks, applied as a3c63a9. Added you to AUTHORS in 72f8047. Tony |
The RT System itself - Status changed from 'new' to 'open' |
@tonycoz - Status changed from 'open' to 'pending release' |
From @TuxOn Mon, 19 Nov 2018 07:18:50 -0800, <perlbug-followup@perl.org> wrote:
Looks valid to me -- |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been Perl 5.30.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#133668 (status was 'resolved')
Searchable as RT133668$
The text was updated successfully, but these errors were encountered: