New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDBM_File tests fail with gdbm 1.15 #16594
Comments
From bluewind@xinu.atCreated by bluewind@xinu.atThis is a bug report for perl from bluewind@xinu.at, ----------------------------------------------------------------- # Failed test 'Trapped error when attempting to write to knobbled GDBM_File' # Failed test 'expected error message from GDBM_File' The test passed just fine with gdbm 1.14.1. It appears that 1.15 now properly If you need more information, feel free to contact me. Florian Perl Info
|
From @shlomifHi all! The gdbm tests fail in both perl-5.26.2 and 5.28.0-RC4 on Mageia 7 x86-64 with # Failed test 'Trapped error when attempting to write to knobbled GDBM_File' # Failed test 'expected error message from GDBM_File' Test Summary Report ../ext/GDBM_File/t/fatal.t (Wstat: 512 I am building perl using perlbrew. All other tests succeed. Thanks to Jim Keenan. Shlomi Fish http://www.shlomifish.org/ There are at least 137 Larry Walls in the U.S., but only one that matters. |
From @jkeenanOn Sat, 23 Jun 2018 08:05:44 GMT, shlomif@shlomifish.org wrote:
See https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133295. Are you able to identify the version of GDBM which you have installed? -- |
The RT System itself - Status changed from 'new' to 'open' |
From @shlomifOn Sat, 23 Jun 2018 10:24:15 -0700
Yes, version 1.15: shlomif@telaviv1:~$ rpm -qa | grep -i gdbm I mentioned that. -- Shlomi Fish http://www.shlomifish.org/ But if you’re writing [open source software] for the world, you have to listen Please reply to list if it's a mailing list post - http://shlom.in/reply . |
1 similar comment
From @shlomifOn Sat, 23 Jun 2018 10:24:15 -0700
Yes, version 1.15: shlomif@telaviv1:~$ rpm -qa | grep -i gdbm I mentioned that. -- Shlomi Fish http://www.shlomifish.org/ But if you’re writing [open source software] for the world, you have to listen Please reply to list if it's a mailing list post - http://shlom.in/reply . |
From @jkeenanI'm merging this ticket into https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133295, as I have confirmed the error and 133295 was the first to be filed. -- |
From @jkeenanOn Sat, 23 Jun 2018 18:12:33 GMT, jkeenan wrote:
I was able to confirm this bug on a Linux machine where, it appears, I did not previously have GDBM installed. I first installed libgdbm3 as follows: ##### That appears to have installed only a rather old version of the library: ##### I then downloaded version 1.15.0 of gdbm from https://ftpmirror.gnu.org/gdbm/gdbm-1.15.tar.gz. I configured it to install in a non-standard location and did so. ##### I then configured and built blead (commit 1efe078) as follows: ##### I then ran the test file in question. ##### ok 1 - use GDBM_File; Test Summary Report ../ext/GDBM_File/t/fatal.t (Wstat: 512 Tests: 8 Failed: 2) -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Sat, 23 Jun 2018 18:24:13 GMT, jkeenan wrote:
cc-ing the author of the failing tests. Nicholas, can you have a look? I suspect that going forward our GDBM module will have to expose the MAJOR/MINOR/PATCH version of the underlying gdbm library. Thank you very much. -- |
From @ppisarOn 2018-06-22, "bluewind@xinu.at (via RT)" <perlbug-followup@perl.org> wrote:
1.15 no longer crashes but it also seems not reporting errors properly. The Perl test lets gdbm library to open a database file, then Perl Old gdbm crashes. New gdbm returns success, although strace reveals a write into the file close(3) = 0 The Perl test does "$h{Perl} = 'Rules'" under eval, the tied hash store Debugger shows gdbm_store() returns success (0). Thus I believe this is a bug in gdbm C library. Although I cannot find -- Petr |
From @ppisarOn 2018-06-26, Petr Pisar <ppisar@redhat.com> wrote:
My 1.15 uses memory mapped I/O. gdbm_store() succeeds because the The whole eval-ed code is: $h{Perl} = 'Rules'; Store succeeds. The untie calls gdbm_DESTROY() that calls gdbm_close() So at the end it looks like a bug in gdbm interface that it cannot I'm not sure why msync() did not fail or while the process did not -- Petr |
From @ppisarOn 2018-06-26, Petr Pisar <ppisar@redhat.com> wrote:
I searched why the Perl test exist at all. It was added with this commit: commit ceab701 GDBM_File is meant to croak() if the gdbm library has a fatal error. So the reason for the test is to check gdbm fatal errors are properly Provided the only place gdbm uses these fatal errors is when storing -- Petr |
From @ppisarOn 2018-06-26, Petr Pisar <ppisar@redhat.com> wrote:
GNU dbm bug report <https://puszcza.gnu.org.ua/bugs/index.php?399>. -- Petr |
From @graygnuorgOn Fri, 29 Jun 2018 03:16:27 -0700, ppisar wrote:
Fixed by http://git.gnu.org.ua/cgit/gdbm.git/commit/?id=030e685eb9df82f63d73a1bf206da84b7aa52374. The change will appear in next release of GDBM. |
From [Unknown Contact. See original ticket]On Fri, 29 Jun 2018 03:16:27 -0700, ppisar wrote:
Fixed by http://git.gnu.org.ua/cgit/gdbm.git/commit/?id=030e685eb9df82f63d73a1bf206da84b7aa52374. The change will appear in next release of GDBM. |
From @graygnuorgHere's the proposed change to the module: http://git.gnu.org.ua/cgit/gdbm/GDBM_File.git It improves error handling and adds interfaces to the new functions that appeared in the recent releases of GDBM. It has been tested with GDBM 1.16.90 (current git HEAD) and 1.8.3 (the oldest one that could be in use, as far as I can tell). |
From [Unknown Contact. See original ticket]Here's the proposed change to the module: http://git.gnu.org.ua/cgit/gdbm/GDBM_File.git It improves error handling and adds interfaces to the new functions that appeared in the recent releases of GDBM. It has been tested with GDBM 1.16.90 (current git HEAD) and 1.8.3 (the oldest one that could be in use, as far as I can tell). |
From @graygnuorgFixed in GDBM version 1.17 |
From bluewind@xinu.atAm Mon, 30 Jul 2018 14:48:02 -0700, gray@gnu.org schrieb:
I still seem to get the same test failures even with gdbm 1.17. Do the tests (perl 5.28.0 release tarball here) pass for you with gdbm 1.17? |
From cartas@frederico.meOn Wed, 08 Aug 2018 04:54:36 -0700, bluewind@xinu.at wrote:
I am just reporting that from 5.24, 5.26 and 5.28 I can reproduce the same error even with gdbm 1.7.1 |
From @shlomifHi, On Wed, 08 Aug 2018 07:03:03 -0700
I am getting the test failure here as well with perlbrew and -- Shlomi Fish http://www.shlomifish.org/ For every A, Chuck Norris is both A and not-A. Please reply to list if it's a mailing list post - http://shlom.in/reply . |
From @jkeenanOn Fri, 10 Aug 2018 10:46:13 GMT, shlomif@shlomifish.org wrote:
I get the same failures in ext/GDBM_File/t/fatal.t on FreeBSD-13 with gdbm 1.18.1 on perl 5 blead. ##### $ pkg info | grep -i gdbm $ ./perl -Ilib -v | head -2 | tail -1 $ ./perl -Ilib -V:libs -V:config_args $ cd t;./perl harness ../ext/GDBM_File/t/*.t; cd - # Failed test 'expected error message from GDBM_File' Test Summary Report ../ext/GDBM_File/t/fatal.t (Wstat: 512 Tests: 8 Failed: 2) I notice also that these failures are endemic in certain of our smoke-testing reports. See http://perl5.test-smoke.org/submatrix?test=../ext/GDBM_File/t/fatal.t. The reports at that URL from FreeBSD-13 are, I believe, from a VM very similar to my own. The other reports are from Arch Linux smoke testing rigs. -- |
From @shlomifOn Tue, 20 Nov 2018 12:10:58 -0800, jkeenan wrote:
"perlbrew install perl-5.29.5" fails on mageia v7 x64 with lib64gdbm6-1.18.1-1.mga7 |
From @eserteThis is a bug report for perl from slaven@rezic.de, The test suite of perl 5.26.3 fails on a freebsd 12 system with gdbm-1.18.1 ../ext/GDBM_File/t/fatal.t ......................................... 1/8 # Failed test 'expected error message from GDBM_File' The same problem happens also with perl 5.28.1 on a freebsd 13 system, Flags: Site configuration information for perl 5.26.3: Configured by eserte at Thu Nov 29 20:10:39 UTC 2018. Summary of my perl5 (revision 5 version 26 subversion 3) configuration: @INC for perl 5.26.3: Environment for perl 5.26.3: |
From @eserteDana Thu, 29 Nov 2018 12:57:43 -0800, slaven@rezic.de reče:
Same failure on a debian/buster system with perl 5.28.1. |
From @jkeenan3rd time this has been reported; merging into first ticket. Any GDBM experts out there? -- |
From @jkeenanOn Fri, 30 Nov 2018 02:46:45 GMT, jkeenan wrote:
Let's watch smoke-test reports to see if this commit from Dave Mitchell today addresses the problem: https://perl5.git.perl.org/perl.git/commitdiff/0d9e812d -- |
From @bingosOn Fri, Dec 14, 2018 at 03:58:07PM -0800, James E Keenan via RT wrote:
I have just tested blead on the FreeBSD machine I got errors for that test FreeBSD ********* 11.2-RELEASE-p2 FreeBSD 11.2-RELEASE-p2 #0: Tue Aug 14 21:45:40 UTC 2018 amd64 All tests successful. $ ./perl -v This is perl 5, version 29, subversion 6 (v5.29.6 (v5.29.5-110-g0d9e812de5)) built for amd64-freebsd Thumbs up. --
|
From @shlomifOn Sat, 15 Dec 2018 03:16:07 -0800
Latest blead passes the tests on mageia linux v7 x86-64 too.
-- Shlomi Fish http://www.shlomifish.org/ Major Kira: Well, duh! The prophets spoke of several of The Invisible’s Please reply to list if it's a mailing list post - http://shlom.in/reply . |
From @jkeenanOn Sat, 15 Dec 2018 14:51:10 GMT, shlomif@shlomifish.org wrote:
I was able to get a PASS on Linux with the more recent version of gdbm and on FreeBSD-13. Smoke-testing on FreeBSD-13 is also showing PASS, e.g., http://perl5.test-smoke.org/report/76136. Resolving ticket. -- |
@jkeenan - Status changed from 'open' to 'pending release' |
From @eserteDana Sun, 16 Dec 2018 06:15:23 -0800, jkeenan reče:
However, ext/GDBM_File/t/fatal.t in perl 5.28.2-RC1 still fails on my FreeBSD 12 and 13 systems. Regards, |
From @shlomifOn Fri, 05 Apr 2019 23:40:31 -0700
I am getting failure on -RC1 on mageia linux v7 too.
-- Shlomi Fish http://www.shlomifish.org/ “The best time to plant a tree was 20 years ago. The second best time is now.” Please reply to list if it's a mailing list post - http://shlom.in/reply . |
From @iabynOn Fri, Apr 05, 2019 at 11:40:31PM -0700, slaven@rezic.de via RT wrote:
Cherry-picking this commit fixes it: commit 0d9e812 ext/GDBM_File/t/fatal.t: handle non-fatality -- |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been Perl 5.30.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#133295 (status was 'resolved')
Searchable as RT133295$
The text was updated successfully, but these errors were encountered: