New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor doc bug in pod/perlop.pod #16267
Comments
From slanning@cpan.orgCreated by slanning@cpan.orgCommit 33be4c6 added a line in pod/perlop.pod The last four modifiers listed above, added in Perl 5.14, Since the "n" line was added, that paragraph no longer makes sense. Thanks, Perl Info
|
From @jkeenanOn Tue, 21 Nov 2017 14:50:17 GMT, slanning@cpan.org wrote:
Would you be able to prepare a patch to that effect? That would make it easier for us to evaluate your recommendation. (Guidance for preparing a patch can be found with 'perldoc perlhack' and similar.) Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From slanning@cpan.orgOn Wed, 22 Nov 2017 09:48:06 -0800, jkeenan wrote:
Attached. |
From slanning@cpan.org0001-POD-fix-for-perlop.patchFrom 3e98b4bd213de0e9eeea4b9d55a0c8d9da4922ff Mon Sep 17 00:00:00 2001
From: Scott Lanning <slanning@cpan.org>
Date: Thu, 23 Nov 2017 19:33:13 +0100
Subject: [PATCH] POD fix for perlop
Commit 33be4c6111bea619c1662 added a line in pod/perlop.pod
for a new Non-capture mode modifier to qr//.
The 2nd paragraph below that line said:
The last four modifiers listed above, added in Perl 5.14,
control the character set rules, but C</a> is the only one
you are likely to want to specify explicitly; the other three
are selected automatically by various pragmas.
Since the "n" line was added, that paragraph no longer makes sense.
I changed it to refer to the modifiers explicitly instead of
the last four lines. (An alternative would be to move the "n" line
above the other four.)
---
pod/perlop.pod | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git pod/perlop.pod pod/perlop.pod
index a4de37d561..16f235f2c3 100644
--- pod/perlop.pod
+++ pod/perlop.pod
@@ -1767,7 +1767,7 @@ of C<"msixpluadn"> will be propagated appropriately. The effect that the
C</o> modifier has is not propagated, being restricted to those patterns
explicitly using it.
-The last four modifiers listed above, added in Perl 5.14,
+The C</a>, C</d>, C</l>, and C</u> modifiers (added in Perl 5.14)
control the character set rules, but C</a> is the only one you are likely
to want to specify explicitly; the other three are selected
automatically by various pragmas.
--
2.14.1
|
From @khwilliamsonThanks, applied as d6c0a90 |
@khwilliamson - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#132481 (status was 'resolved')
Searchable as RT132481$
The text was updated successfully, but these errors were encountered: