Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure script doesn't recognize GCC 6 or 7 #16089

Closed
p5pRT opened this issue Jul 27, 2017 · 7 comments
Closed

Configure script doesn't recognize GCC 6 or 7 #16089

p5pRT opened this issue Jul 27, 2017 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented Jul 27, 2017

Migrated from rt.perl.org#131809 (status was 'resolved')

Searchable as RT131809$

@p5pRT
Copy link
Author

p5pRT commented Jul 27, 2017

From kbrown@cornell.edu

When testing whether to use -D_FORTIFY_SOURCE, the Configure script only
looks for GCC 4 or 5 and otherwise reports "You seem not to have gcc 4.*
or later, not adding -D_FORTIFY_SOURCE." The trivial fix is attached.

Ken


Flags​:
  category=core
  severity=low


Site configuration information for perl 5.26.0​:

Configured by kbrown at Wed Jul 19 09​:30​:20 EDT 2017.

Summary of my perl5 (revision 5 version 26 subversion 0) configuration​:

  Platform​:
  osname=cygwin
  osvers=2.8.3(0.31353)
  archname=x86_64-cygwin-threads-multi
  uname='cygwin_nt-10.0 desktop-new 2.8.3(0.31353) x86_64 cygwin '
  config_args='-des -Dprefix=/usr -Dmksymlinks
-Darchname=x86_64-cygwin-threads -Dlibperl=cygperl5_26.dll -Dcc=gcc
-Dld=g++ -Accflags=-ggdb -O2 -pipe -Wimplicit-function-declaration
-fdebug-prefix-map=/home/kbrown/src/cygperl/perl-5.26.0-2.x86_64/build=/usr/src/debug/perl-5.26.0-2
-fdebug-prefix-map=/home/kbrown/src/cygperl/perl-5.26.0-2.x86_64/src/perl-5.26.0=/usr/src/debug/perl-5.26.0-2
-fwrapv'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='gcc'
  ccflags ='-DPERL_USE_SAFE_PUTENV -D_GNU_SOURCE -U__STRICT_ANSI__
-ggdb -O2 -pipe -Wimplicit-function-declaration
-fdebug-prefix-map=/home/kbrown/src/cygperl/perl-5.26.0-2.x86_64/build=/usr/src/debug/perl-5.26.0-2
-fdebug-prefix-map=/home/kbrown/src/cygperl/perl-5.26.0-2.x86_64/src/perl-5.26.0=/usr/src/debug/perl-5.26.0-2
-fwrapv -fno-strict-aliasing -fstack-protector-strong -D_FORTIFY_SOURCE=2'
  optimize='-O3'
  cppflags='-DPERL_USE_SAFE_PUTENV -D_GNU_SOURCE -U__STRICT_ANSI__
-ggdb -O2 -pipe -Wimplicit-function-declaration
-fdebug-prefix-map=/home/kbrown/src/cygperl/perl-5.26.0-2.x86_64/build=/usr/src/debug/perl-5.26.0-2
-fdebug-prefix-map=/home/kbrown/src/cygperl/perl-5.26.0-2.x86_64/src/perl-5.26.0=/usr/src/debug/perl-5.26.0-2
-fwrapv -fno-strict-aliasing -fstack-protector-strong'
  ccversion=''
  gccversion='5.4.0'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='g++'
  ldflags =' -Wl,--enable-auto-import -Wl,--export-all-symbols
-Wl,--enable-auto-image-base -fstack-protector-strong'
  libpth=/usr/lib
  libs=-lpthread -lgdbm -ldb -ldl -lcrypt -lgdbm_compat
  perllibs=-lpthread -ldl -lcrypt
  libc=/usr/lib/libcygwin.a
  so=dll
  useshrplib=true
  libperl=cygperl5_26.dll
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=dll
  d_dlsymun=undef
  ccdlflags=' '
  cccdlflags=' '
  lddlflags=' --shared -Wl,--enable-auto-import
-Wl,--export-all-symbols -Wl,--enable-auto-image-base
-fstack-protector-strong'


@​INC for perl 5.26.0​:
  /usr/lib/perl5/site_perl/5.26/x86_64-cygwin-threads
  /usr/lib/perl5/site_perl/5.26
  /usr/lib/perl5/vendor_perl/5.26/x86_64-cygwin-threads
  /usr/lib/perl5/vendor_perl/5.26
  /usr/lib/perl5/5.26/x86_64-cygwin-threads
  /usr/lib/perl5/5.26


Environment for perl 5.26.0​:
  HOME=/home/kbrown
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)

PATH=/home/kbrown/bin​:/usr/local/bin​:/usr/bin​:/c/ProgramData/Oracle/Java/javapath​:/c/Program
Files/Common Files/Microsoft Shared/Windows Live​:/c/Program Files
(x86)/Common Files/Microsoft Shared/Windows Live​:/c/Program Files
(x86)/Intel/iCLS Client​:/c/Program Files/Intel/iCLS Client​:/c/Program
Files (x86)/AMD APP/bin/x86_64​:/c/Program Files (x86)/AMD
APP/bin/x86​:/c/WINDOWS/system32​:/c/WINDOWS​:/c/WINDOWS/System32/Wbem​:/c/WINDOWS/System32/WindowsPowerShell/v1.0​:/c/Program
Files (x86)/ATI Technologies/ATI.ACE/Core-Static​:/c/Program Files
(x86)/Windows Live/Shared​:/c/Program Files (x86)/Common
Files/Intuit/QBPOSSDKRuntime​:/c/Program Files (x86)/ATI
Technologies/ATI.ACE/Core-Static​:/c/Users/kbrown/AppData/Local/Microsoft/WindowsApps​:/usr/lib/lapack
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Jul 27, 2017

From kbrown@cornell.edu

0001-Configure-check-for-GCC-6-and-7.patch
From 49534dc34fa62de65a1adc6ef89ba7e5cc323052 Mon Sep 17 00:00:00 2001
From: Ken Brown <kbrown@cornell.edu>
Date: Thu, 27 Jul 2017 11:57:44 -0400
Subject: [PATCH] Configure: check for GCC 6 and 7

---
 Configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Configure b/Configure
index 3259249500..bdcfaf17ef 100755
--- a/Configure
+++ b/Configure
@@ -23612,7 +23612,7 @@ fi
 
 : add -D_FORTIFY_SOURCE if feasible and not already there
 case "$gccversion" in
-[45].*)	case "$optimize$ccflags" in
+[4567].*)	case "$optimize$ccflags" in
 	*-O*)	case "$ccflags$cppsymbols" in
 		*_FORTIFY_SOURCE=*) # Don't add it again.
 			echo "You seem to have -D_FORTIFY_SOURCE already, not adding it." >&4
-- 
2.13.2

@p5pRT
Copy link
Author

p5pRT commented Aug 9, 2017

From @tonycoz

On Thu, 27 Jul 2017 09​:24​:44 -0700, kbrown@​cornell.edu wrote​:

When testing whether to use -D_FORTIFY_SOURCE, the Configure script
only
looks for GCC 4 or 5 and otherwise reports "You seem not to have gcc
4.*
or later, not adding -D_FORTIFY_SOURCE." The trivial fix is attached.

Thanks, applied as b948647.

Tony

@p5pRT
Copy link
Author

p5pRT commented Aug 9, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 9, 2017

@tonycoz - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented Jun 23, 2018

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release yesterday of Perl 5.28.0, this and 185 other issues have been
resolved.

Perl 5.28.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.28.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT
Copy link
Author

p5pRT commented Jun 23, 2018

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant