supply patches to upstream to fix install location #12722
Comments
From @LeontHistorically, dual-life modules have upgraded to the "perl"/"core" Currently, It seems at least these modules fail to do that: Storable The last two didn't show up when grepping (since they don't have a Leon |
From @xdgOn Thu, Jul 26, 2012 at 10:17 AM, Leon Timmermans
I wonder if we should patch EU::MM and M::B to detect dual-life That might be too draconian, as someone might have reasons to install -- David |
|
The RT System itself - Status changed from 'new' to 'open' |
From @LeontOn Thu, Jul 26, 2012 at 5:17 PM, Leon Timmermans
That indeed seems to be the case. PathTools, AutoLoader, SelfLoader, Leon |
From @LeontOn Thu, Jul 26, 2012 at 6:02 PM, Leon Timmermans <fawaka@gmail.com> wrote:
See http://grep.cpan.me/?q=INSTALLDIRS\s*%3D%3E.*perl and Leon |
From @rjbsIt used to be that the search order of `@INC` was perl, then site. If you To work around this, libraries found in both core and CPAN overrode their ...but lots of dual-life libraries have not been updated to install to site as Libraries that are released primarily on CPAN (i.e., "upstream CPAN" libraries) Libraries that are released primarily via the core perl distribution need to In most cases, libraries will be using ExtUtils::MakeMaker. They should end up INSTALLDIRS => ($] < 5.011 ? 'perl' : 'site'), They're broken if they currently just say `INSTALLDIRS => 'perl'` ## Partial List Here are some seemingly broken ones: * CPANPLUS |
From @jkeenanOn Mon Jan 21 08:05:04 2013, rjbs wrote:
Attaching a file which takes the list of libraries provided by rjbs and Note: We should get a better UPSTREAM value for Time-Piece than 'undef'. Thank you very much. |
|
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Mon Jan 21 13:11:49 2013, jkeenan wrote:
Attachment |
From @jkeenanCPANPLUS,cpan |
From @LeontOn Mon, Jan 21, 2013 at 5:05 PM, Ricardo SIGNES
I created that list mostly from distributions in core that contain a Leon |
From @rjbs* James E Keenan via RT <perlbug-followup@perl.org> [2013-01-21T16:11:50]
I've already got something of an open thread with M. Sergeant about Time-Piece, -- |
From @nwc10On Mon, Jan 21, 2013 at 04:27:12PM -0500, Ricardo Signes wrote:
Cool. You're aware that the XS code has forked? And that blead's is portable to all The core has more platform coverage than CPAN testers. Nicholas Clark |
From @rjbs* Nicholas Clark <nick@ccl4.org> [2013-02-01T11:52:27]
Yeah, my goal was to get blead's changes backported to CPAN, if not blead made -- |
From @jkeenanOn Mon Jan 21 13:12:35 2013, jkeenan wrote:
I'm attaching a patch to fix 3 of the 4 distributions named above which The patch bumps the version number for each distribution in the file Before we apply the patch, however, we should take note of this: In ##### This places the beginning of the 'site' era at 5.7 rather than 5.11. Thank you very much. |
From @jkeenan0001-Update-INSTALLDIRS-to-favor-installation-under-site.patchFrom cbdb3b72da671cbe687f5f9fcae26223f0d8b698 Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Sun, 3 Feb 2013 11:52:44 -0500
Subject: [PATCH] Update INSTALLDIRS to favor installation under 'site'.
For: RT #116479
---
dist/ExtUtils-CBuilder/Makefile.PL | 1 +
dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm | 2 +-
dist/IO/IO.pm | 2 +-
dist/IO/Makefile.PL | 2 +-
dist/Module-CoreList/Makefile.PL | 1 +
dist/Module-CoreList/lib/Module/CoreList.pm | 2 +-
6 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/dist/ExtUtils-CBuilder/Makefile.PL b/dist/ExtUtils-CBuilder/Makefile.PL
index e6b1d16..57014a3 100644
--- a/dist/ExtUtils-CBuilder/Makefile.PL
+++ b/dist/ExtUtils-CBuilder/Makefile.PL
@@ -15,6 +15,7 @@ my %WriteMakefileArgs = (
"ExtUtils::MakeMaker" => "6.30"
},
"EXE_FILES" => [],
+ "INSTALLDIRS" => ($] < 5.011 ? 'perl' : 'site'),
"LICENSE" => "perl",
"PREREQ_PM" => {
"Cwd" => 0,
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
index ad2ea0d..1caba9c 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder.pm
@@ -6,7 +6,7 @@ use File::Basename ();
use Perl::OSType qw/os_type/;
use vars qw($VERSION @ISA);
-$VERSION = '0.280209';
+$VERSION = '0.280210';
$VERSION = eval $VERSION;
# We only use this once - don't waste a symbol table entry on it.
diff --git a/dist/IO/IO.pm b/dist/IO/IO.pm
index 522aaab..2e021c4 100644
--- a/dist/IO/IO.pm
+++ b/dist/IO/IO.pm
@@ -7,7 +7,7 @@ use Carp;
use strict;
use warnings;
-our $VERSION = "1.26";
+our $VERSION = "1.27";
XSLoader::load 'IO', $VERSION;
sub import {
diff --git a/dist/IO/Makefile.PL b/dist/IO/Makefile.PL
index 70ffe12..7783cf9 100644
--- a/dist/IO/Makefile.PL
+++ b/dist/IO/Makefile.PL
@@ -39,7 +39,7 @@ WriteMakefile(
( $PERL_CORE
? ()
: (
- INSTALLDIRS => 'perl',
+ INSTALLDIRS => ($] < 5.011 ? 'perl' : 'site'),
clean => {FILES => 'typemap'},
)
),
diff --git a/dist/Module-CoreList/Makefile.PL b/dist/Module-CoreList/Makefile.PL
index 6235c47..9f86c61 100644
--- a/dist/Module-CoreList/Makefile.PL
+++ b/dist/Module-CoreList/Makefile.PL
@@ -13,6 +13,7 @@ WriteMakefile
'List::Util' => 0,
},
'EXE_FILES' => [ _scripts() ],
+ 'INSTALLDIRS' => ($] < 5.011 ? 'perl' : 'site'),
'PL_FILES' => {},
LICENSE => 'perl',
@extra,
diff --git a/dist/Module-CoreList/lib/Module/CoreList.pm b/dist/Module-CoreList/lib/Module/CoreList.pm
index 354fb83..eea2abc 100644
--- a/dist/Module-CoreList/lib/Module/CoreList.pm
+++ b/dist/Module-CoreList/lib/Module/CoreList.pm
@@ -3,7 +3,7 @@ use strict;
use vars qw/$VERSION %released %version %families %upstream
%bug_tracker %deprecated/;
use Module::CoreList::TieHashDelta;
-$VERSION = '2.81';
+$VERSION = '2.82';
my $dumpinc = 0;
sub import {
--
1.6.3.2
|
From @jkeenanOn Sun Feb 03 09:01:34 2013, jkeenan wrote:
Having subsequently built perl in a branch with the patch applied, I For example, here's a grep on the Makefile for ExtUtils-CBuilder: ##### I read that as saying, "Install into 'perl', not 'site'." Can anyone Thank you very much. |
From @rjbs* Jim wrote:
Jim, your reading is correct. Storable entered core in 5.7.3, when core modules still had to install to "perl" to replace old INSTALLDIRS => $] >= 5.007 ? 'perl' : 'site', It's saying, "If you're installing me on a perl that had me in core, you better install over that The need to install "over" the core's copy in the "perl" dirs was eliminated in 5.12.0 by the "@INC INSTALLDIRS => ( -- |
From @jkeenanOn Fri Mar 01 18:54:06 2013, rjbs wrote:
Following discussion with rjbs at Perl QA Hackathon, I re-created the Thank you very much. |
|
@jkeenan - Status changed from 'open' to 'resolved' |
|
@jkeenan - Status changed from 'resolved' to 'open' |
From @jkeenanI just realized that this RT should remain open. The patches applied |
From gottreu@gmail.comHere's a patch for lib which seems to be the only module in dist/ that |
From gottreu@gmail.com0001-dist-lib-Makefile.PL-change-INSTALLDIRS-to-site-for-.patchFrom 567619a8bc7802dfe6aae5c4468bb23184c15d95 Mon Sep 17 00:00:00 2001
From: Brian Gottreu <gottreu@gmail.com>
Date: Mon, 1 Jul 2013 19:54:03 -0500
Subject: [PATCH] dist/lib/Makefile.PL: change INSTALLDIRS to 'site' for 5.12
and later
---
dist/lib/Makefile.PL | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dist/lib/Makefile.PL b/dist/lib/Makefile.PL
index 1f80b02..129a703 100644
--- a/dist/lib/Makefile.PL
+++ b/dist/lib/Makefile.PL
@@ -31,7 +31,7 @@ WriteMakefile(
'PREREQ_PM' => {},
'ABSTRACT_FROM' => 'lib_pm.PL',
'AUTHOR' => 'Steffen Mueller <smueller@cpan.org>',
- 'INSTALLDIRS' => 'perl',
+ 'INSTALLDIRS' => ($] < 5.012 ? 'perl' : 'site'),
'PL_FILES' => {'lib_pm.PL' => 'lib.pm'},
'PM' => {'lib.pm' => '$(INST_LIBDIR)/lib.pm'},
'clean' => {FILES => 'lib.pm'},
--
1.7.10.4
|
From @jkeenanOn Mon Jul 01 18:13:08 2013, gottreu wrote:
Applied to blead in commit 2ed0bf6. This RT remains open because Thank you very much. |
From @rjbsOn Mon Jul 01 19:15:03 2013, jkeenan wrote:
A useful task for a would-be contributor: supplying a list of not-yet-patched dists under ./cpan, -- |
From gottreu@gmail.comOn Mon Jul 01 19:30:05 2013, rjbs wrote:
There are 8 remaining modules that install to the wrong place. Devel::PPPort and Time::Piece have UPSTREAM set to 'undef' and undef respectively in For the remaining 6, all but one had open tickets with patches already. I submitted a DB_File https://rt.cpan.org/Public/Bug/Display.html?id=70420 Brian Gottreu |
From gottreu@gmail.com0001-Change-INSTALLDIRS-to-site-for-5.12-and-later.patchFrom d02cd94cf15155eeedd4d8e8eb1b227d817cda35 Mon Sep 17 00:00:00 2001
From: Brian Gottreu <gottreu@gmail.com>
Date: Mon, 1 Jul 2013 22:04:05 -0500
Subject: [PATCH] Change INSTALLDIRS to 'site' for 5.12 and later
---
cpan/Devel-PPPort/Makefile.PL | 2 +-
cpan/Time-Piece/Makefile.PL | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpan/Devel-PPPort/Makefile.PL b/cpan/Devel-PPPort/Makefile.PL
index 8a77ae5..3c1d479 100644
--- a/cpan/Devel-PPPort/Makefile.PL
+++ b/cpan/Devel-PPPort/Makefile.PL
@@ -72,7 +72,7 @@ sub configure
}
else {
# Devel::PPPort is in the core since 5.7.3
- push @moreopts, INSTALLDIRS => ($] >= 5.007003 ? 'perl' : 'site');
+ push @moreopts, INSTALLDIRS => ($] >= 5.007003 and $] < 5.012 ? 'perl' : 'site');
}
if ($opt{'apicheck'}) {
diff --git a/cpan/Time-Piece/Makefile.PL b/cpan/Time-Piece/Makefile.PL
index 9b2a964..f4e944d 100644
--- a/cpan/Time-Piece/Makefile.PL
+++ b/cpan/Time-Piece/Makefile.PL
@@ -7,5 +7,5 @@ WriteMakefile(
'VERSION_FROM' => 'Piece.pm', # finds $VERSION
'AUTHOR' => 'Matt Sergeant',
'ABSTRACT_FROM' => 'Piece.pm',
- 'INSTALLDIRS' => ( $] >= 5.009005 ? 'perl' : 'site' ),
+ 'INSTALLDIRS' => ( $] >= 5.009005 && $] < 5.012 ? 'perl' : 'site' ),
);
--
1.7.10.4
|
From gottreu@gmail.comDigest::MD5 and MIME::Base64 have been patched and the updates are on |
From [Unknown Contact. See original ticket]Digest::MD5 and MIME::Base64 have been patched and the updates are on |
From @rjbs* Brian Gottreu via RT <perlbug-followup@perl.org> [2013-07-01T23:27:49]
Thanks, Brian. I will be taking over Time::Piece this week and will apply the
Thanks again. That is a *very* useful list for me. -- |
From @pmqsThere seem to be a number of variations on the value used for the Perl lower version for this test in both this thread and in existing modules, so can I confirm the absolute lower bound version for this test is 5.007? The lower bound actually used then needs to be the version when the module was first included with core (assuming that is prior to 5.012)? Paul |
From gottreu@gmail.comOn Jul 4, 2013 12:42 PM, "Paul Marquess" <Paul.Marquess@ntlworld.com> wrote:
IPC::SysV checks against 5.005. It seems to be the only one checking lower
Yes, that is my understanding. Brian Gottreu |
From @LeontOn Thu, Jul 4, 2013 at 8:42 PM, Brian Gottreu <gottreu@gmail.com> wrote:
Most dists don't have their CPAN Makefile.PL, for simple distributions Wih a minicpan checkout, someone could use Porting/Maintainers.pl to Leon |
From @pmqs
Thanks Brian. Paul |
From gottreu@gmail.comThese are the modules that need to be updated on CPAN. I downloaded all the distributions listed in These sixty (60) distributions create a Makefile from Makefile.PL that sets INSTALLDIRS to 'perl' instead In addition, these three (3) distributions set installdirs in Build.PL to 'core' rather than 'site': These twenty (20) are in dist/ in the core, the rest are in cpan/. |
From @LeontOn Sun, Jul 7, 2013 at 11:27 PM, Brian Gottreu via RT
I just patched that in repo. Leon |
From @sciuriusFixed in Getopt::Long 2.41 and on its way to CPAN. |
From @jkeenanOn Sun Jul 29 05:39:50 2012, LeonT wrote:
Leon, Is this the same problem as is being tracked in Thank you very much. |
From @LeontOn Wed, Jul 24, 2013 at 3:17 AM, James E Keenan via RT
Yes it is. Leon |
From @jkeenanLeonT has confirmed that RT #114278 and #116479 describe the same Thank you very much. |
From @dolmenLe Dim. Jul. 07 14:27:12 2013, gottreu a �crit�:
Patch submitted: |
From @dolmenLe Dim. Jul. 07 14:27:12 2013, gottreu a �crit�:
Patch submitted: briandfoy/pod-perldoc#9 |
From @jkeenanOn Sun Jul 07 14:27:12 2013, gottreu wrote:
[snip]
I had occasion to look at this ticket again while looking at https://rt.cpan.org/Ticket/Display.html?id=89664 this evening. Only a subset of these distributions have their own Makefile.PL. 1. Two of these distros use 5.012 as the cut-off rather than 5.011. Is that acceptable? dist/lib/Makefile.PL 2. I have prepared a patch for dist/Cwd/Makefile.PL. ##### Can anyone diagnose this? Thank you very much. |
From @jkeenan116479-cwd-insufficient.patchdiff --git a/dist/Cwd/Cwd.pm b/dist/Cwd/Cwd.pm
index d9de63c..19d72b6 100644
--- a/dist/Cwd/Cwd.pm
+++ b/dist/Cwd/Cwd.pm
@@ -171,7 +171,7 @@ use strict;
use Exporter;
use vars qw(@ISA @EXPORT @EXPORT_OK $VERSION);
-$VERSION = '3.45';
+$VERSION = '3.46';
my $xs_version = $VERSION;
$VERSION =~ tr/_//;
diff --git a/dist/Cwd/Makefile.PL b/dist/Cwd/Makefile.PL
index 1add839..999d5e2 100644
--- a/dist/Cwd/Makefile.PL
+++ b/dist/Cwd/Makefile.PL
@@ -18,7 +18,7 @@ WriteMakefile
'Scalar::Util' => '0',
'Test' => '0'
},
- 'INSTALLDIRS' => 'perl',
+ 'INSTALLDIRS' => ($] < 5.011 ? 'perl' : 'site'),
'EXE_FILES' => [],
'PL_FILES' => {}
)
|
From @LeontOn Mon, Jan 21, 2013 at 5:05 PM, Ricardo SIGNES
cpan-grep shows 39 distributions still having this issues[1]. A few of them Leon 1: http://grep.cpan.me/?q=INSTALLDIRS\s*%3D%3E\s*[%27%22]perl%20file%3A<http://grep.cpan.me/?q=INSTALLDIRS%5Cs*%3D%3E%5Cs*[%27%22]perl%20file%3A> |
From @rjbs* James E Keenan via RT <perlbug-followup@perl.org> [2013-11-23T23:23:43]
Yes.
Hm. Is it possible that we need to check $ENV{PERL_CORE} also? Anyone? -- |
From @nwc10On Wed, Nov 27, 2013 at 09:33:01AM -0500, Ricardo Signes wrote:
For any meaningful purpose, odd numbered blead development releases No-one should have them installed, and for actually figuring out what caused Nicholas Clark |
Migrated from rt.perl.org#116479 (status was 'open')
Searchable as RT116479$
The text was updated successfully, but these errors were encountered: