Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/GDBM_File/t/gdbm.t: intermittent failures #16753

Closed
p5pRT opened this issue Nov 17, 2018 · 11 comments
Closed

ext/GDBM_File/t/gdbm.t: intermittent failures #16753

p5pRT opened this issue Nov 17, 2018 · 11 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 17, 2018

Migrated from rt.perl.org#133664 (status was 'resolved')

Searchable as RT133664$

@p5pRT
Copy link
Author

p5pRT commented Nov 17, 2018

From @jkeenan

Over the last few days I've started to get failures in
ext/GDBM_File/t/gdbm.t in blead.

When I run 'make test_harness', I tend to get these​:

#####
Test Summary Report


../ext/GDBM_File/t/gdbm.t (Wstat​:
512 Tests​: 134 Failed​: 2)
  Failed tests​: 4, 7
  Non-zero exit status​: 2
Files=2628, Tests=1170069, 553 wallclock secs (108.11 usr 11.28 sys +
642.00 cusr 51.37 csys = 812.76 CPU)
Result​: FAIL
makefile​:843​: recipe for target 'test_harness' failed
make​: *** [test_harness] Error 2
#####

When I run only ext/GDBM_File/t/gdbm.t through 't/harness', I get a PASS​:

#####
$ cd t;./perl harness ../ext/GDBM_File/t/gdbm.t; cd -
../ext/GDBM_File/t/gdbm.t .. ok
All tests successful.
Files=1, Tests=134, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.05 cusr
0.01 csys = 0.08 CPU)
Result​: PASS
#####

When I run it through the harness along with test files from *other
directories*, I also get a PASS​:

#####
cd t;./perl harness ../ext/GDBM_File/t/gdbm.t perf/benchmarks.t
op/write.t ../ext/File-Find/t/*.t; cd -
perf/benchmarks.t ........... ok
../ext/File-Find/t/find.t ... ok
../ext/File-Find/t/taint.t .. ok
op/write.t .................. ok
../ext/GDBM_File/t/gdbm.t ... ok
All tests successful.
Files=5, Tests=2769, 1 wallclock secs ( 0.19 usr 0.02 sys + 0.42 cusr
  0.05 csys = 0.68 CPU)
Result​: PASS
#####

But when I run it through the harness along with *the other test file in
ext/GDBM_File/t/, I get *different* failures from those which I got with
'make test_harness'​:

#####
$ cd t;./perl harness ../ext/GDBM_File/t/gdbm.t
../ext/GDBM_File/t/fatal.t perf/benchmarks.t op/write.t; cd -
perf/benchmarks.t ........... ok
../ext/GDBM_File/t/fatal.t .. ok
===( 2210;0 6/? 468/624 )==========================================
# Failed test 'undef isa 'GDBM_File''
# at ../../t/lib/dbmt_common.pl line 77.
# undef isn't defined

# Failed test at ../../t/lib/dbmt_common.pl line 105.
# got​: '16'
# expected​: '29'

# Failed test at ../../t/lib/dbmt_common.pl line 106.
# got​: '16'
# expected​: '29'

# Failed test at ../../t/lib/dbmt_common.pl line 115.
# got​: '17'
# expected​: '30'

# Failed test at ../../t/lib/dbmt_common.pl line 118.
# got​: '18'
# expected​: '31'
Use of uninitialized value $got in numeric gt (>) at (eval in cmp_ok)
../../t/lib/dbmt_common.pl line 130.

# Failed test at ../../t/lib/dbmt_common.pl line 130.
Use of uninitialized value $val in addition (+) at
../../lib/Test/Builder.pm line 761.
# undef
# >
# '0'
op/write.t .................. ok
../ext/GDBM_File/t/gdbm.t ... 25/? # Looks like you failed 6 tests of 134.
../ext/GDBM_File/t/gdbm.t ... Dubious, test returned 6 (wstat 1536, 0x600)
Failed 6/134 subtests

Test Summary Report


../ext/GDBM_File/t/gdbm.t (Wstat​: 1536 Tests​: 134 Failed​: 6)
  Failed tests​: 7-11, 13
  Non-zero exit status​: 6
Files=4, Tests=2494, 1 wallclock secs ( 0.15 usr 0.01 sys + 0.33 cusr
  0.04 csys = 0.53 CPU)
Result​: FAIL
#####

I suspect that this is related to​:

#####
commit 9b0adf1
Author​: Karl Williamson <khw@​cpan.org>
Date​: Tue Jul 24 20​:26​:39 2018 -0600

  Add more parallelism to t/harness
#####

But the fix I tried for ext/File-Find/t in commit
ed0ccc6 doesn't seem to work in this
case. (Indeed, it's no longer working even in the original case. See
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133658#txn-1594365.)

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Nov 17, 2018

From @jkeenan

On Sat, 17 Nov 2018 22​:19​:41 GMT, jkeenan@​pobox.com wrote​:

Over the last few days I've started to get failures in
ext/GDBM_File/t/gdbm.t in blead.

When I run 'make test_harness', I tend to get these​:

#####
Test Summary Report
-------------------
../ext/GDBM_File/t/gdbm.t (Wstat​:
512 Tests​: 134 Failed​: 2)
Failed tests​: 4, 7
Non-zero exit status​: 2
Files=2628, Tests=1170069, 553 wallclock secs (108.11 usr 11.28 sys +
642.00 cusr 51.37 csys = 812.76 CPU)
Result​: FAIL
makefile​:843​: recipe for target 'test_harness' failed
make​: *** [test_harness] Error 2
#####

When I run only ext/GDBM_File/t/gdbm.t through 't/harness', I get a PASS​:

#####
$ cd t;./perl harness ../ext/GDBM_File/t/gdbm.t; cd -
../ext/GDBM_File/t/gdbm.t .. ok
All tests successful.
Files=1, Tests=134, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.05 cusr
0.01 csys = 0.08 CPU)
Result​: PASS
#####

When I run it through the harness along with test files from *other
directories*, I also get a PASS​:

#####
cd t;./perl harness ../ext/GDBM_File/t/gdbm.t perf/benchmarks.t
op/write.t ../ext/File-Find/t/*.t; cd -
perf/benchmarks.t ........... ok
../ext/File-Find/t/find.t ... ok
../ext/File-Find/t/taint.t .. ok
op/write.t .................. ok
../ext/GDBM_File/t/gdbm.t ... ok
All tests successful.
Files=5, Tests=2769, 1 wallclock secs ( 0.19 usr 0.02 sys + 0.42 cusr
0.05 csys = 0.68 CPU)
Result​: PASS
#####

But when I run it through the harness along with *the other test file in
ext/GDBM_File/t/, I get *different* failures from those which I got with
'make test_harness'​:

#####
$ cd t;./perl harness ../ext/GDBM_File/t/gdbm.t
../ext/GDBM_File/t/fatal.t perf/benchmarks.t op/write.t; cd -
perf/benchmarks.t ........... ok
../ext/GDBM_File/t/fatal.t .. ok
===( 2210;0 6/? 468/624 )==========================================
# Failed test 'undef isa 'GDBM_File''
# at ../../t/lib/dbmt_common.pl line 77.
# undef isn't defined

# Failed test at ../../t/lib/dbmt_common.pl line 105.
# got​: '16'
# expected​: '29'

# Failed test at ../../t/lib/dbmt_common.pl line 106.
# got​: '16'
# expected​: '29'

# Failed test at ../../t/lib/dbmt_common.pl line 115.
# got​: '17'
# expected​: '30'

# Failed test at ../../t/lib/dbmt_common.pl line 118.
# got​: '18'
# expected​: '31'
Use of uninitialized value $got in numeric gt (>) at (eval in cmp_ok)
../../t/lib/dbmt_common.pl line 130.

# Failed test at ../../t/lib/dbmt_common.pl line 130.
Use of uninitialized value $val in addition (+) at
../../lib/Test/Builder.pm line 761.
# undef
# >
# '0'
op/write.t .................. ok
../ext/GDBM_File/t/gdbm.t ... 25/? # Looks like you failed 6 tests of 134.
../ext/GDBM_File/t/gdbm.t ... Dubious, test returned 6 (wstat 1536, 0x600)
Failed 6/134 subtests

Test Summary Report
-------------------
../ext/GDBM_File/t/gdbm.t (Wstat​: 1536 Tests​: 134 Failed​: 6)
Failed tests​: 7-11, 13
Non-zero exit status​: 6
Files=4, Tests=2494, 1 wallclock secs ( 0.15 usr 0.01 sys + 0.33 cusr
0.04 csys = 0.53 CPU)
Result​: FAIL
#####

I suspect that this is related to​:

#####
commit 9b0adf1
Author​: Karl Williamson <khw@​cpan.org>
Date​: Tue Jul 24 20​:26​:39 2018 -0600

 Add more parallelism to t/harness

#####

But the fix I tried for ext/File-Find/t in commit
ed0ccc6 doesn't seem to work in this
case. (Indeed, it's no longer working even in the original case. See
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133658#txn-1594365.)

Thank you very much.
Jim Keenan

Here is a partial diagnosis of the problem (which is likely to apply to the re-opened https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133658 as well)​:

When you call​:

#####
cd t; ./perl harness [some list of test files possibly with shell expansion]; cd -
#####

... the list of test files gets picked up by t/harness here​:

#####
93 if (@​ARGV) {
94 # If you want these run in speed order, just use prove
95 if ($^O eq 'MSWin32') {
96 @​tests = map(glob($_),@​ARGV);
97 }
98 else {
99 @​tests = @​ARGV;
100 }
101 # This is a hack to force config_heavy.pl to be loaded, before the
102 # prep work for running a test changes directory.
103 1 if $Config{d_fork};
#####

(Try out the t-harness-debugging.diff attachment to see this more easily.)

By being assigned to @​tests -- the list of tests that ultimately gets passed to TAP​::Harness->runtests -- here, the files listed on the command-line (or derived via shell expansion) avoid getting examined for belonging to the list of directories -- %serials -- whose individual test files should *not* be run in parallel. That examination only takes place deep inside the 'else' block following the 'if' block cited above.

#####
191 # Add exceptions to the above rule
192 for (qw(ext/Pod-Html/t ext/File-Find/t)) {
193 $serials{$_} = 1;
194 }
195
196 # Remove the serial testing directories from the list of all
197 # directories. The remaining ones are testable in parallel. Make the
198 # parallel list a scalar with names separated by '|' so that below
199 # they will be added to a regular expression.
200 my $non_serials = join "|", grep { not exists $serials{$_} } keys %all_dirs;
201 undef %all_dirs;
202 undef %serials;
203
204 for (@​last) {
205 # Treat every file in each non-serial directory as its own
206 # "directory", so that it can be executed in parallel
207 m! \A ( \.\. / (?​: $non_serials )
208 / [^/]+ \.t \z | .* [/] ) !x
209 or die "'$_'";
210 push @​{$dir{$1}}, $_;
211
212 # This file contributes time to the total needed for the directory
213 # as a whole
214 $total_time{$1} += $times{$_} || 0;
215 }
216 #print STDERR __LINE__, join "\n", sort { $total_time{$b} <=> $total_time{$a} } keys %dir, " ";
217
218 push @​tests, @​last;
#####

This 'else' block is (I think) what gets exercised when you say 'make test_harness'. That would explain why certain failures do not show up during 'make test_harness' and do not show up in smoke test reports when the testing rig is configured -- as most but not all are -- to run t/harness but not t/TEST.pl.

This logic for separate handling of non-parallelizable directories during 'make test_harness' was added by Karl, mostly in commit 9b0adf1, in July of this year. I think something like that needs to be added to the 'if' block as well.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Nov 17, 2018

From @jkeenan

t-harness-debugging.diff
diff --git a/t/harness b/t/harness
index da5c017695..bb374e14d2 100644
--- a/t/harness
+++ b/t/harness
@@ -91,6 +91,7 @@ if ($ENV{HARNESS_OPTIONS}) {
 }
 
 if (@ARGV) {
+print STDERR "XXX: There are files in \@ARGV\n";
     # If you want these run in speed order, just use prove
     if ($^O eq 'MSWin32') {
 	@tests = map(glob($_),@ARGV);
@@ -98,10 +99,12 @@ if (@ARGV) {
     else {
 	@tests = @ARGV;
     }
+print STDERR "XXX1: \@tests: @tests\n";
     # This is a hack to force config_heavy.pl to be loaded, before the
     # prep work for running a test changes directory.
     1 if $Config{d_fork};
 } else {
+print STDERR "YYY: \n";
     # Ideally we'd get somewhere close to Tux's Oslo rules
     # my $rules = {
     #     par => [

@p5pRT
Copy link
Author

p5pRT commented Nov 17, 2018

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 18, 2018

From @jkeenan

On Sat, 17 Nov 2018 23​:23​:40 GMT, jkeenan wrote​:

On Sat, 17 Nov 2018 22​:19​:41 GMT, jkeenan@​pobox.com wrote​:

Over the last few days I've started to get failures in
ext/GDBM_File/t/gdbm.t in blead.

When I run 'make test_harness', I tend to get these​:

#####
Test Summary Report
-------------------
../ext/GDBM_File/t/gdbm.t
(Wstat​:
512 Tests​: 134 Failed​: 2)
Failed tests​: 4, 7
Non-zero exit status​: 2
Files=2628, Tests=1170069, 553 wallclock secs (108.11 usr 11.28 sys +
642.00 cusr 51.37 csys = 812.76 CPU)
Result​: FAIL
makefile​:843​: recipe for target 'test_harness' failed
make​: *** [test_harness] Error 2
#####

When I run only ext/GDBM_File/t/gdbm.t through 't/harness', I get a
PASS​:

#####
$ cd t;./perl harness ../ext/GDBM_File/t/gdbm.t; cd -
../ext/GDBM_File/t/gdbm.t .. ok
All tests successful.
Files=1, Tests=134, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.05
cusr
0.01 csys = 0.08 CPU)
Result​: PASS
#####

When I run it through the harness along with test files from *other
directories*, I also get a PASS​:

#####
cd t;./perl harness ../ext/GDBM_File/t/gdbm.t perf/benchmarks.t
op/write.t ../ext/File-Find/t/*.t; cd -
perf/benchmarks.t ........... ok
../ext/File-Find/t/find.t ... ok
../ext/File-Find/t/taint.t .. ok
op/write.t .................. ok
../ext/GDBM_File/t/gdbm.t ... ok
All tests successful.
Files=5, Tests=2769, 1 wallclock secs ( 0.19 usr 0.02 sys + 0.42
cusr
0.05 csys = 0.68 CPU)
Result​: PASS
#####

But when I run it through the harness along with *the other test file
in
ext/GDBM_File/t/, I get *different* failures from those which I got
with
'make test_harness'​:

#####
$ cd t;./perl harness ../ext/GDBM_File/t/gdbm.t
../ext/GDBM_File/t/fatal.t perf/benchmarks.t op/write.t; cd -
perf/benchmarks.t ........... ok
../ext/GDBM_File/t/fatal.t .. ok
===( 2210;0 6/? 468/624
)==========================================
# Failed test 'undef isa 'GDBM_File''
# at ../../t/lib/dbmt_common.pl line 77.
# undef isn't defined

# Failed test at ../../t/lib/dbmt_common.pl line 105.
# got​: '16'
# expected​: '29'

# Failed test at ../../t/lib/dbmt_common.pl line 106.
# got​: '16'
# expected​: '29'

# Failed test at ../../t/lib/dbmt_common.pl line 115.
# got​: '17'
# expected​: '30'

# Failed test at ../../t/lib/dbmt_common.pl line 118.
# got​: '18'
# expected​: '31'
Use of uninitialized value $got in numeric gt (>) at (eval in
cmp_ok)
../../t/lib/dbmt_common.pl line 130.

# Failed test at ../../t/lib/dbmt_common.pl line 130.
Use of uninitialized value $val in addition (+) at
../../lib/Test/Builder.pm line 761.
# undef
# >
# '0'
op/write.t .................. ok
../ext/GDBM_File/t/gdbm.t ... 25/? # Looks like you failed 6 tests of
134.
../ext/GDBM_File/t/gdbm.t ... Dubious, test returned 6 (wstat 1536,
0x600)
Failed 6/134 subtests

Test Summary Report
-------------------
../ext/GDBM_File/t/gdbm.t (Wstat​: 1536 Tests​: 134 Failed​: 6)
Failed tests​: 7-11, 13
Non-zero exit status​: 6
Files=4, Tests=2494, 1 wallclock secs ( 0.15 usr 0.01 sys + 0.33
cusr
0.04 csys = 0.53 CPU)
Result​: FAIL
#####

I suspect that this is related to​:

#####
commit 9b0adf1
Author​: Karl Williamson <khw@​cpan.org>
Date​: Tue Jul 24 20​:26​:39 2018 -0600

Add more parallelism to t/harness
#####

But the fix I tried for ext/File-Find/t in commit
ed0ccc6 doesn't seem to work in this
case. (Indeed, it's no longer working even in the original case.
See
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133658#txn-1594365.)

Thank you very much.
Jim Keenan

Here is a partial diagnosis of the problem (which is likely to apply
to the re-opened https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133658 as
well)​:

When you call​:

#####
cd t; ./perl harness [some list of test files possibly with shell
expansion]; cd -
#####

... the list of test files gets picked up by t/harness here​:

#####
93 if (@​ARGV) {
94 # If you want these run in speed order, just use prove
95 if ($^O eq 'MSWin32') {
96 @​tests = map(glob($_),@​ARGV);
97 }
98 else {
99 @​tests = @​ARGV;
100 }
101 # This is a hack to force config_heavy.pl to be loaded, before
the
102 # prep work for running a test changes directory.
103 1 if $Config{d_fork};
#####

(Try out the t-harness-debugging.diff attachment to see this more
easily.)

By being assigned to @​tests -- the list of tests that ultimately gets
passed to TAP​::Harness->runtests -- here, the files listed on the
command-line (or derived via shell expansion) avoid getting examined
for belonging to the list of directories -- %serials -- whose
individual test files should *not* be run in parallel. That
examination only takes place deep inside the 'else' block following
the 'if' block cited above.

#####
191 # Add exceptions to the above rule
192 for (qw(ext/Pod-Html/t ext/File-Find/t)) {
193 $serials{$_} = 1;
194 }
195
196 # Remove the serial testing directories from the list of
all
197 # directories. The remaining ones are testable in
parallel. Make the
198 # parallel list a scalar with names separated by '|' so
that below
199 # they will be added to a regular expression.
200 my $non_serials = join "|", grep { not exists $serials{$_}
} keys %all_dirs;
201 undef %all_dirs;
202 undef %serials;
203
204 for (@​last) {
205 # Treat every file in each non-serial directory as its
own
206 # "directory", so that it can be executed in parallel
207 m! \A ( \.\. / (?​: $non_serials )
208 / [^/]+ \.t \z | .* [/] ) !x
209 or die "'$_'";
210 push @​{$dir{$1}}, $_;
211
212 # This file contributes time to the total needed for
the directory
213 # as a whole
214 $total_time{$1} += $times{$_} || 0;
215 }
216 #print STDERR __LINE__, join "\n", sort { $total_time{$b}
<=> $total_time{$a} } keys %dir, " ";
217
218 push @​tests, @​last;
#####

This 'else' block is (I think) what gets exercised when you say 'make
test_harness'. That would explain why certain failures do not show up
during 'make test_harness' and do not show up in smoke test reports
when the testing rig is configured -- as most but not all are -- to
run t/harness but not t/TEST.pl.

This logic for separate handling of non-parallelizable directories
during 'make test_harness' was added by Karl, mostly in commit
9b0adf1, in July of this year. I think something like that needs
to be added to the 'if' block as well.

Working on this in branch 'jkeenan/133664-harness'. Not ready for prime time.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Nov 19, 2018

From @iabyn

On Sat, Nov 17, 2018 at 06​:36​:57PM -0800, James E Keenan via RT wrote​:

../ext/GDBM_File/t/gdbm.t
(Wstat​:
512 Tests​: 134 Failed​: 2)

I suspect that this is related to​:

#####
commit 9b0adf1
Author​: Karl Williamson <khw@​cpan.org>
Date​: Tue Jul 24 20​:26​:39 2018 -0600

Add more parallelism to t/harness

I've fixed GDBM with this​:

commit d33f9fb
Author​: David Mitchell <davem@​iabyn.com>
AuthorDate​: Mon Nov 19 13​:52​:46 2018 +0000
Commit​: David Mitchell <davem@​iabyn.com>
CommitDate​: Mon Nov 19 13​:52​:46 2018 +0000

  ext/GDBM_File/t/fatal.t​: support parallel testing
 
  t/harness was recently modified to run tests under ext/ etc in parallel.
  ext/GDBM_File/t/ has two test scripts which both use the same filename.
  Make fatal.t use a different name, so that it can run in parallel with
  the other script.

M ext/GDBM_File/t/fatal.t

--
The Enterprise is involved in a bizarre time-warp experience which is in
some way unconnected with the Late 20th Century.
  -- Things That Never Happen in "Star Trek" #14

@p5pRT
Copy link
Author

p5pRT commented Nov 19, 2018

From @jkeenan

On Mon, 19 Nov 2018 13​:59​:12 GMT, davem wrote​:

On Sat, Nov 17, 2018 at 06​:36​:57PM -0800, James E Keenan via RT wrote​:

../ext/GDBM_File/t/gdbm.t
(Wstat​:
512 Tests​: 134 Failed​: 2)

I suspect that this is related to​:

#####
commit 9b0adf1
Author​: Karl Williamson <khw@​cpan.org>
Date​: Tue Jul 24 20​:26​:39 2018 -0600

Add more parallelism to t/harness

I've fixed GDBM with this​:

commit d33f9fb
Author​: David Mitchell <davem@​iabyn.com>
AuthorDate​: Mon Nov 19 13​:52​:46 2018 +0000
Commit​: David Mitchell <davem@​iabyn.com>
CommitDate​: Mon Nov 19 13​:52​:46 2018 +0000

ext/GDBM\_File/t/fatal\.t&#8203;: support parallel testing

t/harness was recently modified to run tests under ext/ etc in parallel\.
ext/GDBM\_File/t/ has two test scripts which both use the same filename\.
Make fatal\.t use a different name\, so that it can run in parallel with
the other script\.

M ext/GDBM_File/t/fatal.t

I'll take this ticket for the purpose of monitoring smoke test results and close it in several days if things look good.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Nov 29, 2018

From @jkeenan

On Mon, 19 Nov 2018 23​:17​:40 GMT, jkeenan wrote​:

On Mon, 19 Nov 2018 13​:59​:12 GMT, davem wrote​:

On Sat, Nov 17, 2018 at 06​:36​:57PM -0800, James E Keenan via RT
wrote​:

../ext/GDBM_File/t/gdbm.t
(Wstat​:
512 Tests​: 134 Failed​: 2)

I suspect that this is related to​:

#####
commit 9b0adf1
Author​: Karl Williamson <khw@​cpan.org>
Date​: Tue Jul 24 20​:26​:39 2018 -0600

Add more parallelism to t/harness

I've fixed GDBM with this​:

commit d33f9fb
Author​: David Mitchell <davem@​iabyn.com>
AuthorDate​: Mon Nov 19 13​:52​:46 2018 +0000
Commit​: David Mitchell <davem@​iabyn.com>
CommitDate​: Mon Nov 19 13​:52​:46 2018 +0000

ext/GDBM_File/t/fatal.t​: support parallel testing

t/harness was recently modified to run tests under ext/ etc in
parallel.
ext/GDBM_File/t/ has two test scripts which both use the same
filename.
Make fatal.t use a different name, so that it can run in parallel
with
the other script.

M ext/GDBM_File/t/fatal.t

I'll take this ticket for the purpose of monitoring smoke test results
and close it in several days if things look good.

Thank you very much.

Though we're still experiencing test failures in ext/GDBM_File/t on certain platforms, those failures appear to be due to problems with the (newer) versions of gdbm thereupon.

So this ticket is closable.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Nov 29, 2018

@jkeenan - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 22, 2019

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.30.0, this and 160 other issues have been
resolved.

Perl 5.30.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.30.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT
Copy link
Author

p5pRT commented May 22, 2019

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant